From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85388E7849A for ; Mon, 2 Oct 2023 12:40:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DB9C810E2AD; Mon, 2 Oct 2023 12:40:38 +0000 (UTC) Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1361410E16A for ; Sat, 30 Sep 2023 16:52:22 +0000 (UTC) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-40566f89f6eso124879495e9.3 for ; Sat, 30 Sep 2023 09:52:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20230601.gappssmtp.com; s=20230601; t=1696092741; x=1696697541; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TP49E0lt1lRfwVwEUZNQYaCBfTY4UGz9ptrNHBZhxcM=; b=O2nqIdXg3TdpRzKs5kRGC/9SFOJx06XZXwFUUBMUsj3IIqyTw9Gx1lNrL+L52HDXZr ay50+9YqTAIJs2iR1GI0I1TtI+WhrV30g2n+Dhi8isY1VzTh3dmqHBYEN0KO309S48hI QmmwtmjKkiHqhkp+w9owJ5OY3Zivlu3WuV48k7/bWhNcMLHI7jppawD+k2RqQ80EO/gs ozsBsfMv04H4gUbO+Qy1P9CPejHmN7g2R4QTnalrhLif56LJMELsku52Fc9ryqNP6lgR ODrFIy2Rxqpt6pP69SPckaxyqx/dKTNwD3918B3erffvd1rAHKJCr+LOLRdyxNFS6J02 VMuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696092741; x=1696697541; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TP49E0lt1lRfwVwEUZNQYaCBfTY4UGz9ptrNHBZhxcM=; b=w4d9fEoPrugFTznba7KximybNGruipARhbLd/r67JI+HWn7Dc0EmYHd4V29l3/h2UP zJYLVFPJ668hBNmlela9TPCOrBxJlM1ZbLNeEEXzK0hwP1aAfZhmL28reYqNMMb3Ycys ANykayVe0sNk94MJg4UhwUZ1Nmph9dyP40Fo8A0zTO6QTsMwWGVzOBOtaqjjTbZixjMd 1QiVfWmxRaUC9us6EiO8/Pp9FhmpWius/ZDp02nOnPifULb2KyX43LXo4S3mkSSdhmuO /1eyuSFo0JckVq3oKFJUgtvYjs+DQIuX2SBnwzdBXXrKyNdNf2ao5ESI0i5644nALD4s Ou+g== X-Gm-Message-State: AOJu0Yx3f/xZdH4KTj3xkQ040UBwb0nEHOyHfzs56nyxmrGJ5AIlGi9w wvNETY3wO/vELU91Es8qRtEquA== X-Google-Smtp-Source: AGHT+IFufhUosQmDbdYYO0lgqH5WgmabRsKPy1NuiT6FdEpd1klh9Lx806UT3kRvn4yTyQ0Y4WLs9Q== X-Received: by 2002:adf:cf0a:0:b0:323:1689:6607 with SMTP id o10-20020adfcf0a000000b0032316896607mr6789063wrj.5.1696092741022; Sat, 30 Sep 2023 09:52:21 -0700 (PDT) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id u1-20020adfed41000000b003247d3e5d99sm4921066wro.55.2023.09.30.09.52.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Sep 2023 09:52:20 -0700 (PDT) Date: Sat, 30 Sep 2023 17:52:17 +0100 From: Phillip Potter To: Joel Granados Message-ID: References: <20230928-jag-sysctl_remove_empty_elem_drivers-v1-0-e59120fca9f9@samsung.com> <20230928-jag-sysctl_remove_empty_elem_drivers-v1-1-e59120fca9f9@samsung.com> <2023092855-cultivate-earthy-4d25@gregkh> <20230929121730.bwzhrpaptf45smfy@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230929121730.bwzhrpaptf45smfy@localhost> X-Mailman-Approved-At: Mon, 02 Oct 2023 12:40:24 +0000 Subject: Re: [Intel-gfx] [PATCH 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Jason A. Donenfeld" , Steve Wahl , Clemens Ladisch , linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Song Liu , Eric Dumazet , "K. Y. Srinivasan" , Jiri Slaby , Russ Weight , Wei Liu , Stefano Stabellini , Corey Minyard , Leon Romanovsky , linux-rdma@vger.kernel.org, David Airlie , "Rafael J. Wysocki" , Dexuan Cui , willy@infradead.org, Jason Gunthorpe , linux-serial@vger.kernel.org, Doug Gilbert , Jakub Kicinski , Paolo Abeni , Haiyang Zhang , Kees Cook , Arnd Bergmann , "James E.J. Bottomley" , intel-gfx@lists.freedesktop.org, josh@joshtriplett.org, linux-raid@vger.kernel.org, Rodrigo Vivi , xen-devel@lists.xenproject.org, openipmi-developer@lists.sourceforge.net, Juergen Gross , Theodore Ts'o , linux-scsi@vger.kernel.org, "Martin K. Petersen" , netdev@vger.kernel.org, David Ahern , Robin Holt , Sudip Mukherjee , Oleksandr Tyshchenko , Luis Chamberlain , Daniel Vetter , Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Sep 29, 2023 at 02:17:30PM +0200, Joel Granados wrote: > On Thu, Sep 28, 2023 at 03:36:55PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Sep 28, 2023 at 03:21:26PM +0200, Joel Granados via B4 Relay wrote: > > > From: Joel Granados > > > > > > This commit comes at the tail end of a greater effort to remove the > > > empty elements at the end of the ctl_table arrays (sentinels) which > > > will reduce the overall build time size of the kernel and run time > > > memory bloat by ~64 bytes per sentinel (further information Link : > > > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/) > > > > > > Remove sentinel element from cdrom_table > > > > > > Signed-off-by: Joel Granados > > > --- > > > drivers/cdrom/cdrom.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c > > > index cc2839805983..451907ade389 100644 > > > --- a/drivers/cdrom/cdrom.c > > > +++ b/drivers/cdrom/cdrom.c > > > @@ -3654,8 +3654,7 @@ static struct ctl_table cdrom_table[] = { > > > .maxlen = sizeof(int), > > > .mode = 0644, > > > .proc_handler = cdrom_sysctl_handler > > > - }, > > > - { } > > > + } > > > > You should have the final entry as "}," so as to make any future > > additions to the list to only contain that entry, that's long been the > > kernel style for lists like this. > Will send a V2 with this included. Thx. > > > > > So your patches will just remove one line, not 2 and add 1, making it a > > smaller diff. > indeed. > > > > > thanks, > > > > greg k-h > > -- > > Joel Granados Hi Joel, Thank you for your patch. I look forward to seeing V2, and will be happy to review it. Regards, Phil From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02C4E8833 for ; Sat, 30 Sep 2023 16:52:24 +0000 (UTC) Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD540AB for ; Sat, 30 Sep 2023 09:52:22 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-40566f89f6eso124879525e9.3 for ; Sat, 30 Sep 2023 09:52:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20230601.gappssmtp.com; s=20230601; t=1696092741; x=1696697541; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TP49E0lt1lRfwVwEUZNQYaCBfTY4UGz9ptrNHBZhxcM=; b=GODHPJ5OBk5OFYXKYp/AsgCbEs96zHybKMqld2zYIYMA8bWsDO9CD32R4Ve892efWh Rw8h6Qoitfo9fDFRXeGZ1URS0UWu9IJBVx4Vya++BEVhXwx8iJTXEUg7vtyzXuhFlYS7 EaYP12e+2yYMGMjH/WAmkF/9TwNHyl/rOxe/+Raw1hFTZ4W/QiD6r+cTfVQujrg4ADiB t0EwhcgT/w1sqCgn4S5QesL/mVLbCPhL0Gs4zfmBWFR0O2+lvC4PwMCbZsvAUBYBpImL 7PoPTdEUlEjZSUqF5Cz+l5zBQwpp7snU3QkdNZzBDQG/BZuIT+Nwotv31hy32RoOfd+U mAYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696092741; x=1696697541; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TP49E0lt1lRfwVwEUZNQYaCBfTY4UGz9ptrNHBZhxcM=; b=tASWYp8xs7SjCZpZRcnTWWr5LlliN59lWo5x0ahuFnH0phwAp1xX5YPFFapK2K0Gms /4GIhXmPs5wVSj4yAzwbE+lzRZiYh9mACM0HNVV2trQvigRCabtR4PNxGIEEbQzw/bBv 3FgoYDtqF08ohfYwJWokpLR9Q92wT79X53o51MCu1cOG9H55RQ9FHpHrrb8PeMUQbO4n KK13TwGQmtkJEF7OJLudGxEVFEt3BMMqFB1w6/H26zGjYHNU+L+wb9QyvG1VTYEFCFBq B+RCLcd4+9pzMIQBFVWG+abUZtRKL8apPRn6A7Ouz1/M4XY2Xl+ZV7Qvfi4F+ryKu3Ef d0HA== X-Gm-Message-State: AOJu0YzamU5IVKhQ/d1mpBU8zWjNMRNGeR+0iWOdgmPHi+7ZhV+iIO98 3GWGIe8Sn6dCDvm3L8YgpYh4BA== X-Google-Smtp-Source: AGHT+IFufhUosQmDbdYYO0lgqH5WgmabRsKPy1NuiT6FdEpd1klh9Lx806UT3kRvn4yTyQ0Y4WLs9Q== X-Received: by 2002:adf:cf0a:0:b0:323:1689:6607 with SMTP id o10-20020adfcf0a000000b0032316896607mr6789063wrj.5.1696092741022; Sat, 30 Sep 2023 09:52:21 -0700 (PDT) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id u1-20020adfed41000000b003247d3e5d99sm4921066wro.55.2023.09.30.09.52.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Sep 2023 09:52:20 -0700 (PDT) Date: Sat, 30 Sep 2023 17:52:17 +0100 From: Phillip Potter To: Joel Granados Cc: Luis Chamberlain , willy@infradead.org, josh@joshtriplett.org, Kees Cook , Clemens Ladisch , Arnd Bergmann , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jiri Slaby , "James E.J. Bottomley" , "Martin K. Petersen" , Doug Gilbert , Sudip Mukherjee , Jason Gunthorpe , Leon Romanovsky , Corey Minyard , Theodore Ts'o , "Jason A. Donenfeld" , David Ahern , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Robin Holt , Steve Wahl , Russ Weight , "Rafael J. Wysocki" , Song Liu , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-serial@vger.kernel.org, linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-rdma@vger.kernel.org, openipmi-developer@lists.sourceforge.net, netdev@vger.kernel.org, linux-raid@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Greg Kroah-Hartman Subject: Re: [PATCH 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array Message-ID: References: <20230928-jag-sysctl_remove_empty_elem_drivers-v1-0-e59120fca9f9@samsung.com> <20230928-jag-sysctl_remove_empty_elem_drivers-v1-1-e59120fca9f9@samsung.com> <2023092855-cultivate-earthy-4d25@gregkh> <20230929121730.bwzhrpaptf45smfy@localhost> Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230929121730.bwzhrpaptf45smfy@localhost> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Fri, Sep 29, 2023 at 02:17:30PM +0200, Joel Granados wrote: > On Thu, Sep 28, 2023 at 03:36:55PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Sep 28, 2023 at 03:21:26PM +0200, Joel Granados via B4 Relay wrote: > > > From: Joel Granados > > > > > > This commit comes at the tail end of a greater effort to remove the > > > empty elements at the end of the ctl_table arrays (sentinels) which > > > will reduce the overall build time size of the kernel and run time > > > memory bloat by ~64 bytes per sentinel (further information Link : > > > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/) > > > > > > Remove sentinel element from cdrom_table > > > > > > Signed-off-by: Joel Granados > > > --- > > > drivers/cdrom/cdrom.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c > > > index cc2839805983..451907ade389 100644 > > > --- a/drivers/cdrom/cdrom.c > > > +++ b/drivers/cdrom/cdrom.c > > > @@ -3654,8 +3654,7 @@ static struct ctl_table cdrom_table[] = { > > > .maxlen = sizeof(int), > > > .mode = 0644, > > > .proc_handler = cdrom_sysctl_handler > > > - }, > > > - { } > > > + } > > > > You should have the final entry as "}," so as to make any future > > additions to the list to only contain that entry, that's long been the > > kernel style for lists like this. > Will send a V2 with this included. Thx. > > > > > So your patches will just remove one line, not 2 and add 1, making it a > > smaller diff. > indeed. > > > > > thanks, > > > > greg k-h > > -- > > Joel Granados Hi Joel, Thank you for your patch. I look forward to seeing V2, and will be happy to review it. Regards, Phil From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADB17E7737A for ; Sat, 30 Sep 2023 16:53:43 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=philpotter-co-uk.20230601.gappssmtp.com header.i=@philpotter-co-uk.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=vfLBjLSN; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RyYFd6zjNz3cRv for ; Sun, 1 Oct 2023 03:53:41 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=philpotter-co-uk.20230601.gappssmtp.com header.i=@philpotter-co-uk.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=vfLBjLSN; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=philpotter.co.uk (client-ip=2a00:1450:4864:20::32e; helo=mail-wm1-x32e.google.com; envelope-from=phil@philpotter.co.uk; receiver=lists.ozlabs.org) Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RyYDC298zz3by6 for ; Sun, 1 Oct 2023 03:52:25 +1100 (AEDT) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4064867903cso49934635e9.2 for ; Sat, 30 Sep 2023 09:52:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20230601.gappssmtp.com; s=20230601; t=1696092741; x=1696697541; darn=lists.ozlabs.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TP49E0lt1lRfwVwEUZNQYaCBfTY4UGz9ptrNHBZhxcM=; b=vfLBjLSNricJIffB2YF5INrWLZUaZIoMVdE7C/agmicT0EmXvNEI35mUAYNIZId9Vs cC4JV+w+XSUtSHuXx76g5BSaS/VXu+1+xZ8gby4XToBF2OCe4nr65uN9WzF3jHaVggEQ a/8rtrXpXWGoEkSyI/A16V/z+Gm1gK/ds2wtZCV1o6KI4YXHKSjx1jeM56/2Xmfg/Bge +yKTPbmuAiCx/PG0X1D5C0KbI5L4Rkz0RRjjYaj021HJyZqEGxfrDptGjkezgnQLzaSx V32ESW12jtPGnBHQH0GSSCuW0bBbvFud3cJb/miXZlwloSzafeTyzf3SoWaeidTbZr8n +wLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696092741; x=1696697541; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TP49E0lt1lRfwVwEUZNQYaCBfTY4UGz9ptrNHBZhxcM=; b=CpNMjwW0Jgg/VQGbYdbhDpPCE8MsJotRuIZolZd/39yZDpGO/Uq6zhX94u1zb42zXG oE515fst0MMTNdqaGyj0Sh5mt95iO0acc0sDOpLy2bDmZlrn+MgC25eOxqpYwzaveDz8 nqyJKkbbyAIwsCoGxA8+1hBNvTKYuT7otRDvpmGEFrEHEGqT6SNs3RqBhe1FHB75ZVuv XT1kWi5oCpSYS+4QLXHgMEYM0Nf3mqbcd2Rqjqi++J5q0JhAczDUf/0L5Xw5aNGanIW0 SD9gSn03ekK+78q7CBX743zUJ0kBr6cgUxDLOSrW8irRgqNRg9OLs6gEO686uq9ftlzV q95Q== X-Gm-Message-State: AOJu0YwZ0ZYmy3pWqpy59kJPlY5vFNT8EqmlH59eW1wCpERW8f/ssPzu U+QKooshcoowBXLfeNx6oPs16A== X-Google-Smtp-Source: AGHT+IFufhUosQmDbdYYO0lgqH5WgmabRsKPy1NuiT6FdEpd1klh9Lx806UT3kRvn4yTyQ0Y4WLs9Q== X-Received: by 2002:adf:cf0a:0:b0:323:1689:6607 with SMTP id o10-20020adfcf0a000000b0032316896607mr6789063wrj.5.1696092741022; Sat, 30 Sep 2023 09:52:21 -0700 (PDT) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id u1-20020adfed41000000b003247d3e5d99sm4921066wro.55.2023.09.30.09.52.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Sep 2023 09:52:20 -0700 (PDT) Date: Sat, 30 Sep 2023 17:52:17 +0100 From: Phillip Potter To: Joel Granados Subject: Re: [PATCH 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array Message-ID: References: <20230928-jag-sysctl_remove_empty_elem_drivers-v1-0-e59120fca9f9@samsung.com> <20230928-jag-sysctl_remove_empty_elem_drivers-v1-1-e59120fca9f9@samsung.com> <2023092855-cultivate-earthy-4d25@gregkh> <20230929121730.bwzhrpaptf45smfy@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230929121730.bwzhrpaptf45smfy@localhost> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Jason A. Donenfeld" , Steve Wahl , Joonas Lahtinen , Clemens Ladisch , linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Song Liu , Eric Dumazet , "K. Y. Srinivasan" , Jiri Slaby , Russ Weight , Wei Liu , Stefano Stabellini , Corey Minyard , Leon Romanovsky , linux-rdma@vger.kernel.org, David Airlie , "Rafael J. Wysocki" , Dexuan Cui , willy@infradead.org, Jason Gunthorpe , linux-serial@vger.kernel.org, Doug Gilbert , Jakub Kicinski , Paolo Abeni , Haiyang Zhang , Kees Cook , Arnd Bergmann < arnd@arndb.de>, "James E.J. Bottomley" , intel-gfx@lists.freedesktop.org, josh@joshtriplett.org, Jani Nikula , linux-raid@vger.kernel.org, Rodrigo Vivi , xen-devel@lists.xenproject.org, openipmi-developer@lists.sourceforge.net, Juergen Gross , Tvrtko Ursulin , Theodore Ts'o , linux-scsi@vger.kernel.org, "Martin K. Petersen" , netdev@vger.kernel.org, David Ahern , Robin Holt , Sudip Mukherjee , Oleksandr Tyshchenko , Luis Chamberlain , Daniel Vetter , Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Sep 29, 2023 at 02:17:30PM +0200, Joel Granados wrote: > On Thu, Sep 28, 2023 at 03:36:55PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Sep 28, 2023 at 03:21:26PM +0200, Joel Granados via B4 Relay wrote: > > > From: Joel Granados > > > > > > This commit comes at the tail end of a greater effort to remove the > > > empty elements at the end of the ctl_table arrays (sentinels) which > > > will reduce the overall build time size of the kernel and run time > > > memory bloat by ~64 bytes per sentinel (further information Link : > > > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/) > > > > > > Remove sentinel element from cdrom_table > > > > > > Signed-off-by: Joel Granados > > > --- > > > drivers/cdrom/cdrom.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c > > > index cc2839805983..451907ade389 100644 > > > --- a/drivers/cdrom/cdrom.c > > > +++ b/drivers/cdrom/cdrom.c > > > @@ -3654,8 +3654,7 @@ static struct ctl_table cdrom_table[] = { > > > .maxlen = sizeof(int), > > > .mode = 0644, > > > .proc_handler = cdrom_sysctl_handler > > > - }, > > > - { } > > > + } > > > > You should have the final entry as "}," so as to make any future > > additions to the list to only contain that entry, that's long been the > > kernel style for lists like this. > Will send a V2 with this included. Thx. > > > > > So your patches will just remove one line, not 2 and add 1, making it a > > smaller diff. > indeed. > > > > > thanks, > > > > greg k-h > > -- > > Joel Granados Hi Joel, Thank you for your patch. I look forward to seeing V2, and will be happy to review it. Regards, Phil From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66FCAE7735F for ; Sat, 30 Sep 2023 16:52:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8C94510E047; Sat, 30 Sep 2023 16:52:24 +0000 (UTC) Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by gabe.freedesktop.org (Postfix) with ESMTPS id 12C1410E047 for ; Sat, 30 Sep 2023 16:52:22 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-3231df68584so10961688f8f.1 for ; Sat, 30 Sep 2023 09:52:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20230601.gappssmtp.com; s=20230601; t=1696092741; x=1696697541; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TP49E0lt1lRfwVwEUZNQYaCBfTY4UGz9ptrNHBZhxcM=; b=O2nqIdXg3TdpRzKs5kRGC/9SFOJx06XZXwFUUBMUsj3IIqyTw9Gx1lNrL+L52HDXZr ay50+9YqTAIJs2iR1GI0I1TtI+WhrV30g2n+Dhi8isY1VzTh3dmqHBYEN0KO309S48hI QmmwtmjKkiHqhkp+w9owJ5OY3Zivlu3WuV48k7/bWhNcMLHI7jppawD+k2RqQ80EO/gs ozsBsfMv04H4gUbO+Qy1P9CPejHmN7g2R4QTnalrhLif56LJMELsku52Fc9ryqNP6lgR ODrFIy2Rxqpt6pP69SPckaxyqx/dKTNwD3918B3erffvd1rAHKJCr+LOLRdyxNFS6J02 VMuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696092741; x=1696697541; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TP49E0lt1lRfwVwEUZNQYaCBfTY4UGz9ptrNHBZhxcM=; b=Sr/Jzd+aWNbJpLzx3rmU68TGBqToVDdtjTZGk1ff/eRSJvlBvB7zi/5OkQiP+YbGyU XwSKPEljPd3Uc4sePCu4wJpe7rkCsSaBiwh6Ca4hQraRmz4KThifsoio3vhOqk+MwRlT na78b4MBrntxtEGR3VX/eou6W+ToTb3rzR4uzV48IyhE/LSR3f5CxLgw5bqdIg3dXJ3e Kw2k8Sx710N3PKUMQwxqNRUTvFW6m4L0DKXqfbRjiYMLvQLAwBmvOMmCd1qWdOZ4SWs2 tC9i13NHwt9FMw/kwCh82zgv+UrKVQkYwbW20IE7mcL9NHvW7lbrIBtQNn82AMNdR7ku cP4A== X-Gm-Message-State: AOJu0Yww6o6Y5oz7wJ9cluS6HqHjzL4qXf1uTERs4lLdy5Tg2TmetcXp WteEmBBz8Ngjn942Clbse97BEw== X-Google-Smtp-Source: AGHT+IFufhUosQmDbdYYO0lgqH5WgmabRsKPy1NuiT6FdEpd1klh9Lx806UT3kRvn4yTyQ0Y4WLs9Q== X-Received: by 2002:adf:cf0a:0:b0:323:1689:6607 with SMTP id o10-20020adfcf0a000000b0032316896607mr6789063wrj.5.1696092741022; Sat, 30 Sep 2023 09:52:21 -0700 (PDT) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id u1-20020adfed41000000b003247d3e5d99sm4921066wro.55.2023.09.30.09.52.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Sep 2023 09:52:20 -0700 (PDT) Date: Sat, 30 Sep 2023 17:52:17 +0100 From: Phillip Potter To: Joel Granados Subject: Re: [PATCH 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array Message-ID: References: <20230928-jag-sysctl_remove_empty_elem_drivers-v1-0-e59120fca9f9@samsung.com> <20230928-jag-sysctl_remove_empty_elem_drivers-v1-1-e59120fca9f9@samsung.com> <2023092855-cultivate-earthy-4d25@gregkh> <20230929121730.bwzhrpaptf45smfy@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230929121730.bwzhrpaptf45smfy@localhost> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Jason A. Donenfeld" , Steve Wahl , Clemens Ladisch , linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Song Liu , Eric Dumazet , "K. Y. Srinivasan" , Jiri Slaby , Russ Weight , Wei Liu , Stefano Stabellini , Corey Minyard , Leon Romanovsky , linux-rdma@vger.kernel.org, "Rafael J. Wysocki" , Dexuan Cui , willy@infradead.org, Jason Gunthorpe , linux-serial@vger.kernel.org, Doug Gilbert , Jakub Kicinski , Paolo Abeni , Haiyang Zhang , Kees Cook , Arnd Bergmann , "James E.J. Bottomley" , intel-gfx@lists.freedesktop.org, josh@joshtriplett.org, linux-raid@vger.kernel.org, Rodrigo Vivi , xen-devel@lists.xenproject.org, openipmi-developer@lists.sourceforge.net, Juergen Gross , Tvrtko Ursulin , Theodore Ts'o , linux-scsi@vger.kernel.org, "Martin K. Petersen" , netdev@vger.kernel.org, David Ahern , Robin Holt , Sudip Mukherjee , Oleksandr Tyshchenko , Luis Chamberlain , Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Sep 29, 2023 at 02:17:30PM +0200, Joel Granados wrote: > On Thu, Sep 28, 2023 at 03:36:55PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Sep 28, 2023 at 03:21:26PM +0200, Joel Granados via B4 Relay wrote: > > > From: Joel Granados > > > > > > This commit comes at the tail end of a greater effort to remove the > > > empty elements at the end of the ctl_table arrays (sentinels) which > > > will reduce the overall build time size of the kernel and run time > > > memory bloat by ~64 bytes per sentinel (further information Link : > > > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/) > > > > > > Remove sentinel element from cdrom_table > > > > > > Signed-off-by: Joel Granados > > > --- > > > drivers/cdrom/cdrom.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c > > > index cc2839805983..451907ade389 100644 > > > --- a/drivers/cdrom/cdrom.c > > > +++ b/drivers/cdrom/cdrom.c > > > @@ -3654,8 +3654,7 @@ static struct ctl_table cdrom_table[] = { > > > .maxlen = sizeof(int), > > > .mode = 0644, > > > .proc_handler = cdrom_sysctl_handler > > > - }, > > > - { } > > > + } > > > > You should have the final entry as "}," so as to make any future > > additions to the list to only contain that entry, that's long been the > > kernel style for lists like this. > Will send a V2 with this included. Thx. > > > > > So your patches will just remove one line, not 2 and add 1, making it a > > smaller diff. > indeed. > > > > > thanks, > > > > greg k-h > > -- > > Joel Granados Hi Joel, Thank you for your patch. I look forward to seeing V2, and will be happy to review it. Regards, Phil