From: Tzung-Bi Shih <tzungbi@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
linux-pwm@vger.kernel.org, chrome-platform@lists.linux.dev,
kernel@pengutronix.de
Subject: Re: [PATCH 11/11] pwm: cros-ec: Simplify using devm_pwmchip_add() and dev_err_probe()
Date: Mon, 2 Oct 2023 06:01:08 +0000 [thread overview]
Message-ID: <ZRpcpPhCX95ks2rc@google.com> (raw)
In-Reply-To: <20230929161918.2410424-12-u.kleine-koenig@pengutronix.de>
On Fri, Sep 29, 2023 at 06:19:18PM +0200, Uwe Kleine-König wrote:
> Using devm_pwmchip_add() allows to drop pwmchip_remove() from the remove
> function which makes this function empty. Then there is no user of
> drvdata left and platform_set_drvdata() can be dropped, too.
>
> Further simplify and improve error returning using dev_err_probe().
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
next prev parent reply other threads:[~2023-10-02 6:01 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 16:19 [PATCH 00/11] pwm: Some random cleanups Uwe Kleine-König
2023-09-29 16:19 ` Uwe Kleine-König
2023-09-29 16:19 ` [PATCH 01/11] pwm: bcm-iproc: Simplify using devm functions Uwe Kleine-König
2023-09-29 16:19 ` Uwe Kleine-König
2023-11-13 4:11 ` Florian Fainelli
2023-11-13 4:11 ` Florian Fainelli
2023-11-13 8:35 ` Uwe Kleine-König
2023-11-13 8:35 ` Uwe Kleine-König
2023-09-29 16:19 ` [PATCH 02/11] pwm: bcm2835: " Uwe Kleine-König
2023-09-29 16:19 ` Uwe Kleine-König
2023-11-13 4:21 ` Florian Fainelli
2023-11-13 4:21 ` Florian Fainelli
2023-09-29 16:19 ` [PATCH 03/11] pwm: brcmstb: " Uwe Kleine-König
2023-09-29 16:19 ` Uwe Kleine-König
2023-11-13 4:22 ` Florian Fainelli
2023-11-13 4:22 ` Florian Fainelli
2023-09-29 16:19 ` [PATCH 04/11] pwm: imx-tpm: " Uwe Kleine-König
2023-09-29 16:19 ` Uwe Kleine-König
2023-09-29 16:19 ` [PATCH 05/11] pwm: mtk-disp: Simplify using devm_pwmchip_add() Uwe Kleine-König
2023-09-29 16:19 ` Uwe Kleine-König
2023-10-02 10:44 ` AngeloGioacchino Del Regno
2023-10-02 10:44 ` AngeloGioacchino Del Regno
2023-09-29 16:19 ` [PATCH 06/11] pwm: spear: Simplify using devm functions Uwe Kleine-König
2023-09-29 16:19 ` [PATCH 07/11] pwm: sprd: Provide a helper to cast a chip to driver data Uwe Kleine-König
2023-09-29 16:19 ` [PATCH 08/11] pwm: sprd: Simplify using devm_pwmchip_add() and dev_err_probe() Uwe Kleine-König
2023-09-29 16:19 ` [PATCH 09/11] pwm: vt8500: Simplify using devm functions Uwe Kleine-König
2023-09-29 16:19 ` Uwe Kleine-König
2023-09-29 16:19 ` [PATCH 10/11] pwm: samsung: Consistently use the same name for driver data Uwe Kleine-König
2023-09-29 16:19 ` Uwe Kleine-König
2023-09-29 16:19 ` [PATCH 11/11] pwm: cros-ec: Simplify using devm_pwmchip_add() and dev_err_probe() Uwe Kleine-König
2023-10-02 6:01 ` Tzung-Bi Shih [this message]
2023-11-13 3:23 ` [PATCH 00/11] pwm: Some random cleanups patchwork-bot+chrome-platform
2023-11-13 3:23 ` patchwork-bot+chrome-platform
2023-11-13 3:42 ` patchwork-bot+chrome-platform
2023-11-13 3:42 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRpcpPhCX95ks2rc@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=kernel@pengutronix.de \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.