From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7418CE784A4 for ; Mon, 2 Oct 2023 06:47:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A8E8510E12A; Mon, 2 Oct 2023 06:47:48 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 59E0810E12A; Mon, 2 Oct 2023 06:47:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696229266; x=1727765266; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=f3POr1hTgs9BZkoiQNmow/8HaNbGbSX6TCGj1mzjNcc=; b=QmdYnraiWYnZuqR87E5Ub+IEQa9ojciahPZ/Fw1CyD22s0hYnWZ+zxqM SD1K6HnsIO40NdLT5DOWEq1n2n5YSe0WGZY5WADzy+GU6JyU2mfMU6/IV FN50NQgR9fk1oYP9c5LBoGO8lnGfoI5fO7hKqIJQx8MB/Cui7hOR2T5/I u6agYyn0DYyZ7EtYVV+6wH+t2XPVgGtoQ+YeyUYy4fkXeLJ0sUMfiYHhc zhkvH3EgbDM3EqjihqCZIMDrSxubatKmyvqZfCiAOCdzjGol9FXDfZEK6 kbiSz15vRQp7ejKBnGPct2nd5MtzyZOSvBDncQJ+w1xSvx/iglQ+g/Bot g==; X-IronPort-AV: E=McAfee;i="6600,9927,10850"; a="449080373" X-IronPort-AV: E=Sophos;i="6.03,193,1694761200"; d="scan'208";a="449080373" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2023 23:47:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10850"; a="779854915" X-IronPort-AV: E=Sophos;i="6.03,193,1694761200"; d="scan'208";a="779854915" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.153]) by orsmga008.jf.intel.com with SMTP; 01 Oct 2023 23:47:42 -0700 Received: by stinkbox (sSMTP sendmail emulation); Mon, 02 Oct 2023 09:47:41 +0300 Date: Mon, 2 Oct 2023 09:47:41 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Randy Dunlap Message-ID: References: <20231002010824.14781-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231002010824.14781-1-rdunlap@infradead.org> X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH] drm/i915/uapi: fix doc typos X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , dri-devel@lists.freedesktop.org, Thomas Zimmermann , Rodrigo Vivi Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sun, Oct 01, 2023 at 06:08:24PM -0700, Randy Dunlap wrote: > Correct typo of "its". > Add a comma for clarity. > > Signed-off-by: Randy Dunlap > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Tvrtko Ursulin > Cc: intel-gfx@lists.freedesktop.org > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: dri-devel@lists.freedesktop.org > --- > include/uapi/drm/i915_drm.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff -- a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h > --- a/include/uapi/drm/i915_drm.h > +++ b/include/uapi/drm/i915_drm.h > @@ -38,13 +38,13 @@ extern "C" { > */ > > /** > - * DOC: uevents generated by i915 on it's device node > + * DOC: uevents generated by i915 on its device node > * > * I915_L3_PARITY_UEVENT - Generated when the driver receives a parity mismatch > - * event from the gpu l3 cache. Additional information supplied is ROW, > + * event from the GPU l3 cache. Additional information supplied is ROW, s/l3/L3/ would also be appropriate if aim to fix the caps. > * BANK, SUBBANK, SLICE of the affected cacheline. Userspace should keep > * track of these events and if a specific cache-line seems to have a ^ I'd put the comma there, but my grasp of English punctuation isn't all that great so I might be wrong. Or maybe both places should have one? > - * persistent error remap it with the l3 remapping tool supplied in > + * persistent error, remap it with the l3 remapping tool supplied in > * intel-gpu-tools. The value supplied with the event is always 1. > * > * I915_ERROR_UEVENT - Generated upon error detection, currently only via -- Ville Syrjälä Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99058E7849A for ; Mon, 2 Oct 2023 06:47:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4EBFD10E152; Mon, 2 Oct 2023 06:47:49 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 59E0810E12A; Mon, 2 Oct 2023 06:47:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696229266; x=1727765266; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=f3POr1hTgs9BZkoiQNmow/8HaNbGbSX6TCGj1mzjNcc=; b=QmdYnraiWYnZuqR87E5Ub+IEQa9ojciahPZ/Fw1CyD22s0hYnWZ+zxqM SD1K6HnsIO40NdLT5DOWEq1n2n5YSe0WGZY5WADzy+GU6JyU2mfMU6/IV FN50NQgR9fk1oYP9c5LBoGO8lnGfoI5fO7hKqIJQx8MB/Cui7hOR2T5/I u6agYyn0DYyZ7EtYVV+6wH+t2XPVgGtoQ+YeyUYy4fkXeLJ0sUMfiYHhc zhkvH3EgbDM3EqjihqCZIMDrSxubatKmyvqZfCiAOCdzjGol9FXDfZEK6 kbiSz15vRQp7ejKBnGPct2nd5MtzyZOSvBDncQJ+w1xSvx/iglQ+g/Bot g==; X-IronPort-AV: E=McAfee;i="6600,9927,10850"; a="449080373" X-IronPort-AV: E=Sophos;i="6.03,193,1694761200"; d="scan'208";a="449080373" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2023 23:47:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10850"; a="779854915" X-IronPort-AV: E=Sophos;i="6.03,193,1694761200"; d="scan'208";a="779854915" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.153]) by orsmga008.jf.intel.com with SMTP; 01 Oct 2023 23:47:42 -0700 Received: by stinkbox (sSMTP sendmail emulation); Mon, 02 Oct 2023 09:47:41 +0300 Date: Mon, 2 Oct 2023 09:47:41 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Randy Dunlap Subject: Re: [PATCH] drm/i915/uapi: fix doc typos Message-ID: References: <20231002010824.14781-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231002010824.14781-1-rdunlap@infradead.org> X-Patchwork-Hint: comment X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , dri-devel@lists.freedesktop.org, Thomas Zimmermann , Rodrigo Vivi Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Oct 01, 2023 at 06:08:24PM -0700, Randy Dunlap wrote: > Correct typo of "its". > Add a comma for clarity. > > Signed-off-by: Randy Dunlap > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Tvrtko Ursulin > Cc: intel-gfx@lists.freedesktop.org > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: dri-devel@lists.freedesktop.org > --- > include/uapi/drm/i915_drm.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff -- a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h > --- a/include/uapi/drm/i915_drm.h > +++ b/include/uapi/drm/i915_drm.h > @@ -38,13 +38,13 @@ extern "C" { > */ > > /** > - * DOC: uevents generated by i915 on it's device node > + * DOC: uevents generated by i915 on its device node > * > * I915_L3_PARITY_UEVENT - Generated when the driver receives a parity mismatch > - * event from the gpu l3 cache. Additional information supplied is ROW, > + * event from the GPU l3 cache. Additional information supplied is ROW, s/l3/L3/ would also be appropriate if aim to fix the caps. > * BANK, SUBBANK, SLICE of the affected cacheline. Userspace should keep > * track of these events and if a specific cache-line seems to have a ^ I'd put the comma there, but my grasp of English punctuation isn't all that great so I might be wrong. Or maybe both places should have one? > - * persistent error remap it with the l3 remapping tool supplied in > + * persistent error, remap it with the l3 remapping tool supplied in > * intel-gpu-tools. The value supplied with the event is always 1. > * > * I915_ERROR_UEVENT - Generated upon error detection, currently only via -- Ville Syrjälä Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 796DCE784A5 for ; Mon, 2 Oct 2023 06:47:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235563AbjJBGrv (ORCPT ); Mon, 2 Oct 2023 02:47:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235561AbjJBGrs (ORCPT ); Mon, 2 Oct 2023 02:47:48 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19D00E0 for ; Sun, 1 Oct 2023 23:47:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696229266; x=1727765266; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=f3POr1hTgs9BZkoiQNmow/8HaNbGbSX6TCGj1mzjNcc=; b=QmdYnraiWYnZuqR87E5Ub+IEQa9ojciahPZ/Fw1CyD22s0hYnWZ+zxqM SD1K6HnsIO40NdLT5DOWEq1n2n5YSe0WGZY5WADzy+GU6JyU2mfMU6/IV FN50NQgR9fk1oYP9c5LBoGO8lnGfoI5fO7hKqIJQx8MB/Cui7hOR2T5/I u6agYyn0DYyZ7EtYVV+6wH+t2XPVgGtoQ+YeyUYy4fkXeLJ0sUMfiYHhc zhkvH3EgbDM3EqjihqCZIMDrSxubatKmyvqZfCiAOCdzjGol9FXDfZEK6 kbiSz15vRQp7ejKBnGPct2nd5MtzyZOSvBDncQJ+w1xSvx/iglQ+g/Bot g==; X-IronPort-AV: E=McAfee;i="6600,9927,10850"; a="449080371" X-IronPort-AV: E=Sophos;i="6.03,193,1694761200"; d="scan'208";a="449080371" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2023 23:47:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10850"; a="779854915" X-IronPort-AV: E=Sophos;i="6.03,193,1694761200"; d="scan'208";a="779854915" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.153]) by orsmga008.jf.intel.com with SMTP; 01 Oct 2023 23:47:42 -0700 Received: by stinkbox (sSMTP sendmail emulation); Mon, 02 Oct 2023 09:47:41 +0300 Date: Mon, 2 Oct 2023 09:47:41 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Tvrtko Ursulin , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Maxime Ripard , Thomas Zimmermann , Rodrigo Vivi Subject: Re: [PATCH] drm/i915/uapi: fix doc typos Message-ID: References: <20231002010824.14781-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231002010824.14781-1-rdunlap@infradead.org> X-Patchwork-Hint: comment Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 01, 2023 at 06:08:24PM -0700, Randy Dunlap wrote: > Correct typo of "its". > Add a comma for clarity. > > Signed-off-by: Randy Dunlap > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Tvrtko Ursulin > Cc: intel-gfx@lists.freedesktop.org > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: dri-devel@lists.freedesktop.org > --- > include/uapi/drm/i915_drm.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff -- a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h > --- a/include/uapi/drm/i915_drm.h > +++ b/include/uapi/drm/i915_drm.h > @@ -38,13 +38,13 @@ extern "C" { > */ > > /** > - * DOC: uevents generated by i915 on it's device node > + * DOC: uevents generated by i915 on its device node > * > * I915_L3_PARITY_UEVENT - Generated when the driver receives a parity mismatch > - * event from the gpu l3 cache. Additional information supplied is ROW, > + * event from the GPU l3 cache. Additional information supplied is ROW, s/l3/L3/ would also be appropriate if aim to fix the caps. > * BANK, SUBBANK, SLICE of the affected cacheline. Userspace should keep > * track of these events and if a specific cache-line seems to have a ^ I'd put the comma there, but my grasp of English punctuation isn't all that great so I might be wrong. Or maybe both places should have one? > - * persistent error remap it with the l3 remapping tool supplied in > + * persistent error, remap it with the l3 remapping tool supplied in > * intel-gpu-tools. The value supplied with the event is always 1. > * > * I915_ERROR_UEVENT - Generated upon error detection, currently only via -- Ville Syrjälä Intel