From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Raag Jadav <raag.jadav@intel.com>
Cc: linus.walleij@linaro.org, mika.westerberg@linux.intel.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com
Subject: Re: [PATCH v1 1/2] pinctrl: baytrail: drop runtime PM support
Date: Tue, 3 Oct 2023 12:01:32 +0300 [thread overview]
Message-ID: <ZRvYbFF0h7OOo7Nu@smile.fi.intel.com> (raw)
In-Reply-To: <ZRvX9GUXbJksmSIP@smile.fi.intel.com>
On Tue, Oct 03, 2023 at 11:59:33AM +0300, Andy Shevchenko wrote:
> On Tue, Oct 03, 2023 at 01:45:18PM +0530, Raag Jadav wrote:
> > Since Baytrail pinctrl device is not attached to acpi_lpss_pm_domain,
> > runtime PM serves no purpose here. Drop it and switch to pm_sleep_ptr()
> > as now we only have suspend and resume handles in place.
> >
> > No functional impact.
>
> > TODO:
> > Consider moving to DEFINE_LATE_DEV_PM_OPS() in the future once we have
> > enough users to account for its introduction.
>
> This is not related to the commit message.
> I'll drop it.
Ah, and next time, please do a cover letter for the series, it can be
better managed from maintainer perspective.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-10-03 9:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 8:15 [PATCH v1 1/2] pinctrl: baytrail: drop runtime PM support Raag Jadav
2023-10-03 8:15 ` [PATCH v1 2/2] pinctrl: lynxpoint: " Raag Jadav
2023-10-03 8:59 ` Andy Shevchenko
2023-10-03 9:08 ` Raag Jadav
2023-10-03 8:59 ` [PATCH v1 1/2] pinctrl: baytrail: " Andy Shevchenko
2023-10-03 9:01 ` Andy Shevchenko [this message]
2023-10-03 9:05 ` Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRvYbFF0h7OOo7Nu@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bala.senthil@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=raag.jadav@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.