From: Jiri Pirko <jiri@resnulli.us>
To: David Ahern <dsahern@gmail.com>
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
daniel.machon@microchip.com
Subject: Re: [patch iproute2-next v2 3/5] devlink: introduce support for netns id for nested handle
Date: Tue, 3 Oct 2023 19:17:33 +0200 [thread overview]
Message-ID: <ZRxMrelhKF9QHGrj@nanopsycho> (raw)
In-Reply-To: <ca25c554-4fd9-5db2-655d-a30ffca11d8d@gmail.com>
Tue, Oct 03, 2023 at 06:37:31PM CEST, dsahern@gmail.com wrote:
>On 9/29/23 5:30 AM, Jiri Pirko wrote:
>>>> The attribute is a namespace id, and the value is a namespace id. Given
>>>> that, the name here should be netnsid (or nsid - we did a horrible job
>>>> with consistency across iproute2 commands). I have not followed the
>>>> kernel patches to understand what you mean by nested devlink instance.
>>>
>>> Please do that. Again, the netnsid is related to the nested instance.
>>> Therefore I put the "nested_devlink" in the name. Putting just "netnsid"
>>> as you suggest is wrong. Another possibility would be do nest this into
>>> object, but:
>>> 1) I didn't find nice way to do that
>>> 2) We would break linecards as they expose nested_devlink already
>
>well, that just shows I make mistakes as a reviewer. These really long
>command lines are really taxing.
So what do you suggest?
next prev parent reply other threads:[~2023-10-03 17:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 11:56 [patch iproute2-next v2 0/5] expose devlink instances relationships Jiri Pirko
2023-09-19 11:56 ` [patch iproute2-next v2 1/5] devlink: update headers Jiri Pirko
2023-09-19 11:56 ` [patch iproute2-next v2 2/5] ip/ipnetns: move internals of get_netnsid_from_name() into namespace.c Jiri Pirko
2023-09-19 14:03 ` David Ahern
2023-09-19 17:19 ` Jiri Pirko
2023-09-19 11:56 ` [patch iproute2-next v2 3/5] devlink: introduce support for netns id for nested handle Jiri Pirko
2023-09-19 14:03 ` David Ahern
2023-09-19 17:19 ` Jiri Pirko
2023-09-19 18:48 ` David Ahern
2023-09-20 7:30 ` Jiri Pirko
2023-09-29 11:30 ` Jiri Pirko
2023-10-03 16:37 ` David Ahern
2023-10-03 17:17 ` Jiri Pirko [this message]
2023-10-04 15:20 ` David Ahern
2023-10-05 7:22 ` Jiri Pirko
2023-09-19 11:56 ` [patch iproute2-next v2 4/5] devlink: print nested handle for port function Jiri Pirko
2023-09-19 11:56 ` [patch iproute2-next v2 5/5] devlink: print nested devlink handle for devlink dev Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRxMrelhKF9QHGrj@nanopsycho \
--to=jiri@resnulli.us \
--cc=daniel.machon@microchip.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.