From: Jisheng Zhang <jszhang@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Anand Moon <linux.amoon@gmail.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: usb: vialab,vl817: remove reset-gpios from required list
Date: Wed, 18 Oct 2023 23:00:22 +0800 [thread overview]
Message-ID: <ZS/zBvaWicGAeaGq@xhacker> (raw)
In-Reply-To: <04ee08a4-e804-40fe-b24e-7a56c9e24e8b@linaro.org>
On Tue, Oct 17, 2023 at 06:53:56PM +0200, Krzysztof Kozlowski wrote:
> On 17/10/2023 18:01, Jisheng Zhang wrote:
> > The "reset-gpios" is optional in real case, for example reset pin is
> > is hard wired to "high". And this fact is also reflected by the
> > devm_gpio_get_optional() calling in driver code.
> >
> > Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> > ---
> > .../bindings/usb/thead,th1520-usb.yaml | 42 ++++++++++---------
> > .../devicetree/bindings/usb/vialab,vl817.yaml | 1 -
> > 2 files changed, 23 insertions(+), 20 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml b/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml
> > index afb618eb5013..ce1cab75f0ff 100644
> > --- a/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml
> > +++ b/Documentation/devicetree/bindings/usb/thead,th1520-usb.yaml
> > @@ -28,6 +28,10 @@ properties:
> >
> > ranges: true
> >
> > + thead,misc-syscon:
> > + $ref: /schemas/types.yaml#/definitions/phandle-array
> > + description: a phandle to the misc system register controller syscon node.
>
> Either you combined two unrelated changes or this should be resets from
> reset-controller.
oops, this change isn't expected... I was working on TH1520 usb but
add local changes step by step, but then found vl817 need to be patched.
I forgot to reset TH1520 usb part. Sorry for noise. V2 will be sent out
soon.
prev parent reply other threads:[~2023-10-18 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 16:01 [PATCH] dt-bindings: usb: vialab,vl817: remove reset-gpios from required list Jisheng Zhang
2023-10-17 16:53 ` Krzysztof Kozlowski
2023-10-18 15:00 ` Jisheng Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZS/zBvaWicGAeaGq@xhacker \
--to=jszhang@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.