From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4184CDB47E for ; Wed, 18 Oct 2023 08:52:44 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.618448.962098 (Exim 4.92) (envelope-from ) id 1qt2Hu-0005nv-8C; Wed, 18 Oct 2023 08:52:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 618448.962098; Wed, 18 Oct 2023 08:52:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qt2Hu-0005no-4T; Wed, 18 Oct 2023 08:52:22 +0000 Received: by outflank-mailman (input) for mailman id 618448; Wed, 18 Oct 2023 08:52:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qt2Ht-0005ni-4f for xen-devel@lists.xenproject.org; Wed, 18 Oct 2023 08:52:21 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a4e202a6-6d93-11ee-98d4-6d05b1d4d9a1; Wed, 18 Oct 2023 10:52:19 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-582-7wigXbIkP_i32babYPld5g-1; Wed, 18 Oct 2023 04:52:14 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2347D28AC1EA; Wed, 18 Oct 2023 08:52:14 +0000 (UTC) Received: from redhat.com (unknown [10.39.193.245]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CB252C15BB8; Wed, 18 Oct 2023 08:52:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4e202a6-6d93-11ee-98d4-6d05b1d4d9a1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697619138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2QqvfO0DgHUb1b4lvzB4Y2b9lzIz4ZUlzP/607LhnMw=; b=DN2KxSckrdpoKi0O0W1kFaXINM6B8/o6o4VS3JCT1ISbvo6kuQ9aFR5Uwpqd5+IZdxNZ9s UcuVpt3Z8a86BpF0rl0OAHlIC76ssZbpBLLOwVwtGF+rTHramIyxRTw7LDrjvV+qZDkLPG A2fHLYSto5KgWaZSPV5UE1HS6sFctWc= X-MC-Unique: 7wigXbIkP_i32babYPld5g-1 Date: Wed, 18 Oct 2023 10:52:10 +0200 From: Kevin Wolf To: David Woodhouse Cc: qemu-devel@nongnu.org, Hanna Reitz , Stefano Stabellini , Anthony Perard , Paul Durrant , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Paolo Bonzini , "Michael S. Tsirkin" , Marcel Apfelbaum , Richard Henderson , Eduardo Habkost , Marcelo Tosatti , qemu-block@nongnu.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org Subject: Re: [PATCH 11/12] hw/xen: automatically assign device index to block devices Message-ID: References: <20231016151909.22133-1-dwmw2@infradead.org> <20231016151909.22133-12-dwmw2@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231016151909.22133-12-dwmw2@infradead.org> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 Am 16.10.2023 um 17:19 hat David Woodhouse geschrieben: > From: David Woodhouse > > There's no need to force the user to assign a vdev. We can automatically > assign one, starting at xvda and searching until we find the first disk > name that's unused. > > This means we can now allow '-drive if=xen,file=xxx' to work without an > explicit separate -driver argument, just like if=virtio. > > Signed-off-by: David Woodhouse Actually, how does this play together with xen_config_dev_blk()? This looks like it tried to implement a very similar thing (which is IF_XEN even already existed). Are we now trying to attach each if=xen disk twice in the 'xenpv' machine? Or if something prevents this, is it dead code? I think in both cases, we would want to delete that function and remove the loop that calls it in xen_init_pv()? Kevin