From: Florian Westphal <fw@strlen.de>
To: Thomas Haller <thaller@redhat.com>
Cc: NetFilter <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nft 1/3] tests/shell: skip "table_onoff" test if kernel patch is missing
Date: Mon, 16 Oct 2023 22:20:57 +0200 [thread overview]
Message-ID: <ZS2bKZVAN5d5dax-@strlen.de> (raw)
In-Reply-To: <20231016131209.1127298-1-thaller@redhat.com>
Thomas Haller <thaller@redhat.com> wrote:
> Passing the test suite must not require latest kernel patches. If test
> "table_onoff" appears to not work due to a missing kernel patch, skip
> it.
>
> If you run a special kernel and expect that all test pass, set
> NFT_TEST_FAIL_ON_SKIP=y to catch unexpected skips.
This makes the test suite and all feature probing moot for my use cases.
If I see SKIP, I assume that the feature is missing.
This is a bug, and it tells me that I might have to do something
about it.
If you absolutely cannot have a failure because of this, then
please add another error state for this, so that I can see that
something is wrong.
This is NOT the same as a skip because some distro kernel lacks
anonymous chain support.
That said, I would STRONLGY perfer failure here.
Distros will ship updates that eventually also include this bug fix.
This fix is included in 6.5.6 for example.
next prev parent reply other threads:[~2023-10-16 20:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 13:12 [PATCH nft 1/3] tests/shell: skip "table_onoff" test if kernel patch is missing Thomas Haller
2023-10-16 13:12 ` [PATCH nft 2/3] tests/shell: skip "vlan_8021ad_tag" test instead of failing Thomas Haller
2023-10-16 13:12 ` [PATCH nft 3/3] tests/shell: add missing "vlan_8021ad_tag.nodump" file Thomas Haller
2023-10-16 20:20 ` Florian Westphal [this message]
2023-10-17 6:22 ` [PATCH nft 1/3] tests/shell: skip "table_onoff" test if kernel patch is missing Thomas Haller
2023-10-17 8:53 ` Thomas Haller
2023-10-17 9:32 ` Florian Westphal
2023-10-17 11:14 ` Thomas Haller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZS2bKZVAN5d5dax-@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.