From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v3 21/32] efi: Rearrange the Kconfig for CMD_BOOTEFI_BOOTMGR
Date: Tue, 17 Oct 2023 09:50:35 +0900 [thread overview]
Message-ID: <ZS3aW5IkWrdOR5zL@octopus> (raw)
In-Reply-To: <20231016222835.596572-22-sjg@chromium.org>
Hi Simon,
Thank you for taking my idea here.
On Mon, Oct 16, 2023 at 04:28:12PM -0600, Simon Glass wrote:
> The command should not be used to enable library functionality. Add a
> new BOOTEFI_BOOTMGR Kconfig for that. Adjust the conditions so that the
> same code is built.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Suggested-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
>
> Changes in v3:
> - Add new patch to rearrange the Kconfig for CMD_BOOTEFI_BOOTMGR
>
> cmd/Kconfig | 9 +++++++++
> lib/efi_loader/Kconfig | 7 +++----
> lib/efi_loader/Makefile | 2 +-
> 3 files changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 46e484fc08b6..3b4112d9f319 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -306,6 +306,15 @@ config CMD_BOOTI
> help
> Boot an AArch64 Linux Kernel image from memory.
>
> +config CMD_BOOTEFI_BOOTMGR
> + bool "UEFI Boot Manager command"
> + depends on BOOTEFI_BOOTMGR && CMD_BOOTEFI
> + default y
> + help
> + Select this option if you want to select the UEFI binary to be booted
> + via UEFI variables Boot####, BootOrder, and BootNext. This enables the
> + 'bootefi bootmgr' command.
> +
> config BOOTM_LINUX
Do you have any intention to put this configuration here?
Otherwise, it should be placed just after CMD_BOOTEFI.
In addition, CMD_EFICONFIG should have a dependency on BOOTEFI_BOOTMGR
rather than CMD_BOOTEFI_BOOTMGR as it is a separate command.
Thanks,
-Takahiro Akashi
> bool "Support booting Linux OS images"
> depends on CMD_BOOTM || CMD_BOOTZ || CMD_BOOTI
> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> index 621ed5e5b0fb..13cad6342c36 100644
> --- a/lib/efi_loader/Kconfig
> +++ b/lib/efi_loader/Kconfig
> @@ -32,15 +32,14 @@ config EFI_LOADER
>
> if EFI_LOADER
>
> -config CMD_BOOTEFI_BOOTMGR
> +config BOOTEFI_BOOTMGR
> bool "UEFI Boot Manager"
> - depends on CMDLINE
> default y
> select BOOTMETH_GLOBAL if BOOTSTD
> help
> Select this option if you want to select the UEFI binary to be booted
> - via UEFI variables Boot####, BootOrder, and BootNext. This enables the
> - 'bootefi bootmgr' command.
> + via UEFI variables Boot####, BootOrder, and BootNext. You should also
> + normally enable CMD_BOOTEFI_BOOTMGR so that the command is available.
>
> choice
> prompt "Store for non-volatile UEFI variables"
> diff --git a/lib/efi_loader/Makefile b/lib/efi_loader/Makefile
> index 8d31fc61c601..0a2cb6e3c476 100644
> --- a/lib/efi_loader/Makefile
> +++ b/lib/efi_loader/Makefile
> @@ -42,7 +42,7 @@ targets += initrddump.o
> endif
>
> obj-$(CONFIG_CMD_BOOTEFI_HELLO) += helloworld_efi.o
> -obj-$(CONFIG_CMD_BOOTEFI_BOOTMGR) += efi_bootmgr.o
> +obj-$(CONFIG_BOOTEFI_BOOTMGR) += efi_bootmgr.o
> obj-y += efi_boottime.o
> obj-y += efi_helper.o
> obj-$(CONFIG_EFI_HAVE_CAPSULE_SUPPORT) += efi_capsule.o
> --
> 2.42.0.655.g421f12c284-goog
>
next prev parent reply other threads:[~2023-10-17 0:50 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 22:27 [PATCH v3 00/32] Tidy up use of CONFIG_CMDLINE Simon Glass
2023-10-16 22:27 ` [PATCH v3 01/32] buildman: Use oldconfig when adjusting the config Simon Glass
2023-10-16 22:27 ` [PATCH v3 02/32] bootstd: Correct dependencies on CMDLINE Simon Glass
2023-10-17 13:32 ` Tom Rini
2023-10-18 3:30 ` Simon Glass
2023-10-18 13:25 ` Tom Rini
2023-10-18 14:42 ` Tom Rini
2023-10-18 15:25 ` Simon Glass
2023-10-16 22:27 ` [PATCH v3 03/32] autoboot: " Simon Glass
2023-10-16 22:27 ` [PATCH v3 04/32] cmd: Add a few more " Simon Glass
2023-10-17 13:32 ` Tom Rini
2023-10-18 3:30 ` Simon Glass
2023-10-18 12:56 ` Tom Rini
2023-10-18 13:14 ` Heinrich Schuchardt
2023-10-19 13:59 ` Simon Glass
2023-10-16 22:27 ` [PATCH v3 05/32] test: Make UNIT_TEST depend " Simon Glass
2023-10-16 22:27 ` [PATCH v3 06/32] sifive: Drop an unnecessary #ifdef Simon Glass
2023-10-18 13:51 ` Heinrich Schuchardt
2023-10-18 17:23 ` Sean Anderson
2023-10-18 23:57 ` Tom Rini
2023-10-16 22:27 ` [PATCH v3 07/32] fastboot: Declare a dependency on CMDLINE Simon Glass
2023-10-16 22:27 ` [PATCH v3 08/32] cli: Always build cli_getch Simon Glass
2023-10-16 22:28 ` [PATCH v3 09/32] cmd: Use an #ifdef around run_commandf() Simon Glass
2023-10-17 13:35 ` Tom Rini
2023-10-16 22:28 ` [PATCH v3 10/32] Move bootmenu_conv_key() into its own file Simon Glass
2023-10-16 22:28 ` [PATCH v3 11/32] pxe: Depend on CMDLINE Simon Glass
2023-10-16 22:28 ` [PATCH v3 12/32] env: Split out non-command code into a new file Simon Glass
2023-10-17 13:40 ` Tom Rini
2023-10-18 3:30 ` Simon Glass
2023-10-16 22:28 ` [PATCH v3 13/32] console: Move SYS_PBSIZE into common/ Simon Glass
2023-10-16 22:28 ` [PATCH v3 14/32] bootm: Allow building when cleanup functions are missing Simon Glass
2023-10-17 14:02 ` Tom Rini
2023-10-18 3:31 ` Simon Glass
2023-10-18 12:39 ` Tom Rini
2023-10-19 13:59 ` Simon Glass
2023-10-19 14:54 ` Tom Rini
2023-10-16 22:28 ` [PATCH v3 15/32] fdt: Move working_fdt into fdt_support Simon Glass
2023-10-16 22:28 ` [PATCH v3 16/32] net: Depend on CONFIG_CMDLINE Simon Glass
2023-10-17 14:03 ` Tom Rini
2023-10-18 3:31 ` Simon Glass
2023-10-16 22:28 ` [PATCH v3 17/32] log: Allow use without CONFIG_CMDLINE Simon Glass
2023-10-17 14:05 ` Tom Rini
2023-10-16 22:28 ` [PATCH v3 18/32] video: " Simon Glass
2023-10-17 14:07 ` Tom Rini
2023-10-18 3:31 ` Simon Glass
2023-10-18 12:40 ` Tom Rini
2023-10-16 22:28 ` [PATCH v3 19/32] video: Dont require the font command Simon Glass
2023-10-17 14:07 ` Tom Rini
2023-10-18 3:31 ` Simon Glass
2023-10-18 12:42 ` Tom Rini
2023-10-16 22:28 ` [PATCH v3 20/32] efi: Make commands depend on CMDLINE Simon Glass
2023-10-16 22:28 ` [PATCH v3 21/32] efi: Rearrange the Kconfig for CMD_BOOTEFI_BOOTMGR Simon Glass
2023-10-17 0:50 ` AKASHI Takahiro [this message]
2023-10-17 14:13 ` Tom Rini
2023-10-18 3:31 ` Simon Glass
2023-10-16 22:28 ` [PATCH v3 22/32] efi: Update EFI_LOADER to depend on DM_ETH Simon Glass
2023-10-17 14:09 ` Tom Rini
2023-10-18 3:31 ` Simon Glass
2023-10-18 12:43 ` Tom Rini
2023-10-18 12:55 ` Heinrich Schuchardt
2023-10-19 14:01 ` Simon Glass
2023-10-20 0:30 ` AKASHI Takahiro
2023-10-21 15:43 ` Simon Glass
2023-10-21 18:26 ` Tom Rini
2023-10-22 6:08 ` Heinrich Schuchardt
2023-10-22 14:29 ` Tom Rini
2023-10-22 14:58 ` Tom Rini
2023-10-22 21:55 ` Simon Glass
2023-10-22 22:55 ` Heinrich Schuchardt
2023-10-22 23:53 ` Tom Rini
2023-10-22 23:45 ` Tom Rini
2023-10-23 7:05 ` Simon Glass
2023-10-23 13:16 ` Tom Rini
2023-10-23 17:13 ` Simon Glass
2023-10-23 17:45 ` Tom Rini
2023-10-24 18:02 ` Simon Glass
2023-10-18 13:37 ` Tom Rini
2023-10-18 15:23 ` Simon Glass
2023-10-18 15:27 ` Tom Rini
2023-10-18 16:36 ` Simon Glass
2023-10-19 10:39 ` Peter Robinson
2023-10-19 13:39 ` Tom Rini
2023-10-19 14:01 ` Simon Glass
2023-10-16 22:28 ` [PATCH v3 23/32] cli: Split command-line-editing into its own file Simon Glass
2023-10-16 22:28 ` [PATCH v3 24/32] Add a new Kconfig for command-line entry Simon Glass
2023-10-16 22:28 ` [PATCH v3 25/32] Add a new Kconfig for command-line history Simon Glass
2023-10-16 22:28 ` [PATCH v3 26/32] sandbox: Disable CONFIG_DISTRO_DEFAULTS Simon Glass
2023-10-16 22:28 ` [PATCH v3 27/32] cmd: Make all commands depend on CMDLINE Simon Glass
2023-10-16 22:28 ` [PATCH v3 28/32] sandbox: Avoid requiring cmdline Simon Glass
2023-10-16 22:28 ` [PATCH v3 29/32] arm: x86: Drop discarding of command linker-lists Simon Glass
2023-10-16 22:28 ` [PATCH v3 30/32] mmc: env: Unify the U_BOOT_ENV_LOCATION conditions Simon Glass
2023-10-16 22:28 ` [PATCH v3 31/32] treewide: Tidy up semicolon after command macros Simon Glass
2023-10-16 22:28 ` [PATCH v3 32/32] sandbox: Add a test for disabling CONFIG_CMDLINE Simon Glass
2023-10-17 14:11 ` Tom Rini
2023-10-19 2:32 ` Tom Rini
2023-10-19 14:00 ` Simon Glass
2023-10-19 14:57 ` Tom Rini
2023-10-21 15:44 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZS3aW5IkWrdOR5zL@octopus \
--to=takahiro.akashi@linaro.org \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.