From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Thomas Haller <thaller@redhat.com>
Cc: NetFilter <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nft v2 2/3] tests/shell: skip "table_onoff" test on older kernels
Date: Tue, 17 Oct 2023 11:04:41 +0200 [thread overview]
Message-ID: <ZS5OKQycMX0cScgb@calendula> (raw)
In-Reply-To: <20231017085133.1203402-3-thaller@redhat.com>
On Tue, Oct 17, 2023 at 10:49:07AM +0200, Thomas Haller wrote:
> The "table_onoff" test can only pass with certain (recent) kernels.
> Conditionally exit with status 77, if "eval-exit-code" determines that
> we don't have a suitable kernel version.
>
> In this case, we can find the fixes in:
>
> v6.6 : https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c9bd26513b3a11b3adb3c2ed8a31a01a87173ff1
> v6.5.6 : https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5e5754e9e77ce400d70ff3c30fea466c8dfe9a9f
> v6.1.56 : https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c4b0facd5c20ceae3d07018a3417f06302fa9cd1
> v5.15.135 : https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0dcc9b4097d860d9af52db5366a8755c13468d13
I am not sure it worth this level of tracking.
Soon these patches will be in upstream stable and this extra shell
code will be simply deadcode in little time.
> Fixes: bcca2d67656f ('tests: add test for dormant on/off/on bug')
> Signed-off-by: Thomas Haller <thaller@redhat.com>
> ---
> tests/shell/testcases/transactions/table_onoff | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/shell/testcases/transactions/table_onoff b/tests/shell/testcases/transactions/table_onoff
> index 831d4614c1f2..0e70ad2cc3f4 100755
> --- a/tests/shell/testcases/transactions/table_onoff
> +++ b/tests/shell/testcases/transactions/table_onoff
> @@ -11,7 +11,9 @@ delete table ip t
> EOF
>
> if [ $? -eq 0 ]; then
> - exit 1
> + echo "Command to re-awaken a dormant table did not fail. Lacking https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c9bd26513b3a11b3adb3c2ed8a31a01a87173ff1 ?"
> + "$NFT_TEST_BASEDIR/helpers/eval-exit-code" kernel 6.6 6.5.6 6.1.56 5.15.135
> + exit $?
> fi
>
> set -e
> --
> 2.41.0
>
next prev parent reply other threads:[~2023-10-17 9:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 8:49 [PATCH nft v2 0/3] add "eval-exit-code" and skip tests based on kernel version Thomas Haller
2023-10-17 8:49 ` [PATCH nft v2 1/3] tests/shell: add "tests/shell/helpers/eval-exit-code" Thomas Haller
2023-10-17 8:49 ` [PATCH nft v2 2/3] tests/shell: skip "table_onoff" test on older kernels Thomas Haller
2023-10-17 9:04 ` Pablo Neira Ayuso [this message]
2023-10-17 11:21 ` Thomas Haller
2023-10-17 11:40 ` Pablo Neira Ayuso
2023-10-17 12:43 ` Thomas Haller
2023-10-17 13:58 ` Pablo Neira Ayuso
2023-10-17 8:49 ` [PATCH nft v2 3/3] tests/shell: skip "vlan_8021ad_tag" " Thomas Haller
2023-10-17 9:24 ` [PATCH nft v2 0/3] add "eval-exit-code" and skip tests based on kernel version Florian Westphal
2023-10-17 20:41 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZS5OKQycMX0cScgb@calendula \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.