All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
	Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org
Subject: Re: [perf stat] Extend --cpu to non-system-wide runs too? was Re: [PATCH v3] perf bench sched pipe: Add -G/--cgroups option
Date: Tue, 17 Oct 2023 14:43:45 +0200	[thread overview]
Message-ID: <ZS6BgfOUeWQnI1mS@gmail.com> (raw)
In-Reply-To: <ZS592qxF3YxmCoG1@kernel.org>


* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Em Tue, Oct 17, 2023 at 01:40:07PM +0200, Ingo Molnar escreveu:
> > Side note: it might make sense to add a sane cpumask/affinity setting 
> > option to perf stat itself:
> > 
> >   perf stat --cpumask 
> > 
> > ... or so?
> > 
> > We do have -C:
> > 
> >     -C, --cpu <cpu>       list of cpus to monitor in system-wide
> > 
> > ... but that's limited to --all-cpus, right?
> > 
> > Perhaps we could extend --cpu to non-system-wide runs too?
> 
> Maybe I misunderstood your question, but its a list of cpus to limit the
> counting:

Ok.

So I thought that "--cpumask mask/list/etc" should simply do what 'taskset' 
is doing: using the sched_setaffinity() syscall to make the current 
workload and all its children.

There's impact on perf stat itself: it could just call sched_setaffinity() 
early on, and not bother about it?

Having it built-in into perf would simply make it easier to not forget 
running 'taskset'. :-)

Thanks,

	Ingo

  reply	other threads:[~2023-10-17 12:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-16  4:42 [PATCH v3] perf bench sched pipe: Add -G/--cgroups option Namhyung Kim
2023-10-16  9:35 ` Ingo Molnar
2023-10-16 15:38   ` Arnaldo Carvalho de Melo
2023-10-16 15:45     ` Arnaldo Carvalho de Melo
2023-10-16 15:51       ` Arnaldo Carvalho de Melo
2023-10-16 15:55         ` Arnaldo Carvalho de Melo
2023-10-16 20:34           ` Arnaldo Carvalho de Melo
2023-10-16 21:44             ` Namhyung Kim
2023-10-17 12:09               ` Arnaldo Carvalho de Melo
2023-10-17 11:40             ` Ingo Molnar
2023-10-17 12:28               ` [perf stat] Extend --cpu to non-system-wide runs too? was " Arnaldo Carvalho de Melo
2023-10-17 12:43                 ` Ingo Molnar [this message]
2023-10-17 18:31                   ` Arnaldo Carvalho de Melo
2023-10-17 19:05                     ` Namhyung Kim
2023-10-18 12:07                     ` Ingo Molnar
2023-10-17  8:06     ` Athira Rajeev
2023-10-16 17:25 ` Athira Rajeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZS6BgfOUeWQnI1mS@gmail.com \
    --to=mingo@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.