From: Yury Norov <yury.norov@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Song Liu <songliubraving@fb.com>,
Alexei Starovoitov <ast@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] buildid: reduce header file dependencies for module
Date: Tue, 17 Oct 2023 08:29:53 -0700 [thread overview]
Message-ID: <ZS6lxxmGDy1eRWoh@yury-ThinkPad> (raw)
In-Reply-To: <20231017143408.2876181-1-arnd@kernel.org>
On Tue, Oct 17, 2023 at 04:33:58PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The vmlinux decompressor code intentionally has only a limited set of
> included header files, but this started running into a build failure
> because of the bitmap logic needing linux/errno.h:
>
> In file included from include/linux/cpumask.h:12,
> from include/linux/mm_types_task.h:14,
> from include/linux/mm_types.h:5,
> from include/linux/buildid.h:5,
> from include/linux/module.h:14,
> from arch/arm/boot/compressed/../../../../lib/lz4/lz4_decompress.c:39,
> from arch/arm/boot/compressed/../../../../lib/decompress_unlz4.c:10,
> from arch/arm/boot/compressed/decompress.c:60:
> include/linux/bitmap.h: In function 'bitmap_allocate_region':
> include/linux/bitmap.h:527:25: error: 'EBUSY' undeclared (first use in this function)
> 527 | return -EBUSY;
> | ^~~~~
> include/linux/bitmap.h:527:25: note: each undeclared identifier is reported only once for each function it appears in
> include/linux/bitmap.h: In function 'bitmap_find_free_region':
> include/linux/bitmap.h:554:17: error: 'ENOMEM' undeclared (first use in this function)
> 554 | return -ENOMEM;
> | ^~~~~~
>
> This is easily avoided by changing linux/buildid.h to no longer depend on
> linux/mm_types.h, a header that pulls in a huge number of indirect dependencies.
>
> Fixes: b9c957f554442 ("bitmap: move bitmap_*_region() functions to bitmap.h")
> Fixes: bd7525dacd7e2 ("bpf: Move stack_map_get_build_id into lib")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Yury Norov <yury.norov@gmail.com>
Would you like me to add this into bitmap-for-next?
next prev parent reply other threads:[~2023-10-17 15:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 14:33 [PATCH] buildid: reduce header file dependencies for module Arnd Bergmann
2023-10-17 15:29 ` Yury Norov [this message]
2023-10-17 15:44 ` Arnd Bergmann
2023-10-17 16:13 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZS6lxxmGDy1eRWoh@yury-ThinkPad \
--to=yury.norov@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=ast@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.