From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, davem@davemloft.net,
edumazet@google.com, donald.hunter@gmail.com
Subject: Re: [patch net-next v3 1/2] tools: ynl-gen: lift type requirement for attribute subsets
Date: Fri, 6 Oct 2023 18:55:37 +0200 [thread overview]
Message-ID: <ZSA8CVP6+DnPrHly@nanopsycho> (raw)
In-Reply-To: <20231006080039.1955914d@kernel.org>
Fri, Oct 06, 2023 at 05:00:39PM CEST, kuba@kernel.org wrote:
>On Fri, 6 Oct 2023 13:44:35 +0200 Jiri Pirko wrote:
>> + # type property is only required if not in subset definition
>> + if:
>> + properties:
>> + subset-of:
>> + not:
>> + type: string
>> + then:
>> + properties:
>> + attributes:
>> + items:
>> + required: [ type ]
>
>Nice!
Took me like 3 hours debugging this. These json schemas are from
different world than I am...
>
>Reviewed-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2023-10-06 16:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 11:44 [patch net-next v3 0/2] tools: ynl-gen: lift type requirement for attribute subsets Jiri Pirko
2023-10-06 11:44 ` [patch net-next v3 1/2] " Jiri Pirko
2023-10-06 15:00 ` Jakub Kicinski
2023-10-06 16:55 ` Jiri Pirko [this message]
2023-10-06 19:33 ` Jakub Kicinski
2023-10-06 11:44 ` [patch net-next v3 2/2] netlink: specs: remove redundant type keys from attributes in subsets Jiri Pirko
2023-10-10 2:50 ` [patch net-next v3 0/2] tools: ynl-gen: lift type requirement for attribute subsets patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSA8CVP6+DnPrHly@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.