From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <olsajiri@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Quentin Monnet <quentin@isovalent.com>,
Dmitry Goncharov <dgoncharov@users.sf.net>,
linux-perf-users@vger.kernel.org, bpf@vger.kernel.org,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
Ian Rogers <irogers@google.com>, KP Singh <kpsingh@chromium.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] tools/build: Fix -s detection code for new make
Date: Fri, 6 Oct 2023 19:15:21 -0300 [thread overview]
Message-ID: <ZSCG+UsvhEv6rUz+@kernel.org> (raw)
In-Reply-To: <ZSB7u/jmxpjGSrVt@krava>
Em Fri, Oct 06, 2023 at 11:27:23PM +0200, Jiri Olsa escreveu:
> On Wed, Oct 04, 2023 at 03:59:56PM +0200, Jiri Olsa wrote:
> > As Dmitry described in [1] changelog the current way of detecting
> > -s option is broken for new make.
> >
> > Changing the tools/build -s option detection the same way as it was
> > fixed for root Makefile in [1].
> >
> > [1] 4bf73588165b ("kbuild: Port silent mode detection to future gnu make.")
> >
> > Cc: Dmitry Goncharov <dgoncharov@users.sf.net>
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
>
> we actually need same change in tools/scripts/Makefile.include as well,
> I'll resend v2
Thanks, I noticed the change in behaviour and was gegoing thru other
grep/sed, egrep, NO_LIBTRACEEVENT, binutils not being installed leading
to -1 error in annotation, etc before getting to this, on the way to
judiciously test the new default to BUILD_BPF_SKEL=1.
I did a quick test and got a familiar output when building perf, please
submit v2, v1 is great for me so far :)
- Arnaldo
> jirka
>
> > ---
> > tools/build/Makefile.build | 10 +++++++++-
> > 1 file changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
> > index fac42486a8cf..5fb3fb3d97e0 100644
> > --- a/tools/build/Makefile.build
> > +++ b/tools/build/Makefile.build
> > @@ -20,7 +20,15 @@ else
> > Q=@
> > endif
> >
> > -ifneq ($(findstring s,$(filter-out --%,$(MAKEFLAGS))),)
> > +# If the user is running make -s (silent mode), suppress echoing of commands
> > +# make-4.0 (and later) keep single letter options in the 1st word of MAKEFLAGS.
> > +ifeq ($(filter 3.%,$(MAKE_VERSION)),)
> > +short-opts := $(firstword -$(MAKEFLAGS))
> > +else
> > +short-opts := $(filter-out --%,$(MAKEFLAGS))
> > +endif
> > +
> > +ifneq ($(findstring s,$(short-opts)),)
> > quiet=silent_
> > endif
> >
> > --
> > 2.41.0
> >
--
- Arnaldo
prev parent reply other threads:[~2023-10-06 22:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 13:59 [PATCH] tools/build: Fix -s detection code for new make Jiri Olsa
2023-10-06 21:27 ` Jiri Olsa
2023-10-06 22:15 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSCG+UsvhEv6rUz+@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dgoncharov@users.sf.net \
--cc=haoluo@google.com \
--cc=irogers@google.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=olsajiri@gmail.com \
--cc=quentin@isovalent.com \
--cc=sdf@google.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.