From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FAF1E95A8E for ; Mon, 9 Oct 2023 13:26:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF93180008; Mon, 9 Oct 2023 09:26:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DAA09900002; Mon, 9 Oct 2023 09:26:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C98AE80008; Mon, 9 Oct 2023 09:26:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BB308900002 for ; Mon, 9 Oct 2023 09:26:09 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 89D2EA020E for ; Mon, 9 Oct 2023 13:26:09 +0000 (UTC) X-FDA: 81325996458.23.F516EB4 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf03.hostedemail.com (Postfix) with ESMTP id 82FED2002F for ; Mon, 9 Oct 2023 13:26:06 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf03.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696857967; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ISlwurjWjNP4XppcB4XSEsVNX8IeLMCubfH8A0/c2Fk=; b=I1yXsy3Hym+hnu7Z/AkpbVF1K1XQTw+42frsaWwQkM9uDoaBPCJC12UG34jl6C7DttNF2U g2ER9oFCjMP3LqeoviSgYi3nKgYp3yk8ntmAbOZBGX6bRd+tLBulh9Xcgd1RuoJ19c29ni 1kVagdj0lbTsqvLGHvoC6tdQmPnjqSE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf03.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696857967; a=rsa-sha256; cv=none; b=sT/wh5R8WtvJsuMj7HsipOfxgCJ8JV03USPK9BahdXo00PmjtTw8A9HOx8osUQo8TEEQ9z NFEeRSGv13VHmpduWuRZVH7fBIoOTIG9jFRvT3qtt2aaombtFjT6a87314oYkL/3jTvZzh WhM2xJ2Q+1ZU9Sk1JmiKCmmNgETlGG4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 3BF23CE13C8; Mon, 9 Oct 2023 13:26:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD895C433C9; Mon, 9 Oct 2023 13:25:59 +0000 (UTC) Date: Mon, 9 Oct 2023 14:25:57 +0100 From: Catalin Marinas To: Liu Shixin Cc: Patrick Wang , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] mm/kmemleak: fix print format of pointer in pr_debug() Message-ID: References: <20231008023317.3015699-1-liushixin2@huawei.com> <20231008023317.3015699-5-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231008023317.3015699-5-liushixin2@huawei.com> X-Rspamd-Queue-Id: 82FED2002F X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: ufrbezf77rdecnq1fcc4cgw6pska6345 X-HE-Tag: 1696857966-693308 X-HE-Meta: U2FsdGVkX19MyC+6CnOLshI4dsd2UMlBMVkAC6AqHMaCo0Q123cFn6RJfbou6p0DCbWDCXJFSSUknAt43ZRdW/L1JtYcd2rFMCNVA+RgqR2Y64D14oTIoVZ/aMH9iWCIdOLkexOWarjMENOnOx4MAjXC+RYOiJ5/LBPjUO47KEdueGS0mQIB0Z0bNev8QZs9YuB+urT06CpmLGN9CZfL9Io+WRaVg4r6DA8hxgKqIxaMhUq9k0Ekx1LIRQvsOjEYbBnGTOT7ZyW6My8tiXxFA3uaKMnvS1A8Qi1x+77kl/9ZWpyjO7jDgqG0k5xOBKh5vFmmNzRSxHyh2LqN5B4ugSIXHVj9Bg0B+gn+NUjbhfzfF8wtQ9qPb1S5Ytps9iF1IdfG3zNwElrg9SlXM/lwFoKL3543PaVtCq8YcPfXgrMfenw9eejwNXXIDs16Q6d+fl1NDAE/DcxQazf/P4LDkNZ4RGnTxICJ1egftp3/Js72jhVsbDW2eoS+J3KZy9X5lWh+w5WuO5zSEH/S5aeoFd/CTjMCktHY/WJ53CslR9Z1w5z16acsTbhPhB76iDdgwGJEmxhybhShv7kQ+/cJkv7M6KN1iQjGsXQxoeG/5CxGFOnrVpfRGpvqWuQvieVzbjWvTUxdQAfIPb3P0+1j+yNlfT5hud7Kt8XygokPYGvht3H8pNjmarfgA0JRJPx9FR61hcShrlR+d4gtKhX3yoK1yKA/IeE/Lst/s5OAYHS8MCssE8sG1tjKDXbv4AyTrUbPF18dUnWXQDkDxYeGRb+JF3SbV28UZgV/PWa6nRQwfjVekC8dS0gCD4Uq6Gai2mosqyQ8DTVbljphvg+rp6HhCmOG5MgbOlBJ7aPtLbMI+7gYSVrupP8VESmPIiIdTdEe64Cqj2fgtqMXQqrqXgvbEn/SZgQ0fFuz/fevEvQBhwhidu6820kr/AKW6yTaSXT1AeP3fGZ/kGC/2NT zpVTOe3N vbZmZei9IOR+zvxfUBaKqTl27UR0DUhdt8rRCrYIsgKgq2IXUa92c6jgJBkk8no13b5qN40a/AGDez4CIKbj5rUSDDgRaij/JwF4qr7JK3C8oQpWD7nFC1cTrP/6tqW3Sydx2l9hupVyrr/LXvfUpgY5gv0nFJvsfTKAtULJjtrX0PNVtZtztjN+SMeL+UyOLwtzYhMfrpUHoXaRUKVhNt7v4Xg2zMD/bPCXmvti4CWTgQCXNSa3WF7P93FsdYbap34Kfu1P8x3YOvugVhUAc/HKmupampCfsceO2sxBpLiQ03ouF+3g3uT/4K1cQbnhBOPXy/WppgPPOhq2G2pHjAXCTAm9wKBrApHJTA7SisQZMYogFx7ojAsRgzcQcr/SyVGanqBjbpHXAKOsPBTmM5pMZ4JSsDSLfvT46uIr+Dz4Fa5Orp5d9IEKAWIGtumJPRodk+obwcA0o8gfTZwaLTdzSjn3TaHewp9c/p7e1jdXrp9McGB7mJAwJKukzpj0gjuLq/CEv+cYRdxA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Oct 08, 2023 at 10:33:17AM +0800, Liu Shixin wrote: > With 0x%p, the pointer will be hashed and print (____ptrval____) instead. > And with 0x%pa, the pointer can be successfully printed but with duplicate > prefixes, which looks like: > > kmemleak: kmemleak_free(0x(____ptrval____)) > kmemleak: kmemleak_free_percpu(0x(____ptrval____)) > kmemleak: kmemleak_free_part_phys(0x0x0000000a1af86000) > > Use 0x%px instead of 0x%p or 0x%pa to print the pointer. Then the print > will be like: > > kmemleak: kmemleak_free(0xffff9111c145b020) > kmemleak: kmemleak_free_percpu(0x00000000000333b0) > kmemleak: kmemleak_free_part_phys(0x0000000a1af80000) > > Signed-off-by: Liu Shixin Acked-by: Catalin Marinas