From: Simon Horman <horms@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Chas Williams <3chas3@gmail.com>,
linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atm: fore200e: Drop unnecessary of_match_device()
Date: Mon, 9 Oct 2023 15:13:40 +0200 [thread overview]
Message-ID: <ZSP8hDuWuJg7qUSf@kernel.org> (raw)
In-Reply-To: <20231006214421.339445-1-robh@kernel.org>
On Fri, Oct 06, 2023 at 04:44:21PM -0500, Rob Herring wrote:
> It is not necessary to call of_match_device() in probe. If we made it to
> probe, then we've already successfully matched.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
I agree that the check is redundant.
And that with it removed, the forward declaration of fore200e_sba_match
is no longer needed.
Minor nit: I assume the target tree is net-next.
Ideally that would be specified.
Subject: [PATCH net-net] ...
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-10-09 13:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 21:44 [PATCH] atm: fore200e: Drop unnecessary of_match_device() Rob Herring
2023-10-09 13:13 ` Simon Horman [this message]
2023-10-10 10:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSP8hDuWuJg7qUSf@kernel.org \
--to=horms@kernel.org \
--cc=3chas3@gmail.com \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.