From: Simon Horman <horms@kernel.org>
To: Ricardo Lopes <ricardoapl.dev@gmail.com>
Cc: manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com,
coiby.xu@gmail.com, gregkh@linuxfoundation.org,
netdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH v2] staging: qlge: Replace strncpy with strscpy
Date: Mon, 9 Oct 2023 15:17:18 +0200 [thread overview]
Message-ID: <ZSP9XspeNznHzlA6@kernel.org> (raw)
In-Reply-To: <20231006161240.28048-1-ricardoapl.dev@gmail.com>
On Fri, Oct 06, 2023 at 05:12:24PM +0100, Ricardo Lopes wrote:
> Reported by checkpatch:
>
> WARNING: Prefer strscpy, strscpy_pad, or __nonstring over strncpy
>
> Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
> ---
> v2: Redo changelog text
Kees,
could you find a moment to look over this one?
>
> drivers/staging/qlge/qlge_dbg.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
> index c7e865f51..5f08a8492 100644
> --- a/drivers/staging/qlge/qlge_dbg.c
> +++ b/drivers/staging/qlge/qlge_dbg.c
> @@ -696,7 +696,7 @@ static void qlge_build_coredump_seg_header(struct mpi_coredump_segment_header *s
> seg_hdr->cookie = MPI_COREDUMP_COOKIE;
> seg_hdr->seg_num = seg_number;
> seg_hdr->seg_size = seg_size;
> - strncpy(seg_hdr->description, desc, (sizeof(seg_hdr->description)) - 1);
> + strscpy(seg_hdr->description, desc, sizeof(seg_hdr->description));
> }
>
> /*
> @@ -737,7 +737,7 @@ int qlge_core_dump(struct qlge_adapter *qdev, struct qlge_mpi_coredump *mpi_core
> sizeof(struct mpi_coredump_global_header);
> mpi_coredump->mpi_global_header.image_size =
> sizeof(struct qlge_mpi_coredump);
> - strncpy(mpi_coredump->mpi_global_header.id_string, "MPI Coredump",
> + strscpy(mpi_coredump->mpi_global_header.id_string, "MPI Coredump",
> sizeof(mpi_coredump->mpi_global_header.id_string));
>
> /* Get generic NIC reg dump */
> @@ -1225,7 +1225,7 @@ static void qlge_gen_reg_dump(struct qlge_adapter *qdev,
> sizeof(struct mpi_coredump_global_header);
> mpi_coredump->mpi_global_header.image_size =
> sizeof(struct qlge_reg_dump);
> - strncpy(mpi_coredump->mpi_global_header.id_string, "MPI Coredump",
> + strscpy(mpi_coredump->mpi_global_header.id_string, "MPI Coredump",
> sizeof(mpi_coredump->mpi_global_header.id_string));
>
> /* segment 16 */
> --
> 2.41.0
>
>
next prev parent reply other threads:[~2023-10-09 13:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 16:12 [PATCH v2] staging: qlge: Replace strncpy with strscpy Ricardo Lopes
2023-10-09 13:17 ` Simon Horman [this message]
2023-10-09 16:44 ` Kees Cook
2023-10-09 18:53 ` Ricardo Lopes
2023-10-09 17:22 ` Justin Stitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSP9XspeNznHzlA6@kernel.org \
--to=horms@kernel.org \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=coiby.xu@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=ricardoapl.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.