From: Philip Li <philip.li@intel.com>
To: kernel test robot <lkp@intel.com>
Cc: Olaf Hering <olaf@aepfle.de>, <oe-kbuild-all@lists.linux.dev>,
<linux-kernel@vger.kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>
Subject: Re: fs/afs/dir.c:50:1: error: no return statement in function returning non-void
Date: Tue, 10 Oct 2023 20:26:19 +0800 [thread overview]
Message-ID: <ZSVC64XHKyCdcTx7@rli9-mobl> (raw)
In-Reply-To: <202310101901.Q5SauZ72-lkp@intel.com>
On Tue, Oct 10, 2023 at 07:16:57PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 94f6f0550c625fab1f373bb86a6669b45e9748b3
> commit: 172aad81a882443eefe1bd860c4eddc81b14dd5b kbuild: enforce -Werror=return-type
> date: 3 years ago
> config: s390-randconfig-r033-20230512 (https://download.01.org/0day-ci/archive/20231010/202310101901.Q5SauZ72-lkp@intel.com/config)
> compiler: s390-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231010/202310101901.Q5SauZ72-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202310101901.Q5SauZ72-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
Kindly ignore this false report that bisects to the wrong first bad commit.
>
> fs/afs/dir.c: In function 'afs_dir_set_page_dirty':
> >> fs/afs/dir.c:50:1: error: no return statement in function returning non-void [-Werror=return-type]
> 50 | }
> | ^
> cc1: some warnings being treated as errors
>
>
> vim +50 fs/afs/dir.c
>
> ^1da177e4c3f415 Linus Torvalds 2005-04-16 19
> 260a980317dac80 David Howells 2007-04-26 20 static struct dentry *afs_lookup(struct inode *dir, struct dentry *dentry,
> 00cd8dd3bf95f2c Al Viro 2012-06-10 21 unsigned int flags);
> ^1da177e4c3f415 Linus Torvalds 2005-04-16 22 static int afs_dir_open(struct inode *inode, struct file *file);
> 1bbae9f81860995 Al Viro 2013-05-22 23 static int afs_readdir(struct file *file, struct dir_context *ctx);
> 0b728e1911cbe6e Al Viro 2012-06-10 24 static int afs_d_revalidate(struct dentry *dentry, unsigned int flags);
> fe15ce446beb3a3 Nick Piggin 2011-01-07 25 static int afs_d_delete(const struct dentry *dentry);
> 79ddbfa500b37a9 David Howells 2019-04-25 26 static void afs_d_iput(struct dentry *dentry, struct inode *inode);
> 5cf9dd55a0ec264 David Howells 2018-04-09 27 static int afs_lookup_one_filldir(struct dir_context *ctx, const char *name, int nlen,
> 5cf9dd55a0ec264 David Howells 2018-04-09 28 loff_t fpos, u64 ino, unsigned dtype);
> ac7576f4b1da8c9 Miklos Szeredi 2014-10-30 29 static int afs_lookup_filldir(struct dir_context *ctx, const char *name, int nlen,
> afefdbb28a0a2af David Howells 2006-10-03 30 loff_t fpos, u64 ino, unsigned dtype);
> 4acdaf27ebe2034 Al Viro 2011-07-26 31 static int afs_create(struct inode *dir, struct dentry *dentry, umode_t mode,
> ebfc3b49a7ac259 Al Viro 2012-06-10 32 bool excl);
> 18bb1db3e7607e4 Al Viro 2011-07-26 33 static int afs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode);
> 260a980317dac80 David Howells 2007-04-26 34 static int afs_rmdir(struct inode *dir, struct dentry *dentry);
> 260a980317dac80 David Howells 2007-04-26 35 static int afs_unlink(struct inode *dir, struct dentry *dentry);
> 260a980317dac80 David Howells 2007-04-26 36 static int afs_link(struct dentry *from, struct inode *dir,
> 260a980317dac80 David Howells 2007-04-26 37 struct dentry *dentry);
> 260a980317dac80 David Howells 2007-04-26 38 static int afs_symlink(struct inode *dir, struct dentry *dentry,
> 260a980317dac80 David Howells 2007-04-26 39 const char *content);
> 260a980317dac80 David Howells 2007-04-26 40 static int afs_rename(struct inode *old_dir, struct dentry *old_dentry,
> 1cd66c93ba8cdb8 Miklos Szeredi 2016-09-27 41 struct inode *new_dir, struct dentry *new_dentry,
> 1cd66c93ba8cdb8 Miklos Szeredi 2016-09-27 42 unsigned int flags);
> f3ddee8dc4e2cff David Howells 2018-04-06 43 static int afs_dir_releasepage(struct page *page, gfp_t gfp_flags);
> f3ddee8dc4e2cff David Howells 2018-04-06 44 static void afs_dir_invalidatepage(struct page *page, unsigned int offset,
> f3ddee8dc4e2cff David Howells 2018-04-06 45 unsigned int length);
> f3ddee8dc4e2cff David Howells 2018-04-06 46
> f3ddee8dc4e2cff David Howells 2018-04-06 47 static int afs_dir_set_page_dirty(struct page *page)
> f3ddee8dc4e2cff David Howells 2018-04-06 48 {
> f3ddee8dc4e2cff David Howells 2018-04-06 49 BUG(); /* This should never happen. */
> f3ddee8dc4e2cff David Howells 2018-04-06 @50 }
> ^1da177e4c3f415 Linus Torvalds 2005-04-16 51
>
> :::::: The code at line 50 was first introduced by commit
> :::::: f3ddee8dc4e2cff37936afbeed2fdaa95b7fb7c6 afs: Fix directory handling
>
> :::::: TO: David Howells <dhowells@redhat.com>
> :::::: CC: David Howells <dhowells@redhat.com>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2023-10-10 12:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 11:16 fs/afs/dir.c:50:1: error: no return statement in function returning non-void kernel test robot
2023-10-10 12:26 ` Philip Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSVC64XHKyCdcTx7@rli9-mobl \
--to=philip.li@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=masahiroy@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.