All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Ming Wang <wangming01@loongson.cn>
Cc: kexec@lists.infradead.org
Subject: Re: [kexec-tools] Archive file is missed iomem.h file under loongarch architecture.
Date: Tue, 10 Oct 2023 15:01:26 +0200	[thread overview]
Message-ID: <ZSVLJgZ31ZhijOYt@kernel.org> (raw)
In-Reply-To: <41eb6420-915a-4746-8fe9-8778a46d9479@loongson.cn> <561b3717-0ce4-42ae-8846-6c0154a91557@loongson.cn>

On Mon, Oct 09, 2023 at 05:47:43PM +0800, Ming Wang wrote:
> Hi,  maintainers,
> 
> 
> I get the kexec-tools 2.0.27 from http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.27.tar.gz, 
> 
> But I noticed that the kexec-tools-2.0.27/kexec/arch/loongarch/iomem.h file was missing from
> 
> this archive.
> 
> 
> This causes build errors in many distributions, like debian.  The error message is as follows,
> 
> make[1]: *** [Makefile:123: kexec/arch/loongarch/crashdump-loongarch.o] Error 1
> kexec/arch/loongarch/kexec-loongarch.c:27:10: fatal error: iomem.h: No such file or directory
>    27 | #include "iomem.h"
> 
> See also: https://buildd.debian.org/status/package.php?p=kexec-tools&suite=sid
> 
> 
> Can this archive be repaired and updated?
> 
> 
> Thanks, Ming

Hi,

I need to think about how to deal with this from a release PoV.
But can you check if the patch below resolves your problem?

diff --git a/kexec/arch/loongarch/Makefile b/kexec/arch/loongarch/Makefile
index cee7e569a2a2..f91d0baf049a 100644
--- a/kexec/arch/loongarch/Makefile
+++ b/kexec/arch/loongarch/Makefile
@@ -19,5 +19,6 @@ loongarch_VIRT_TO_PHYS =
 dist += kexec/arch/loongarch/Makefile $(loongarch_KEXEC_SRCS)			\
 	kexec/arch/loongarch/kexec-loongarch.h					\
 	kexec/arch/loongarch/image-header.h					\
+	kexec/arch/loongarch/iomem.h						\
 	kexec/arch/loongarch/crashdump-loongarch.h				\
 	kexec/arch/loongarch/include/arch/options.h

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  parent reply	other threads:[~2023-10-10 13:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-09  9:59 [kexec-tools] Archive file is missed iomem.h file under loongarch architecture Ming Wang
     [not found] ` <561b3717-0ce4-42ae-8846-6c0154a91557@loongson.cn>
2023-10-10 13:01   ` Simon Horman [this message]
2023-10-11  2:56     ` Ming Wang
2023-10-11  3:28     ` Ming Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZSVLJgZ31ZhijOYt@kernel.org \
    --to=horms@kernel.org \
    --cc=kexec@lists.infradead.org \
    --cc=wangming01@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.