From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0170CD8C99 for ; Tue, 10 Oct 2023 14:58:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233259AbjJJO60 (ORCPT ); Tue, 10 Oct 2023 10:58:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232634AbjJJO6Z (ORCPT ); Tue, 10 Oct 2023 10:58:25 -0400 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C37D4C6 for ; Tue, 10 Oct 2023 07:58:23 -0700 (PDT) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94.2) (envelope-from ) id 1qqEBg-0004W7-NV; Tue, 10 Oct 2023 16:58:21 +0200 Date: Tue, 10 Oct 2023 16:58:20 +0200 From: Phil Sutter To: Florian Westphal Cc: Pablo Neira Ayuso , netfilter-devel@vger.kernel.org Subject: Re: [PATCH nft] doc: remove references to timeout in reset command Message-ID: Mail-Followup-To: Phil Sutter , Florian Westphal , Pablo Neira Ayuso , netfilter-devel@vger.kernel.org References: <20231010142704.54741-1-pablo@netfilter.org> <20231010144813.GA1407@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231010144813.GA1407@breakpoint.cc> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, Oct 10, 2023 at 04:48:13PM +0200, Florian Westphal wrote: > Phil Sutter wrote: > > On Tue, Oct 10, 2023 at 04:27:04PM +0200, Pablo Neira Ayuso wrote: > > > After Linux kernel's patch ("netfilter: nf_tables: do not refresh > > > timeout when resetting element") timers are not reset anymore, update > > > documentation to keep this in sync. > > > > How is limit statement being reset? The dump callbacks in nft_limit.c > > ignore the 'bool reset' parameter. > > Was that deliberate? I don't see why it would be exempt? One could reset internal tokens and last values, indeed. I don't see a patch pending to do that, though. BTW: nft also does not support for 'reset limit(s)'. Cheers, Phil