From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 508CACDB470 for ; Wed, 11 Oct 2023 18:03:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MOn87obtnrhnnEsKSLbikCzIkXWaKcKPeP3waVQaRNA=; b=l4/pONrPbcUKrF 4DmbT//q97lBkXJLRYLFFIq7u0x+XeHe/FPhcNLazzDT7Ycpc/pyX7CwAUbce0JJ1A+xG2PyJDBzi LuGJODO+yLQZuQpHeht5OsRK7KtHsNFuZUtJlMULllyDh7H5f2YaPNA/xTOq2ZEaKQoZnRS83kazh sNthJa0sRe71pEAdbaf1Yc9iMiuzozzj/R5CIodnnV8D4r9Ofnuwx5dJ45rXKx0tW9FQJrzGHPF7r W6K8wIOtMF0GtEtQq/cTu3yYPettzZJpi2BQQAfpnlLuJ8ojJtatDs6IxojFy7G1cQ/ed2lawvaX0 Q3W0yWqazqUDoWA05FhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqdY9-00GPdX-1R; Wed, 11 Oct 2023 18:03:13 +0000 Received: from mgamail.intel.com ([192.198.163.7]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqdY6-00GPZz-2a for linux-arm-kernel@lists.infradead.org; Wed, 11 Oct 2023 18:03:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697047390; x=1728583390; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=lURMbn5dRbkd2o52I5y99bEbTUmrRbrcbtygejYOJrA=; b=Q3tyzGrXNeNvCH54uYHCESqstoY0RUD8A1uTE4/2V6al/fpup/rfRiPk QnYFZTeGdQlhDLYhspR1ZdksNxlsLrDHf3aQVWu2hXnd5x7eNpBPI0okV hzuCZcoJLwqDhCuDOmXGFZbk//IF0wp1dgKcxDo3TUvhtkAVmOtuoxkP6 aLpKib8q812RXZp6AfMahRRacMj1a5/hnDe4ponrLE434qy0dRSimMcq0 Ob/US9bIGddKXfNZIfUKSmmXH2vUc9U/GmCCkE7ZKzJDZN+lVdVr0iVZT xqRnGNGeTkqcECh6Q4xrisTs10ONwKueg/DoH1F/xZsnsRJT0KNEvTniZ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="6290836" X-IronPort-AV: E=Sophos;i="6.03,216,1694761200"; d="scan'208";a="6290836" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 11:02:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="927661637" X-IronPort-AV: E=Sophos;i="6.03,216,1694761200"; d="scan'208";a="927661637" Received: from unknown (HELO smile.fi.intel.com) ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 11:02:50 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC1) (envelope-from ) id 1qqdXj-00000004nnD-07AG; Wed, 11 Oct 2023 21:02:47 +0300 Date: Wed, 11 Oct 2023 21:02:46 +0300 From: Andy Shevchenko To: Alexander Potapenko Cc: catalin.marinas@arm.com, will@kernel.org, pcc@google.com, andreyknvl@gmail.com, aleksander.lobakin@intel.com, linux@rasmusvillemoes.dk, yury.norov@gmail.com, alexandru.elisei@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, eugenis@google.com, syednwaris@gmail.com, william.gray@linaro.org Subject: Re: [PATCH v7 2/5] lib/test_bitmap: add tests for bitmap_{read,write}() Message-ID: References: <20231011172836.2579017-1-glider@google.com> <20231011172836.2579017-3-glider@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231011172836.2579017-3-glider@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231011_110310_854071_9713F27B X-CRM114-Status: UNSURE ( 9.18 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 11, 2023 at 07:28:32PM +0200, Alexander Potapenko wrote: > Add basic tests ensuring that values can be added at arbitrary positions > of the bitmap, including those spanning into the adjacent unsigned > longs. Would be nice to have an additional test like bitmap_write(..., 33 /* or anything > 32 */); This will require ifdeffery. So at least this code may warn users about corner cases in the agnostic code. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6820BCDB473 for ; Wed, 11 Oct 2023 18:03:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235112AbjJKSDT (ORCPT ); Wed, 11 Oct 2023 14:03:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234859AbjJKSDJ (ORCPT ); Wed, 11 Oct 2023 14:03:09 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C50CFDC for ; Wed, 11 Oct 2023 11:03:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697047388; x=1728583388; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=lURMbn5dRbkd2o52I5y99bEbTUmrRbrcbtygejYOJrA=; b=i6fnfctpVFCCCZfdzk11lelZ6CHnaJnaKTlMxvfkL3hqEnmjWLQZ2mER 9tJFai8VyedHeQd/yacEHz963vKj5X/bbBOgOu+dB+nWQ+jZGOWrldLB9 aXvqxSP/DWll4P7oDNzgDRVojZot8vCHgwbV+JiaxvGJmwhNJT3gpXY0A l5ZUL59EZCvsQZ55yvjnq+VZRZZ5vVYkrpN35iDBk+dwUdpkeXmDYuGId l+dp341RHWCFG+EJ1X3pjNnIepnfGPzhPcWQsfWSZvZlikOefpfq5MQV7 vjQGP9f9JgEFDlY6tPJFCP+J3Gvdb2DogQby9yxKLrmp1ZH7B78MijO6e A==; X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="6290833" X-IronPort-AV: E=Sophos;i="6.03,216,1694761200"; d="scan'208";a="6290833" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 11:02:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="927661637" X-IronPort-AV: E=Sophos;i="6.03,216,1694761200"; d="scan'208";a="927661637" Received: from unknown (HELO smile.fi.intel.com) ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 11:02:50 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC1) (envelope-from ) id 1qqdXj-00000004nnD-07AG; Wed, 11 Oct 2023 21:02:47 +0300 Date: Wed, 11 Oct 2023 21:02:46 +0300 From: Andy Shevchenko To: Alexander Potapenko Cc: catalin.marinas@arm.com, will@kernel.org, pcc@google.com, andreyknvl@gmail.com, aleksander.lobakin@intel.com, linux@rasmusvillemoes.dk, yury.norov@gmail.com, alexandru.elisei@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, eugenis@google.com, syednwaris@gmail.com, william.gray@linaro.org Subject: Re: [PATCH v7 2/5] lib/test_bitmap: add tests for bitmap_{read,write}() Message-ID: References: <20231011172836.2579017-1-glider@google.com> <20231011172836.2579017-3-glider@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231011172836.2579017-3-glider@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 11, 2023 at 07:28:32PM +0200, Alexander Potapenko wrote: > Add basic tests ensuring that values can be added at arbitrary positions > of the bitmap, including those spanning into the adjacent unsigned > longs. Would be nice to have an additional test like bitmap_write(..., 33 /* or anything > 32 */); This will require ifdeffery. So at least this code may warn users about corner cases in the agnostic code. -- With Best Regards, Andy Shevchenko