From: Alejandro Colomar <alx@kernel.org>
To: Rik van Riel <riel@surriel.com>
Cc: linux-man@vger.kernel.org, kernel-team@meta.com,
linux-kernel@vger.kernel.org,
Matthew House <mattlloydhouse@gmail.com>,
Eric Biederman <ebiederm@xmission.com>
Subject: Re: [PATCH v4] execve.2: execve also returns E2BIG if a string is too long
Date: Thu, 12 Oct 2023 01:45:15 +0200 [thread overview]
Message-ID: <ZSczi_PJ2TX8RjZs@debian> (raw)
In-Reply-To: <b99cd99fb6758ceb4cf3152c038fda761d597bb6.camel@surriel.com>
[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]
On Wed, Oct 11, 2023 at 04:53:20PM -0400, Rik van Riel wrote:
> On Wed, 2023-10-11 at 22:14 +0200, Alejandro Colomar wrote:
> > Hi Rik,
> >
> > On Wed, Oct 11, 2023 at 12:53:30PM -0400, Rik van Riel wrote:
> > > Sigh, once again I did a git commit --amend without the latest file
> > > change being
> > > included. The change below should be good. Working with both git
> > > and hg gets me sometimes :/
> > > ---8<---
> > >
> > > The execve syscall returns -E2BIG in 3 cases:
> > > - The total length of the command line arguments and environment is
> > > too large.
> > > - An argument or environment string is longer than MAX_ARG_STRLEN.
> >
> > I'm still concerned by the wording of this sentence (and the next
> > one).
> > When I (and any user-space programmer, I think) read "string is
> > longer
> > than FOO", I read `strlen(string) > FOO`. Since it's rather
> > `strlen(string) >= FOO`, I think you should clarify. How about this?
> >
> > - An argument or environment string is longer (including the null
> > byte)
> > than MAX_ARG_STRLEN.
>
> That works. Would you like me to re-send a v5, or do you
> want to massage the changelog when you apply the patch?
>
> I must admit I paid more attention to the wording in the
> man page than the wording in the changelog :)
I wouldn't mind doing it myself, but I'll ask you to resend, if you
don't mind. I usually find that doing so helps catch other accidents
that I didn't catch. :)
Cheers,
Alex
>
> --
> All Rights Reversed.
:)
--
<https://www.alejandro-colomar.es/>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-10-11 23:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 16:43 [PATCH v3] execve.2: execve also returns E2BIG if a string is too long Rik van Riel
2023-10-11 16:53 ` [PATCH v4] " Rik van Riel
2023-10-11 20:11 ` Using hg and git (Was: [PATCH v4] execve.2: execve also returns E2BIG if a string is too long) Alejandro Colomar
2023-10-11 20:14 ` [PATCH v4] execve.2: execve also returns E2BIG if a string is too long Alejandro Colomar
2023-10-11 20:53 ` Rik van Riel
2023-10-11 23:45 ` Alejandro Colomar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSczi_PJ2TX8RjZs@debian \
--to=alx@kernel.org \
--cc=ebiederm@xmission.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=mattlloydhouse@gmail.com \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.