Re: [PATCHv2 1/2] tools/build: Fix -s detection code in tools/build/Makefile.build

[Jiri Olsa <olsajiri@gmail.com>]

On Thu, Oct 12, 2023 at 08:57:33PM -0700, Namhyung Kim wrote:
> Hi Jiri,
> 
> On Sun, Oct 8, 2023 at 2:23 PM Jiri Olsa <jolsa@kernel.org> wrote:
> >
> > As Dmitry described in [1] changelog the current way of detecting
> > -s option is broken for new make.
> 
> I'm not sure what -s option does for perf (at least).
> It doesn't seem much different whether I give it or not.
> Am I missing something?

what's your make version? the wrong output is visible when running
with make version > 4.4 .. basicaly the -s is wrongly detected and
you either get no output at all from some builds or overly verbose
output

it's mentioned in the [1] commit changelog, I can put it to the
changelog in new version

jirka

> 
> Thanks,
> Namhyung
> 
> >
> > Changing the tools/build -s option detection the same way as it was
> > fixed for root Makefile in [1].
> >
> > [1] 4bf73588165b ("kbuild: Port silent mode detection to future gnu make.")
> >
> > Cc: Dmitry Goncharov <dgoncharov@users.sf.net>
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > ---
> >  tools/build/Makefile.build | 10 +++++++++-
> >  1 file changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
> > index fac42486a8cf..5fb3fb3d97e0 100644
> > --- a/tools/build/Makefile.build
> > +++ b/tools/build/Makefile.build
> > @@ -20,7 +20,15 @@ else
> >    Q=@
> >  endif
> >
> > -ifneq ($(findstring s,$(filter-out --%,$(MAKEFLAGS))),)
> > +# If the user is running make -s (silent mode), suppress echoing of commands
> > +# make-4.0 (and later) keep single letter options in the 1st word of MAKEFLAGS.
> > +ifeq ($(filter 3.%,$(MAKE_VERSION)),)
> > +short-opts := $(firstword -$(MAKEFLAGS))
> > +else
> > +short-opts := $(filter-out --%,$(MAKEFLAGS))
> > +endif
> > +
> > +ifneq ($(findstring s,$(short-opts)),)
> >    quiet=silent_
> >  endif
> >
> > --
> > 2.41.0
> >