From: Frederic Weisbecker <frederic@kernel.org>
To: Tejun Heo <tj@kernel.org>
Cc: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Juri Lelli <juri.lelli@redhat.com>,
Andrew Theurer <atheurer@redhat.com>,
Joe Mario <jmario@redhat.com>, Sebastian Jug <sejug@redhat.com>
Subject: Re: [PATCH] blk-mq: add module parameter to not run block kworker on isolated CPUs
Date: Fri, 13 Oct 2023 13:26:08 +0200 [thread overview]
Message-ID: <ZSkpUFlw8FINofLG@lothringen> (raw)
In-Reply-To: <ZSWb2DNV9cIPYv5H@slm.duckdns.org>
On Tue, Oct 10, 2023 at 08:45:44AM -1000, Tejun Heo wrote:
> > +static bool respect_cpu_isolation;
> > +module_param(respect_cpu_isolation, bool, 0444);
> > +MODULE_PARM_DESC(respect_cpu_isolation,
> > + "Don't schedule blk-mq worker on isolated CPUs passed in "
> > + "isolcpus= or nohz_full=. User need to guarantee to not run "
> > + "block IO on isolated CPUs (default: false)");
>
> Any chance we can centralize these? It's no fun to try to hunt down module
> params to opt in different subsystems and the housekeeping interface does
> have some provisions for selecting different parts. I'd much prefer to see
> these settings to be collected into a central place.
Do we need this parameter in the first place? Shouldn't we avoid scheduling
blk-mq worker on isolated CPUs in any case?
Thanks.
>
> Thanks.
>
> --
> tejun
next prev parent reply other threads:[~2023-10-13 11:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 14:22 [PATCH] blk-mq: add module parameter to not run block kworker on isolated CPUs Ming Lei
2023-10-10 18:45 ` Tejun Heo
2023-10-11 0:39 ` Ming Lei
2023-10-12 19:55 ` Tejun Heo
2023-10-13 2:01 ` Ming Lei
2023-10-13 11:26 ` Frederic Weisbecker [this message]
2023-10-13 12:23 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSkpUFlw8FINofLG@lothringen \
--to=frederic@kernel.org \
--cc=atheurer@redhat.com \
--cc=axboe@kernel.dk \
--cc=jmario@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=sejug@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.