From: Sean Christopherson <seanjc@google.com>
To: Lucy Mielke <lucymielke@icloud.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
namhyung@kernel.org, irogers@google.com,
adrian.hunter@intel.com, tglx@linutronix.de, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf/x86/p4: Fix "Wunused-but-set-variable" warning
Date: Fri, 13 Oct 2023 09:13:23 -0700 [thread overview]
Message-ID: <ZSlsowuVqQA3ecUb@google.com> (raw)
In-Reply-To: <ZSfJ6c5fo5enjvv+@fedora.fritz.box>
On Thu, Oct 12, 2023, Lucy Mielke wrote:
> Am Mon, Oct 09, 2023 at 09:29:50AM -0700 schrieb Sean Christopherson:
> >
> > rdmsr() writes to "high", but nothing ever reads from high. FWIW, I would _love_
> > for rdmsrl() to have return semantics, e.g. to be able to do:
> >
> > low = (u32)rdmsrl(MSR_IA32_MISC_ENABLE);
> >
> > or even
> >
> > if (!(rdmsrl(MSR_IA32_MISC_ENABLE) & BIT(7)))
>
> I have taken a look and it seems to me like this macro is called quite a lot
> for different things thoughout the kernel tree, including drivers. If
> one were to change it to have return semantics instead of the way it
> currently works, you'd have to change around 300 occurences, right?
Yep, which is the only reason I haven't force the issue.
prev parent reply other threads:[~2023-10-13 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-07 18:55 [PATCH] perf/x86/p4: Fix "Wunused-but-set-variable" warning Lucy Mielke
2023-10-07 20:34 ` Peter Zijlstra
2023-10-09 16:29 ` Sean Christopherson
2023-10-12 10:26 ` Lucy Mielke
2023-10-13 16:13 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSlsowuVqQA3ecUb@google.com \
--to=seanjc@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=lucymielke@icloud.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.