All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gilbert Adikankwu <gilbertadikankwu@gmail.com>
To: Andi Shyti <andi.shyti@linux.intel.com>
Cc: outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8192u: Align descendant arguments
Date: Sun, 15 Oct 2023 09:35:28 +0100	[thread overview]
Message-ID: <ZSukUAuhYLeaOy04@gilbert-PC> (raw)
In-Reply-To: <ZSuhpu97lW45BEeS@ashyti-mobl2.lan>

On Sun, Oct 15, 2023 at 10:24:06AM +0200, Andi Shyti wrote:
> Hi Gilbert,
> 
> On Sun, Oct 15, 2023 at 08:44:18AM +0100, Gilbert Adikankwu wrote:
> > Adhere to Linux kernel coding style.
> > 
> > "...A very commonly used style is to align descendants to a function
> > open parenthesis" - (Excerpted from Linux kernel coding style (#2))
> > 
> > Reported by checkpatch:
> > 
> > CHECK: Alignment should match open parenthesis
> > 
> > Signed-off-by: Gilbert Adikankwu <gilbertadikankwu@gmail.com>
> > ---
> >  drivers/staging/rtl8192u/r8180_93cx6.c     |  4 ++--
> >  drivers/staging/rtl8192u/r8190_rtl8256.c   | 16 +++++++--------
> >  drivers/staging/rtl8192u/r8192U_core.c     | 20 +++++++++---------
> >  drivers/staging/rtl8192u/r8192U_dm.c       | 24 +++++++++++-----------
> >  drivers/staging/rtl8192u/r819xU_firmware.c |  4 ++--
> >  drivers/staging/rtl8192u/r819xU_phy.c      |  2 +-
> >  6 files changed, 35 insertions(+), 35 deletions(-)
> 
> Do you mind splitting one patch per file? It's not really
> necessary, but normally easier to review.
> 
> As you are here, if you then run checkpatch on your patch you
> will gather ideas for your next patches.
> 
> Andi

Hi Andi,

Thank you for your response. If it makes the review process easier, I
don't mind splitting one patch per file. I will do as you have
suggested. Should I make it a patchset?

Gilbert

  reply	other threads:[~2023-10-15  8:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-15  7:44 [PATCH] staging: rtl8192u: Align descendant arguments Gilbert Adikankwu
2023-10-15  8:24 ` Andi Shyti
2023-10-15  8:35   ` Gilbert Adikankwu [this message]
2023-10-15  8:39     ` Andi Shyti
2023-10-15 16:09 ` Greg KH
2023-10-16  5:39 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZSukUAuhYLeaOy04@gilbert-PC \
    --to=gilbertadikankwu@gmail.com \
    --cc=andi.shyti@linux.intel.com \
    --cc=outreachy@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.