Re: [PATCH 06/11] accel/ivpu: Change test_mode module param to bitmask

[Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>]

On Mon, Oct 30, 2023 at 08:05:28AM -0600, Jeffrey Hugo wrote:
> On 10/28/2023 2:18 AM, Stanislaw Gruszka wrote:
> > On Fri, Oct 27, 2023 at 08:47:11AM -0600, Jeffrey Hugo wrote:
> > > On 10/25/2023 3:43 AM, Stanislaw Gruszka wrote:
> > > > From: Karol Wachowski <karol.wachowski@linux.intel.com>
> > > > 
> > > > Change meaning of test_mode module parameter from integer value
> > > > to bitmask allowing setting different test features with corresponding
> > > > bits.
> > > > 
> > > > Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
> > > > Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
> > > > Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
> > > 
> > > Seems like this changes the uAPI.  You still haven't made a release of the
> > > userspace, correct?
> > 
> > Yes the user space is not yet released. However I think module parameter
> > is not considered part of the linux kernel uAPI and there are no guaranties
> > regarding not changing or removing or change the semantics.
> 
> Patch 3 of [1] seems to suggest otherwise (module parameters are part of the
> uAPI)

I hope it will not be applied :-) Will be quite burden to maintain module
parameters compatibility.

Regards
Stanislaw