From: Wolfram Sang <wsa@kernel.org>
To: Jean Delvare <jdelvare@suse.de>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Wilczynski, Michal" <michal.wilczynski@intel.com>,
Andi Shyti <andi.shyti@kernel.org>, Len Brown <lenb@kernel.org>,
linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/2] i2c: i801: Use new helper acpi_use_parent_companion
Date: Sat, 28 Oct 2023 15:29:34 +0200 [thread overview]
Message-ID: <ZT0MviEHw702E2fG@shikoro> (raw)
In-Reply-To: <20231024150917.79736389@endymion.delvare>
[-- Attachment #1: Type: text/plain, Size: 788 bytes --]
> > >> I think this case is a bit too trivial for a helper, it's one line before, and
> > >> one line after, so it doesn't really save much.
>
> I must say I share Michal's skepticism.
Because Rafael likes it, I will pick it up.
> > > If this pattern is repeated in multiple places, the helper makes sense IMO.
> >
> > I didn't check each usage in detail, but this should be the places where the new
> > helper can be used.
> > Another advantage IMO is that the helper, being a function instead of a macro,
> > is type-safe.
>
> If type safety is a concern then I'd rather turn ACPI_COMPANION_SET to
> an inline function (which would make more sense than a macro anyway
> IMHO, as it has an intended side effect).
I guess this can still be done seperately?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-10-28 13:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-15 21:33 [PATCH 0/2] Add and use new helper acpi_use_parent_companion Heiner Kallweit
2023-10-15 21:34 ` [PATCH 1/2] ACPI: Add " Heiner Kallweit
2023-10-15 21:36 ` [PATCH 2/2] i2c: i801: Use new " Heiner Kallweit
2023-10-16 16:09 ` Wilczynski, Michal
2023-10-16 17:32 ` Rafael J. Wysocki
2023-10-16 20:05 ` Heiner Kallweit
2023-10-24 13:09 ` Jean Delvare
2023-10-28 13:29 ` Wolfram Sang [this message]
2023-10-24 17:34 ` Andi Shyti
2023-10-28 13:31 ` Wolfram Sang
2023-10-18 10:51 ` [PATCH 1/2] ACPI: Add " Rafael J. Wysocki
2023-10-18 12:19 ` Heiner Kallweit
2023-10-24 17:33 ` Andi Shyti
2023-10-26 17:26 ` Wolfram Sang
2023-10-26 20:17 ` Heiner Kallweit
2023-10-28 13:30 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZT0MviEHw702E2fG@shikoro \
--to=wsa@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jdelvare@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=michal.wilczynski@intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.