From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44E79CDB47E for ; Wed, 18 Oct 2023 16:34:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCACC8D0165; Wed, 18 Oct 2023 12:34:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C7AAF8D0016; Wed, 18 Oct 2023 12:34:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6ACE8D0165; Wed, 18 Oct 2023 12:34:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A71068D0016 for ; Wed, 18 Oct 2023 12:34:28 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7B7581603C7 for ; Wed, 18 Oct 2023 16:34:28 +0000 (UTC) X-FDA: 81359130216.15.DF5A4DD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id B49A4C0020 for ; Wed, 18 Oct 2023 16:34:26 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697646866; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NWf1ItjjdTeasgY3BTezBUXWu2OBeZGGK4xV7fL7bhw=; b=Uzi82Qr30tTuyzyo7O6eCrG0yGZqmQBAc6s3zfKSkirCtiFsekAuJSKXWVb0FqzFVp0TiW cGOT4xVSzrdf1zOjYx1DI1n/+UEwdH+6K5JCtDRVr3I2uHDkzAyRsSjMAPuIh3n7n+MaFw Ab6H2q40UVsbI+RXRUY/gnrproHpJX8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697646866; a=rsa-sha256; cv=none; b=ql4iatXj4zOWslAmnsKvYbk1wEnrCRHjws1012wRuqpES3l+d6ZVUu+P8EALg4dZZ5PGBG g/MsLPTQjMsfsHDLdjTkAX09gwUfWfP/NXYNFZjW+rFevv2Muup9BM27TDD+OW6lj8Cl/G M9btkJYh68Rr+4u94MaLcYCX6FCUcfU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C8175617E8; Wed, 18 Oct 2023 16:34:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F75FC433C9; Wed, 18 Oct 2023 16:34:24 +0000 (UTC) Date: Wed, 18 Oct 2023 17:34:21 +0100 From: Catalin Marinas To: Andrew Morton Cc: Liu Shixin , Patrick Wang , Kefeng Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 5/7] mm: kmemleak: use mem_pool_free() to free object Message-ID: References: <20231018102952.3339837-1-liushixin2@huawei.com> <20231018102952.3339837-6-liushixin2@huawei.com> <20231018092253.a12815afa7db9049f95fc195@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231018092253.a12815afa7db9049f95fc195@linux-foundation.org> X-Rspamd-Queue-Id: B49A4C0020 X-Rspam-User: X-Stat-Signature: jx3qz6t13fy46ytnfmb5f156fhezwyfo X-Rspamd-Server: rspam03 X-HE-Tag: 1697646866-578543 X-HE-Meta: U2FsdGVkX1/xOG8TS/zW7V/rJRyd3CZKDdvny3xM7OT7o4ILVensD69mB+Q17uHG/Sq5nGSNuLN3hO816H3nJ9A/vKy5e0VdHPwwuxxV7JQXGgoirAEKn0y3bX8K3el8Bq7mq2qdR0g0boTV5Ou1QqGEJKxwvtZgHVrTl8e0ffmxI3z5J74ED0Hn3qp8XXMvfxR4CkS5y2CiT9Q+MDcyx9tfhs5eGBfchNlfeNq0qeP+WlhOGdlzFPqFA16rpRsas3zCy2vLNSS0vM3Ms3aKCW5EdREaWgCtMZSaNTy27oBhd+XN9TMRFRer+YsTf2/uqkB6RcGG2SU4EvkegQIbcXpnis9k4brbb5CufF65oCIFKTLPpuUe2j96y/Ca1Ko07vSQBx2OmQi7xRxAmdLDMyQGhbVz1SnHTeK4nWKAN4jAz72VDIkAtagfCtYaninVcA00DQa05IHlNtfWHdCJ26T4egOIh0ryyfDByHmipzyQ/o2jmwmhv8g7U8v77cUmDG62YP+n0odhVai+BDBVsaWKWuTPj5u1rqgjRJMzDBK0qGjDsqrR3qihn5t+v2cmbaigxrW3a2cnao1KF7Iu5I6rZkKGlXIJJ/EvDv32oVgvEVcxZ1Aih9t80V/7qHHFQeHMcXvTMVSREEGIyqQoCQwgHQKYwXDtg11hr343L9Ocbv+h/nWyja6RV8hwel1xeOsz2zQDafD5rs3eQWjCy+1FRCcZq6foLzHLnupjbDrCBSdM0cNbL+xwxlgvQiXpLdp2DFD0F/5izSOtEsJhK0Fht+Hx2YHkjzkTXUkJQX0siHqKrKyRcOaiuyElWxHHbigrVIWxe3JhkiJgKCj7pOxzpu4Lh+gcm58V9EUmIYc7iUnKMX07+T8AYkAA29lhk9PfEH6Sl4HjNQ9JkIIO2nQqxy8nsuwj3KoIiRjUtHsX5/6E+GfFJzV/AgVSS3U8pYWJ3dn84MxTjDZC7yb uxf+NtJa XnHXRbwIXO2eJOBE+p8TqZ2oDueqw0XSPCXrY6wI20wM35jceKUM0HKEd+9KdMmVIo92mU05m+NTMV1uMkbxbf5f+YACSq11sfhqEdhBq46y3fEatPsosC3in9kdEnuHxOdvsirycJDh+7hRSOzxPqr/Q4DUh1qFtY1GyO8z+hLM3SYCNWPvWcwMPgUL9K3GjFmUoWnbZEx6sJBQC0dDfaj3yzI+UxfAYal+cH0S0HXCAT+iQBdLac/8Mmu4tjqlWmk/cEkeT0GdPaQOoAvnSAjnoXkLOAeDZYzHEuu7li4WnReEeY6XUpYUs+IMm4ipmNZ7R72brQ41SMzy07Wfie88YEqJE9V4Gwfxt3QNSctYiwZJpCg7aTauAnelsEz0zhBDV5E81yGLrVlpt3+iqgOkMssa+ZYxapoZoTP3IQdMLAJ4Kdn0VIJ2vV0TGZPdRhrxUKgTDNmOhdICbY1tu6svQ5BTHHq2mwkj7O7MjQ45OGA0SJrSYcSg9o/I/Tsrvx4oy0V7iglFFqw3B9ZYz94CP62UucrG0s7FDU68HFNElAbo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 18, 2023 at 09:22:53AM -0700, Andrew Morton wrote: > On Wed, 18 Oct 2023 16:57:50 +0100 Catalin Marinas wrote: > > > Could you please reorder this patch before the previous one? If you > > > added a Fixes tag, we may want a cc stable as well (as for the other > > > patches with a Fixes tag) and it makes more sense to backport it on its > > > own without the __create_object() split. Otherwise: > > > > Ah, ignore this. If we want a cc stable, the whole thing needs > > backporting, including the split which is essential for the subsequent > > fix. > > Do we want a cc:stable? That tag wasn't originally included. > > If so, all seven patches? > > If "not all seven" then can we please have two series, one for the > backport patches, one for next merge window. I think we need all 7 if we are to backport them. But we don't need to cc stable explicitly, we can send them to stable@kernel.org separately once tested on those stable versions. So, for the mm tree, don't bother with cc stable. -- Catalin