From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C84B9CDB47E for ; Wed, 18 Oct 2023 22:19:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cQqxYkltt7pEUrr9Tq64fyaiDooTIx51lDIVyokE+sY=; b=S8ifRICAC0Uu0k EhVnx/33qy0dRFllNEY20Hw7ddmr/JDOEbiqfK5owpfWVZyE7w1BwKgPj6beSvXipRbBDDZ+Jw0j7 6jCfDQLFmuHoSG9gYYxi+hdmKyDnfc0qZmAA20U8yVN7Giv6aieWFVelHuM9YdB4dQJTaPo7B/oB6 yWO2JpP86JN/KjTk0vgW/OL3QlYbRqkXQH+sr12iPepKq47YRHfJwm/iqsXVxkUNd3ToBXBNjUaap 59ivrQDHGGh4PJ1Of1L30PMscc7PDawY8mueW0QpQ7noQFy8K3ycrBHwtgg+ankgky5tUKJXyjC5p ZXUYM6WJAtVt2uAfIZxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qtEtO-00FoY4-0X; Wed, 18 Oct 2023 22:19:54 +0000 Received: from mail-qv1-xf30.google.com ([2607:f8b0:4864:20::f30]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qtEtJ-00FoX8-1u for linux-riscv@lists.infradead.org; Wed, 18 Oct 2023 22:19:52 +0000 Received: by mail-qv1-xf30.google.com with SMTP id 6a1803df08f44-66d0f945893so1462726d6.1 for ; Wed, 18 Oct 2023 15:19:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1697667587; x=1698272387; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2jRC9HVva9g3R+13NnFT9VqaHyccZUivRNg5/IFJX6s=; b=wVBa4NX7ZjtD4a2vDsfCzCA+b5XcfQfCkDnAlmOEXWlWRRO8IZw0T+ivYQCkqihQpW vEx2UfVT23aju1EZERZi2irgozlAIoSGSGBqUxEJQ44tEClYQA6ftr0a4cWhFHYTPKHK 3EO0q6+vSZmlhostsXm+fCml5PmUMJGxSGSDU1pgzCpE6bfCaJFhIAOe7H7bzYy2urGa Q99zotcSkVXWsQqycm7l8AFk67CohaUrp4XH0g5FgfufQAbgUn+uP4LK4d2LgRKFR4S2 hNHK8JhznJKEzea7Vz1FRKVtyk14JOuKRQVDzrVsTYIulZDPaxhj5fhX6H5DD+DmCCyZ uidA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697667587; x=1698272387; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2jRC9HVva9g3R+13NnFT9VqaHyccZUivRNg5/IFJX6s=; b=X9NccXtSOSWQi2K0y3OiXYi6aNFwCInxQKriXUb1u2UNZ8PE6qDWGgvtwdpuEC5Zmc YhrJ+ES0PJVkXhP+ek3Tv/T2DeLDqcABF7eW18V1ACQLCpFj3f6GzSsuEC3bXTCwHH+9 IspOijTTYHGal1qShWaP198byw+HdurB2sr3d7qwOvfwGvDJN6FB3VgmcofiKrkbG3zg gbQJjwV9oiFt1SDB4khmlO+BoBeBQHi2eVNOSND5RWjVVEUuMGJXO6cx7XTDQSMcu1B7 vD6KTjPXULx4dRlBwvU6cEE//i9ebpRNABOqo1e+njYi0W40Z3MPMx7u6gsZ3vX/sJ4x OdzA== X-Gm-Message-State: AOJu0YzljJBNuq8+vflcBd1GnTQ9oyqrwUEdxiXpNVxuuWzEOedmF/Ee cSu2bw5e5lCQ0fXZh+ZBSBotXw== X-Google-Smtp-Source: AGHT+IEEmnCxAAe9vHxUiqgxlAvnjdO1EUng0/cO66uNrmeaXVf9bLQ/iB2o960SVloWr87MMFxH8Q== X-Received: by 2002:a0c:dd92:0:b0:65b:12bb:56cb with SMTP id v18-20020a0cdd92000000b0065b12bb56cbmr319625qvk.12.1697667587161; Wed, 18 Oct 2023 15:19:47 -0700 (PDT) Received: from ghost ([208.116.208.98]) by smtp.gmail.com with ESMTPSA id da12-20020a05621408cc00b0064c9f754794sm280752qvb.86.2023.10.18.15.19.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 15:19:46 -0700 (PDT) Date: Wed, 18 Oct 2023 15:19:43 -0700 From: Charlie Jenkins To: Andreas Schwab Cc: linux-riscv@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Eric Biederman , Kees Cook , Paul Walmsley , Palmer Dabbelt , Albert Ou Subject: Re: [PATCH v4 1/2] riscv: Add remaining module relocations Message-ID: References: <20231017-module_relocations-v4-0-937f5ef316f0@rivosinc.com> <20231017-module_relocations-v4-1-937f5ef316f0@rivosinc.com> <871qdr938h.fsf@igel.home> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <871qdr938h.fsf@igel.home> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231018_151949_631717_9A2C8B4D X-CRM114-Status: GOOD ( 10.49 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Oct 18, 2023 at 08:47:58PM +0200, Andreas Schwab wrote: > On Okt 17 2023, Charlie Jenkins wrote: > > > +static int apply_r_riscv_sub6_rela(struct module *me, u32 *location, Elf_Addr v) > > +{ > > + *(u8 *)location = (*location - ((u8)v & 0x3F)) & 0x3F; > > I think that should use *(u8*) on both sides. Yep, thank you. - Charlie > > -- > Andreas Schwab, schwab@linux-m68k.org > GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 > "And now for something completely different." _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7631CDB47E for ; Wed, 18 Oct 2023 22:19:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 352FA8D0170; Wed, 18 Oct 2023 18:19:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 303618D0016; Wed, 18 Oct 2023 18:19:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D5F48D0170; Wed, 18 Oct 2023 18:19:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0A4DE8D0016 for ; Wed, 18 Oct 2023 18:19:50 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CC4331A02A2 for ; Wed, 18 Oct 2023 22:19:49 +0000 (UTC) X-FDA: 81360000498.30.6696CB3 Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) by imf24.hostedemail.com (Postfix) with ESMTP id 0D8AB180023 for ; Wed, 18 Oct 2023 22:19:47 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=EgT5Y0Gd; spf=pass (imf24.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.219.45 as permitted sender) smtp.mailfrom=charlie@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697667588; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2jRC9HVva9g3R+13NnFT9VqaHyccZUivRNg5/IFJX6s=; b=BHe+ffk7VdaKDkrfWknepZ8Kq8wV3zk1322mVshUxc3r5GjR2RDuqmj/NBeV8Jgzpz3IAv CsB4JZfzPq3UkwXkSwgwD48UEdOKeIXG4Om1GXuT8xWIp8Fcmpja4slzvlc7p2kMHgBaua 56G7MN4GwIBgX7ndMDfC8veKAyHRm3Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697667588; a=rsa-sha256; cv=none; b=ST8lVMArIGfQpgnjsxnV+FI2VIvooX3102QMFOD28RSduGUlVHi4emq2Sy7jqrMJEnDE0u pErHiWajFH44xrqxiq2Q9nYBoAHJRzsbalPVTuyh/SK5RbbPuJJsnk6hn7qdb59Y/AdKyt MFkkRz2izVLJ/pA1/M+hla4NYc3pmeE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=EgT5Y0Gd; spf=pass (imf24.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.219.45 as permitted sender) smtp.mailfrom=charlie@rivosinc.com; dmarc=none Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-66d0760cd20so1558576d6.0 for ; Wed, 18 Oct 2023 15:19:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1697667587; x=1698272387; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2jRC9HVva9g3R+13NnFT9VqaHyccZUivRNg5/IFJX6s=; b=EgT5Y0Gdv8dsMI8ngAsbO2gfkMFYlnOkNAel3BW0S1eWKjow58fU5ejuVWM1scrDV7 K19WoUhrZRrgoz2WUTPeLb6ANy87qspgiJ7GYyuOjrWiiFCrwiBNQsXzrymqlUh6V/Ky nNrBl3EWN1fZYw6bKPqIhJjbDHzmTOIO8pP2wr6N3pajvSTZIlBpsNCoxFzZP5gAhPmV IshZHqaUAtJVx0Vrbdw58Gjv/UbfkzoyVF+MtBUyxRtKRaI8mcS5dVYmVfwgyJKw38/B WCZwS5q+uJXsTZOcqPy5H3T61UvKhDP4lfq9Y/Niei67YE1dkzxnbPEFNbI1QKKc0NCI tQvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697667587; x=1698272387; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2jRC9HVva9g3R+13NnFT9VqaHyccZUivRNg5/IFJX6s=; b=tC5GUpnFvagDyYHfCqxBd7OfD7ZgpNKv0AZi/F4cr9rgmWWOgbnxtMctzUqwGq+IoM hQBY0/DM64lrDqI6oYK5HWRMFkSBqCQf68mmg8o8HG62WZOXKGhXOHqa1SfmEORq6Ruq 7VBfQwjGvAhSPw+MEBem9sZDYqTTEJn0b8GjzScHkX7VN+ehhMTQLIEhzbsjIYf+ZTJ6 RoAfFMGZaa4TVZvUOPCu8H/BLyBfti7H2VKmWVqTsxxUraBJk9fb7SNxSHd6x6FopFyl lupsMsznzr3H5Etulk7PFmHCRnSNvPCUFWsFd1sVmtRDEMH9YYH8i+bt+dPzoddH/3n/ AmfA== X-Gm-Message-State: AOJu0YzEHLDpTfouePX2wUGjK6zyljoaqVjB1MO4WEPHsmFUlS3j5Xud WcZ9v5YxW2JIdwxbnWbLNwZKRw== X-Google-Smtp-Source: AGHT+IEEmnCxAAe9vHxUiqgxlAvnjdO1EUng0/cO66uNrmeaXVf9bLQ/iB2o960SVloWr87MMFxH8Q== X-Received: by 2002:a0c:dd92:0:b0:65b:12bb:56cb with SMTP id v18-20020a0cdd92000000b0065b12bb56cbmr319625qvk.12.1697667587161; Wed, 18 Oct 2023 15:19:47 -0700 (PDT) Received: from ghost ([208.116.208.98]) by smtp.gmail.com with ESMTPSA id da12-20020a05621408cc00b0064c9f754794sm280752qvb.86.2023.10.18.15.19.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 15:19:46 -0700 (PDT) Date: Wed, 18 Oct 2023 15:19:43 -0700 From: Charlie Jenkins To: Andreas Schwab Cc: linux-riscv@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Eric Biederman , Kees Cook , Paul Walmsley , Palmer Dabbelt , Albert Ou Subject: Re: [PATCH v4 1/2] riscv: Add remaining module relocations Message-ID: References: <20231017-module_relocations-v4-0-937f5ef316f0@rivosinc.com> <20231017-module_relocations-v4-1-937f5ef316f0@rivosinc.com> <871qdr938h.fsf@igel.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871qdr938h.fsf@igel.home> X-Stat-Signature: k5sodd6nwszko749i693fttcpkzbg6es X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0D8AB180023 X-Rspam-User: X-HE-Tag: 1697667587-230177 X-HE-Meta: U2FsdGVkX1+tESlOdFGoNDUeZq+ctS0IkIBkK/fw4jzBCVh9eZ7oQhEmdat4HuiY5Cki02n9jsRzVop3+2dGNEuOefHDvqx3UijGvgxoIVIYBQxF7/iw00XLNiT4NfYIzRvrufTL3RroUH0Ihru0FtN3RTbbugdhcqIp8yt6XXyYDYPwr9AHjyzbVQKaBbIwx21rUkcUmj8/24g2IUljY8+Z5c+UGiVsX79h9qRlHt3x90ySVvTtEUN5r4GLtc3zr6RwoBMXzXcf+Od5Fwv2iH5MzfpxQXi3UYcSUOWoBhWyJXq91fJArH2hqgLdtGkw0ezAsJJwgzpOdgFBW5699VuD8EZYZH1p5robgkBeI++zllHtHRxCvuIqP2FTp2JoaDK6dph6twu1D7WDASYpuNIErTv6qIdCdY5hfXKLKtlhixgfR/4vj4v29hWeN6LdCAaK0EJjU+jYGWbJi+Y378fCKGAfitziaKembMq6Z4DTKHxS2APcDV3tj+PYv/LytySPMRHhwZuuRQAb5jJQrNQx7pip3ANc4qnz0bpZH5v2NO3Yb98M35pntV2kNbw9Vq12NEDKyaS+EfTe9bAKBtGJNfV2+H48nzYsKwSDr+b/H+5PGslAsr7a/LRdqqOLrW8bGleBaAQXig6axndJbOxTQ2Hh6j5xEv8N5BthatX0KkH+VYZbPDpUE2zIOD+BNT3NdRyKnVdMDMxbdso11MUL6P2gDx9CrAyAXYQrE6JVKqM6HWvcyQaUe+snfa0t3kJ1W/ewyN00xgX/ilMmkTB8crPoWJk2lfo2G5M2MQcBO8EBTdEUCn7NlWAmoKZSBqwgarcCHTwt2nmMUSQ70E68fV3uV5p5qrlgepDrjxmAWTR5vTX2uRveLecklEHWKwS56At3X9zJjqexnMBLRl5YHGK9sX0E5qNnNnJOZ7nJhr6fbUA9PiDv/WPb2ScpdnfBblfzZ9d/dLd7yoY GkUNvDkm 1LRmgAI6y6dnMSO6MN0wmGJmbXmV8be3YpLznOXq3lzqXQYclM2wYxhGKZin37Ef2LjzJLcSp/uBDEQTwaP45pF8PSflNEOudWueASumeX3LM2rGV0HrFjUFvRkN4V2xT3RAuFWzmWj2zts7c5gBHMBrA75VqHr74Qb+t3nudXYHWTXpOINYzvxYnD3ImuwYg7Ud4fO4kVsyhK/xxiSdksLlJTiODQn7CgiPwTlXHwAbdkKTIEhF5kIBavc3qso/pwHkBE2IoTj7aMpQHtrlDomS1amAxTskFOA1CzaZLkatY7hktqGtU42RiTC4RnkXIaD1wSQvMjuBwJ+vVSll+3q4ZfsWc23cGmVxjTx0lYX5mLl214UjiaEjwvB6jfR2Wil0NOrXWixUULBtvlKi9Nu0kF70Vs9F33ecpToIwnnFqCObDpcTCDrY1fcV7rwjmAMstUGU+MjKG03o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.043258, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 18, 2023 at 08:47:58PM +0200, Andreas Schwab wrote: > On Okt 17 2023, Charlie Jenkins wrote: > > > +static int apply_r_riscv_sub6_rela(struct module *me, u32 *location, Elf_Addr v) > > +{ > > + *(u8 *)location = (*location - ((u8)v & 0x3F)) & 0x3F; > > I think that should use *(u8*) on both sides. Yep, thank you. - Charlie > > -- > Andreas Schwab, schwab@linux-m68k.org > GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 > "And now for something completely different."