All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Yuan Liu <yuan1.liu@intel.com>
Cc: quintela@redhat.com, farosas@suse.de, leobras@redhat.com,
	qemu-devel@nongnu.org, nanhai.zou@intel.com
Subject: Re: [PATCH 2/5] qapi/migration: Introduce compress-with-iaa migration parameter
Date: Thu, 19 Oct 2023 10:02:32 -0400	[thread overview]
Message-ID: <ZTE2+Cj2WypqeC5x@x1n> (raw)
In-Reply-To: <20231018221224.599065-3-yuan1.liu@intel.com>

On Thu, Oct 19, 2023 at 06:12:21AM +0800, Yuan Liu wrote:
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 8843e74b59..8edc622dd9 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -835,7 +835,7 @@
>  { 'enum': 'MigrationParameter',
>    'data': ['announce-initial', 'announce-max',
>             'announce-rounds', 'announce-step',
> -           'compress-level', 'compress-threads', 'decompress-threads',
> +           'compress-level', 'compress-threads', 'compress-with-iaa', 'decompress-threads',
>             'compress-wait-thread', 'throttle-trigger-threshold',
>             'cpu-throttle-initial', 'cpu-throttle-increment',
>             'cpu-throttle-tailslow',
> @@ -1008,6 +1008,7 @@
>              '*announce-step': 'size',
>              '*compress-level': 'uint8',
>              '*compress-threads': 'uint8',
> +            '*compress-with-iaa': 'bool',
>              '*compress-wait-thread': 'bool',
>              '*decompress-threads': 'uint8',
>              '*throttle-trigger-threshold': 'uint8',
> @@ -1208,6 +1209,7 @@
>              '*announce-step': 'size',
>              '*compress-level': 'uint8',
>              '*compress-threads': 'uint8',
> +            '*compress-with-iaa': 'bool',
>              '*compress-wait-thread': 'bool',
>              '*decompress-threads': 'uint8',
>              '*throttle-trigger-threshold': 'uint8',

Please add comments for the new fields too in qapi/, thanks.

-- 
Peter Xu



  parent reply	other threads:[~2023-10-19 14:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18 22:12 [PATCH 0/5] Live Migration Acceleration with IAA Compression Yuan Liu
2023-10-18 22:12 ` [PATCH 1/5] configure: add qpl meson option Yuan Liu
2023-10-19 11:12   ` Juan Quintela
2023-10-18 22:12 ` [PATCH 2/5] qapi/migration: Introduce compress-with-iaa migration parameter Yuan Liu
2023-10-19 11:15   ` Juan Quintela
2023-10-19 14:02   ` Peter Xu [this message]
2023-10-18 22:12 ` [PATCH 3/5] ram compress: Refactor ram compression functions Yuan Liu
2023-10-19 11:19   ` Juan Quintela
2023-10-18 22:12 ` [PATCH 4/5] migration iaa-compress: Add IAA initialization and deinitialization Yuan Liu
2023-10-19 11:27   ` Juan Quintela
2023-10-18 22:12 ` [PATCH 5/5] migration iaa-compress: Implement IAA compression Yuan Liu
2023-10-19 11:36   ` Juan Quintela
2023-10-19 11:13 ` [PATCH 0/5] Live Migration Acceleration with IAA Compression Juan Quintela
2023-10-19 11:40 ` Juan Quintela
2023-10-19 14:52   ` Daniel P. Berrangé
2023-10-19 15:23     ` Peter Xu
2023-10-19 15:31       ` Juan Quintela
2023-10-19 15:32       ` Daniel P. Berrangé
2023-10-23  8:33         ` Liu, Yuan1
2023-10-23 10:29           ` Daniel P. Berrangé
2023-10-23 10:47             ` Juan Quintela
2023-10-23 14:54               ` Liu, Yuan1
2023-10-23 14:36             ` Liu, Yuan1
2023-10-23 10:38           ` Juan Quintela
2023-10-23 16:32             ` Liu, Yuan1

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZTE2+Cj2WypqeC5x@x1n \
    --to=peterx@redhat.com \
    --cc=farosas@suse.de \
    --cc=leobras@redhat.com \
    --cc=nanhai.zou@intel.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=yuan1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.