From: Alejandro Colomar <alx@kernel.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: kernel@collabora.com, linux-man@vger.kernel.org
Subject: Re: [PATCH 2/2] ioctl_pagemap_scan: add page for pagemap_scan IOCTL
Date: Thu, 19 Oct 2023 14:51:04 +0200 [thread overview]
Message-ID: <ZTEmONWZRiqCVRyx@debian> (raw)
In-Reply-To: <aae0ba48-7919-4656-8fe0-731ccd79ff95@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]
Hi Muhammad,
On Thu, Oct 19, 2023 at 05:31:32PM +0500, Muhammad Usama Anjum wrote:
> Hi Alex,
>
> Thank you for taking time to review. I'll fix everything and run lint
> before sending next revision.
Thanks.
[...]
> >> +.SH DESCRIPTION
> >> +This
> >> +.BR ioctl (2)
> >> +is used to get and optionally clear some specific flags from page table entries.
> >> +
> >
> > Please use an empty roff(7) request instead of a empty input line. That
> > is, use a line with just a '.', that is, s/^$/./
Another thing you can use is a comment:
.\"
This is more commonly found in other pages in this repository.
Cheers,
Alex
> >
> > $ make lint build check --debug=print
> > TROFF .tmp/man/man2/ioctl_pagemap_scan.2.cat.set
> > ! (troff -wbreak -man -Tutf8 -rLL=78n -rCHECKSTYLE=3 -ww <.tmp/man/man2/ioctl_pagemap_scan.2.cat.troff 2>&1 >.tmp/man/man2/ioctl_pagemap_scan.2.cat.set \
> > | grep -v -f './share/lint/groff/man.ignore.grep' \
> > ||:; \
> > ) \
> > | grep ^ >&2
> > an.tmac:man2/ioctl_pagemap_scan.2:25: style: blank line in input
> > ...
--
<https://www.alejandro-colomar.es/>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-10-19 12:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 15:01 [PATCH 1/2] ioctl_userfaultfd.2: add UFFD_FEATURE_WP_ASYNC Muhammad Usama Anjum
2023-10-17 15:01 ` [PATCH 2/2] ioctl_pagemap_scan: add page for pagemap_scan IOCTL Muhammad Usama Anjum
2023-10-17 17:12 ` Alejandro Colomar
2023-10-19 12:31 ` Muhammad Usama Anjum
2023-10-19 12:51 ` Alejandro Colomar [this message]
2023-10-17 16:41 ` [PATCH 1/2] ioctl_userfaultfd.2: add UFFD_FEATURE_WP_ASYNC Alejandro Colomar
2023-10-19 7:26 ` Muhammad Usama Anjum
-- strict thread matches above, loose matches on Subject: below --
2023-10-19 13:12 Muhammad Usama Anjum
2023-10-19 13:12 ` [PATCH 2/2] ioctl_pagemap_scan: add page for pagemap_scan IOCTL Muhammad Usama Anjum
2023-10-23 21:52 ` Alejandro Colomar
2023-10-24 2:48 ` G. Branden Robinson
2023-10-24 10:40 ` Alejandro Colomar
2023-10-24 15:51 ` Muhammad Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTEmONWZRiqCVRyx@debian \
--to=alx@kernel.org \
--cc=kernel@collabora.com \
--cc=linux-man@vger.kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.