From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85628C001DF for ; Fri, 20 Oct 2023 12:59:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtp5J-0002vv-UJ; Fri, 20 Oct 2023 08:58:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtjXY-000356-TT; Fri, 20 Oct 2023 03:03:24 -0400 Received: from mgamail.intel.com ([192.55.52.120]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtjXW-0006fG-BG; Fri, 20 Oct 2023 03:03:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697785402; x=1729321402; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=t0rX0WxvHEJ7FYnmEat7uxzYY2OROsQ0gZ+kw97Wi5w=; b=JJ9g8ZJCp6EEWM6T44kBbP90lKxlOmiKCs5ZoxEiJvNb4O6c57JczQxd w7Hjkm/ZrcAOGGkjyfRNhxJXkEe0u4/bDEjIZssox+xg7ZpYosHCYGw1S vX/oT7nH2pQqZgig6EDhnscPSOnGrkSzL0PSfMCuMnBkFA5Lh6z/boMqO nb/kyOMX/uZaXXiPo35lYM5IX45TZQU4/lP5JoSSmYkXFiZB+SFX4SlEU mFjUJPPKmmHkeM+A91iIfBmwA+jLmnEiE1fvkMZITzQlwNQ43zxgtYwGB akyQhvezd4ByzbTm9u5Z4ZBg/B4x/M4P20eflH9ErFokKqT19LbnWsKP8 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="385319678" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="385319678" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2023 00:03:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="5292990" Received: from liuzhao-optiplex-7080.sh.intel.com (HELO localhost) ([10.239.160.36]) by fmviesa001.fm.intel.com with ESMTP; 20 Oct 2023 00:03:04 -0700 Date: Fri, 20 Oct 2023 15:14:40 +0800 From: Zhao Liu To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, Eduardo Habkost , Xiaojuan Yang , "Michael S. Tsirkin" , qemu-ppc@nongnu.org, Aleksandar Rikalo , David Hildenbrand , qemu-s390x@nongnu.org, "Edgar E. Iglesias" , Jiaxun Yang , Song Gao , Paolo Bonzini , Stafford Horne , Alistair Francis , Yanan Wang , Max Filippov , Artyom Tarasenko , Marcel Apfelbaum , =?iso-8859-1?Q?C=E9dric?= Le Goater , Laurent Vivier , Aurelien Jarno , qemu-riscv@nongnu.org, Palmer Dabbelt , Yoshinori Sato , Bastian Koppelmann , Bin Meng , Daniel Henrique Barboza , Mark Cave-Ayland , Weiwei Li , Daniel Henrique Barboza , Nicholas Piggin , qemu-arm@nongnu.org, Liu Zhiwei , Marek Vasut , Laurent Vivier , Peter Maydell , Brian Cain , Thomas Huth , Chris Wulff , Sergio Lopez , Richard Henderson , Ilya Leoshkevich , Michael Rolnik Subject: Re: [PATCH v2 02/16] target: Mention 'cpu-qom.h' is target agnostic Message-ID: References: <20231013140116.255-1-philmd@linaro.org> <20231013140116.255-3-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231013140116.255-3-philmd@linaro.org> Received-SPF: pass client-ip=192.55.52.120; envelope-from=zhao1.liu@intel.com; helo=mgamail.intel.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 20 Oct 2023 08:58:30 -0400 X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Hi Philippe, On Fri, Oct 13, 2023 at 04:01:01PM +0200, Philippe Mathieu-Daudé wrote: > Date: Fri, 13 Oct 2023 16:01:01 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH v2 02/16] target: Mention 'cpu-qom.h' is target agnostic > X-Mailer: git-send-email 2.41.0 > > "target/foo/cpu-qom.h" is supposed to be target agnostic > (include-able by any target). Add such mention in the > header. > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Richard Henderson > --- > target/arm/cpu-qom.h | 2 +- > target/hppa/cpu-qom.h | 2 +- > target/microblaze/cpu-qom.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) Why not mention this description for other qom-cpu.h in this series, e.g., target/i386/cpu-qom.h. Otherwise, Reviewed-by: Zhao Liu > > diff --git a/target/arm/cpu-qom.h b/target/arm/cpu-qom.h > index 153865d1bb..dfb9d5b827 100644 > --- a/target/arm/cpu-qom.h > +++ b/target/arm/cpu-qom.h > @@ -1,5 +1,5 @@ > /* > - * QEMU ARM CPU > + * QEMU ARM CPU QOM header (target agnostic) > * > * Copyright (c) 2012 SUSE LINUX Products GmbH > * > diff --git a/target/hppa/cpu-qom.h b/target/hppa/cpu-qom.h > index 67f12422c4..4b1d48f7ca 100644 > --- a/target/hppa/cpu-qom.h > +++ b/target/hppa/cpu-qom.h > @@ -1,5 +1,5 @@ > /* > - * QEMU HPPA CPU > + * QEMU HPPA CPU QOM header (target agnostic) > * > * Copyright (c) 2016 Richard Henderson > * > diff --git a/target/microblaze/cpu-qom.h b/target/microblaze/cpu-qom.h > index 2a734e644d..78f549b57d 100644 > --- a/target/microblaze/cpu-qom.h > +++ b/target/microblaze/cpu-qom.h > @@ -1,5 +1,5 @@ > /* > - * QEMU MicroBlaze CPU > + * QEMU MicroBlaze CPU QOM header (target agnostic) > * > * Copyright (c) 2012 SUSE LINUX Products GmbH > * > -- > 2.41.0 > > >