From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 2DD9760758 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 7348460672 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697801896; x=1729337896; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=JePTitzuY0GQtcJN+j6l1yJWlx9JL0zZgTWlbLVx8N8=; b=nupC0tlijozd+DTfO72h2e9ZcrXW7s58OzbIafGY8fYMPECWeUDibOJo kNUUKlWynucxJTQC2tQvyzxOPMklW17KaVnWbc69TIZOym55gXV/Oj5La V/kWB+Vb9vrRBoPyTFHW1TsAqxHVMm3DJpfveMwZufHPEXSnP2pZtW7bG wIbaoLYaaOkBnorxXPJJD0nzrq1XjeVbdoeOel6K81jdJuVteBz8qjzKW hHAg8p08UF+OMErL/HNDCztJpj2y60X6GBd+hBYk6ybhQGvqmkQNCBG4x tPDUEoK3bPdNk2evxl9x+n9qmxwsbDCwS6LNYiz7OLTPVNdco0ICAa4H2 g==; Date: Fri, 20 Oct 2023 14:38:06 +0300 From: Raag Jadav Message-ID: References: <20231020084732.17130-1-raag.jadav@intel.com> <20231020084732.17130-5-raag.jadav@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Acpica-devel] [PATCH v1 4/8] ACPI: utils: use acpi_dev_uid_match() for matching _UID List-Id: "This is the central place for ACPICA developer discussions and issues." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andy Shevchenko Cc: mark.rutland@arm.com, len.brown@intel.com, will@kernel.org, linux-gpio@vger.kernel.org, mallikarjunappa.sangannavar@intel.com, robert.moore@intel.com, bala.senthil@intel.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, acpica-devel@lists.linuxfoundation.org, linux-hwmon@vger.kernel.org, mika.westerberg@linux.intel.com, linux@roeck-us.net On Fri, Oct 20, 2023 at 01:36:27PM +0300, Andy Shevchenko wrote: > On Fri, Oct 20, 2023 at 02:17:28PM +0530, Raag Jadav wrote: > > Convert manual _UID references to use standard ACPI helpers. > > Yes, while not so obvious this is the correct replacement. > Reviewed-by: Andy Shevchenko I think this is the only case which would suffer from the more obvious behaviour, i.e. bool acpi_dev_uid_match(struct acpi_device *adev, const char *uid2) { const char *uid1 = acpi_device_uid(adev); return uid1 && uid2 && !strcmp(uid1, uid2); } That said, we can't be particularly sure about it's potential future users, especially when the usage will not be limited to just ACPI core since we're exporting it. Raag From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72CC619440 for ; Fri, 20 Oct 2023 11:38:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Ksik9nfI" Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29A41213E; Fri, 20 Oct 2023 04:38:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697801897; x=1729337897; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=JePTitzuY0GQtcJN+j6l1yJWlx9JL0zZgTWlbLVx8N8=; b=Ksik9nfIDemqOWvDHAgyjBxp1T2qeJmtINxn/8gEWfZfd7LrdZ5WQqFB g0dN9j/J8IPgoGqzwiQYN7yk/Lr9rDnCHwtfixSU4toI5ZDEfFg3TrE9P lbhTWMZ7V8B2xrU7eGqkNsf1WxREJdeorInhHrgGveMDQftUF4eosUDgL To/mjGOr5S/3koG/YpYXG7FbM14yOimSrMVOOrT/6UOu605+XSru7p76+ tKPgvJaWppYxDuPqzBTVfJmcRdO2L+xqjFXypeONYjjWjcNlztYQmRlYf lMHCkYMaA1Y83xuNyFDPOE9GyUp1BC4vKYrwD3kd/BO2dBi8Y75os2N5J Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="450707539" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="450707539" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2023 04:38:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="901121259" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="901121259" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2023 04:35:59 -0700 Date: Fri, 20 Oct 2023 14:38:06 +0300 From: Raag Jadav To: Andy Shevchenko Cc: rafael@kernel.org, len.brown@intel.com, robert.moore@intel.com, mika.westerberg@linux.intel.com, mark.rutland@arm.com, will@kernel.org, linux@roeck-us.net, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com Subject: Re: [PATCH v1 4/8] ACPI: utils: use acpi_dev_uid_match() for matching _UID Message-ID: References: <20231020084732.17130-1-raag.jadav@intel.com> <20231020084732.17130-5-raag.jadav@intel.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Oct 20, 2023 at 01:36:27PM +0300, Andy Shevchenko wrote: > On Fri, Oct 20, 2023 at 02:17:28PM +0530, Raag Jadav wrote: > > Convert manual _UID references to use standard ACPI helpers. > > Yes, while not so obvious this is the correct replacement. > Reviewed-by: Andy Shevchenko I think this is the only case which would suffer from the more obvious behaviour, i.e. bool acpi_dev_uid_match(struct acpi_device *adev, const char *uid2) { const char *uid1 = acpi_device_uid(adev); return uid1 && uid2 && !strcmp(uid1, uid2); } That said, we can't be particularly sure about it's potential future users, especially when the usage will not be limited to just ACPI core since we're exporting it. Raag From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B99FCCDB47E for ; Fri, 20 Oct 2023 11:38:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Cfe5NgW19Nf18HLbfZSn++2TSOtvgTw+IGs4+SzReKA=; b=N3IuvUh0YQHMPk MIG5YpOqNfvtfwiBFxs7hTn4QX6c+D3NmSFFk9kc8a5SBUsM2+MqiIXh+Z6FNHJlTgfXO+nHIk3Y4 ipKUBAztdIU6Dd8FriLsk3s3eAu/qaW4F222qGm7NatuElQgntsoVqwdQIEJdunhg4TMgWQB3MMb5 TQ1gn8uK9WU3bO4hYM2qSG0ZSb77eQa3qcBPhmEGt3mfzAEQc/zgxKKZ+d0u7drA7oFbG9vZjPgfh 80KqwTefo8apW6dROIil8vWLHAH5nh6Z04Emzm9RTa2W/p7Mo8T9/hdzuKPc6YZOIicte0uS3D1kI USsgRwBIZqW/UGUpbgbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qtnpc-002A0H-0M; Fri, 20 Oct 2023 11:38:20 +0000 Received: from mgamail.intel.com ([134.134.136.31]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qtnpZ-0029yt-0H for linux-arm-kernel@lists.infradead.org; Fri, 20 Oct 2023 11:38:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697801897; x=1729337897; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=JePTitzuY0GQtcJN+j6l1yJWlx9JL0zZgTWlbLVx8N8=; b=Ksik9nfIDemqOWvDHAgyjBxp1T2qeJmtINxn/8gEWfZfd7LrdZ5WQqFB g0dN9j/J8IPgoGqzwiQYN7yk/Lr9rDnCHwtfixSU4toI5ZDEfFg3TrE9P lbhTWMZ7V8B2xrU7eGqkNsf1WxREJdeorInhHrgGveMDQftUF4eosUDgL To/mjGOr5S/3koG/YpYXG7FbM14yOimSrMVOOrT/6UOu605+XSru7p76+ tKPgvJaWppYxDuPqzBTVfJmcRdO2L+xqjFXypeONYjjWjcNlztYQmRlYf lMHCkYMaA1Y83xuNyFDPOE9GyUp1BC4vKYrwD3kd/BO2dBi8Y75os2N5J Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="450707536" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="450707536" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2023 04:38:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="901121259" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="901121259" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2023 04:35:59 -0700 Date: Fri, 20 Oct 2023 14:38:06 +0300 From: Raag Jadav To: Andy Shevchenko Cc: rafael@kernel.org, len.brown@intel.com, robert.moore@intel.com, mika.westerberg@linux.intel.com, mark.rutland@arm.com, will@kernel.org, linux@roeck-us.net, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com Subject: Re: [PATCH v1 4/8] ACPI: utils: use acpi_dev_uid_match() for matching _UID Message-ID: References: <20231020084732.17130-1-raag.jadav@intel.com> <20231020084732.17130-5-raag.jadav@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231020_043817_166407_82A63200 X-CRM114-Status: GOOD ( 10.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 20, 2023 at 01:36:27PM +0300, Andy Shevchenko wrote: > On Fri, Oct 20, 2023 at 02:17:28PM +0530, Raag Jadav wrote: > > Convert manual _UID references to use standard ACPI helpers. > > Yes, while not so obvious this is the correct replacement. > Reviewed-by: Andy Shevchenko I think this is the only case which would suffer from the more obvious behaviour, i.e. bool acpi_dev_uid_match(struct acpi_device *adev, const char *uid2) { const char *uid1 = acpi_device_uid(adev); return uid1 && uid2 && !strcmp(uid1, uid2); } That said, we can't be particularly sure about it's potential future users, especially when the usage will not be limited to just ACPI core since we're exporting it. Raag _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel