From: David Matlack <dmatlack@google.com>
To: Sean Christopherson <seanjc@google.com>
Cc: stable@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Pattara Teerapong <pteerapong@google.com>,
David Stevens <stevensd@google.com>,
Yiwei Zhang <zzyiwei@google.com>, Paul Hsia <paulhsia@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] KVM: x86/mmu: Stop zapping invalidated TDP MMU roots asynchronously
Date: Fri, 20 Oct 2023 11:52:34 -0700 [thread overview]
Message-ID: <ZTLMcmj-ycWhZuTX@google.com> (raw)
In-Reply-To: <20231019201138.2076865-1-seanjc@google.com>
On 2023-10-19 01:11 PM, Sean Christopherson wrote:
> [ Upstream commit 0df9dab891ff0d9b646d82e4fe038229e4c02451 ]
>
> Stop zapping invalidate TDP MMU roots via work queue now that KVM
> preserves TDP MMU roots until they are explicitly invalidated. Zapping
> roots asynchronously was effectively a workaround to avoid stalling a vCPU
> for an extended during if a vCPU unloaded a root, which at the time
> happened whenever the guest toggled CR0.WP (a frequent operation for some
> guest kernels).
>
[...]
>
> Reported-by: Pattara Teerapong <pteerapong@google.com>
> Cc: David Stevens <stevensd@google.com>
> Cc: Yiwei Zhang<zzyiwei@google.com>
> Cc: Paul Hsia <paulhsia@google.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> Message-Id: <20230916003916.2545000-4-seanjc@google.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Cc: David Matlack <dmatlack@google.com>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
Reviewed-by: David Matlack <dmatlack@google.com>
Tested-by: David Matlack <dmatlack@google.com>
(Ran all KVM selftests and kvm-unit-tests with lockdep enabled.)
next prev parent reply other threads:[~2023-10-20 18:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 20:11 [PATCH] KVM: x86/mmu: Stop zapping invalidated TDP MMU roots asynchronously Sean Christopherson
2023-10-19 21:55 ` Sean Christopherson
2023-10-20 18:52 ` David Matlack [this message]
2023-10-21 9:10 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTLMcmj-ycWhZuTX@google.com \
--to=dmatlack@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulhsia@google.com \
--cc=pbonzini@redhat.com \
--cc=pteerapong@google.com \
--cc=seanjc@google.com \
--cc=stable@vger.kernel.org \
--cc=stevensd@google.com \
--cc=zzyiwei@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.