From: Ingo Molnar <mingo@kernel.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: "Joel Fernandes (Google)" <joel@joelfernandes.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
"Vineeth Pillai (Google)" <vineeth@bitbyteword.org>,
Suleiman Souhlal <suleiman@google.com>,
Frederic Weisbecker <frederic@kernel.org>,
"Paul E . McKenney" <paulmck@kernel.org>
Subject: Re: [PATCH 3/3] sched: Update ->next_balance correctly during newidle balance
Date: Sat, 21 Oct 2023 08:50:46 +0200 [thread overview]
Message-ID: <ZTN0xgGNefllUm7Q@gmail.com> (raw)
In-Reply-To: <CAKfTPtD4eWKDT2pPDUHwfGPGC1kNy1qWnY4rJg2yyCHk9mdfvQ@mail.gmail.com>
* Vincent Guittot <vincent.guittot@linaro.org> wrote:
> Hi Ingo,
>
> On Fri, 20 Oct 2023 at 09:53, Ingo Molnar <mingo@kernel.org> wrote:
> >
> >
>
> ...
>
> > > curr_cost += domain_cost;
> > > t0 = t1;
> >
> > Okay, I'm applying patches #2 and #3, without #1: it should be safe
> > out of order, but let me know if I missed something ...
>
> Could you hold on for patch 3 ? As replied to Joel, the patch had
> regression in the update of rq->next_balance
Yeah, patch #3 is gone already from tip:sched/core.
Thanks,
Ingo
next prev parent reply other threads:[~2023-10-21 6:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 1:40 [PATCH 1/3] sched/nohz: Update nohz.next_balance directly without IPIs (v2) Joel Fernandes (Google)
2023-10-20 1:40 ` [PATCH 2/3] sched/nohz: Update comments about NEWILB_KICK Joel Fernandes (Google)
2023-10-20 7:51 ` Ingo Molnar
2023-10-20 8:02 ` [tip: sched/core] " tip-bot2 for Joel Fernandes (Google)
2023-10-20 1:40 ` [PATCH 3/3] sched: Update ->next_balance correctly during newidle balance Joel Fernandes (Google)
2023-10-20 7:53 ` Ingo Molnar
2023-10-20 13:48 ` Vincent Guittot
2023-10-21 6:50 ` Ingo Molnar [this message]
2023-10-20 8:02 ` [tip: sched/core] sched/fair: " tip-bot2 for Vineeth Pillai (Google)
2023-10-20 13:40 ` [PATCH 3/3] sched: " Vincent Guittot
2023-10-20 13:56 ` Ingo Molnar
2023-10-20 15:50 ` Joel Fernandes
2023-10-22 0:28 ` Joel Fernandes
2023-10-26 14:23 ` Vincent Guittot
2023-11-09 10:02 ` Joel Fernandes
2023-11-09 12:31 ` Joel Fernandes
2023-11-14 15:43 ` Vincent Guittot
2023-11-14 17:43 ` Joel Fernandes
2024-06-13 7:13 ` Joel Fernandes
2025-11-25 13:16 ` [PATCH] sched/fair: Only increment deadline once on yield Wang Tao
2025-11-25 13:27 ` [PATCH 3/3] sched: Update ->next_balance correctly during newidle balance Wang Tao
2023-10-20 4:17 ` [PATCH 1/3] sched/nohz: Update nohz.next_balance directly without IPIs (v2) Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTN0xgGNefllUm7Q@gmail.com \
--to=mingo@kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=frederic@kernel.org \
--cc=joel@joelfernandes.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=suleiman@google.com \
--cc=vincent.guittot@linaro.org \
--cc=vineeth@bitbyteword.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.