All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	pabeni@redhat.com, amritha.nambiar@intel.com,
	donald.hunter@gmail.com, chuck.lever@oracle.com, sdf@google.com
Subject: Re: [PATCH net-next] tools: ynl-gen: change spacing around __attribute__
Date: Sat, 21 Oct 2023 13:23:20 +0200	[thread overview]
Message-ID: <ZTO0qBkkSJGauYlU@nanopsycho> (raw)
In-Reply-To: <20231020221827.3436697-1-kuba@kernel.org>

Sat, Oct 21, 2023 at 12:18:27AM CEST, kuba@kernel.org wrote:
>checkpatch gets confused and treats __attribute__ as a function call.
>It complains about white space before "(":
>
>WARNING:SPACING: space prohibited between function name and open parenthesis '('
>+	struct netdev_queue_get_rsp obj __attribute__ ((aligned (8)));
>
>No spaces wins in the kernel:
>
>  $ git grep 'attribute__((.*aligned(' | wc -l
>  480
>  $ git grep 'attribute__ ((.*aligned (' | wc -l
>  110
>  $ git grep 'attribute__ ((.*aligned(' | wc -l
>  94
>  $ git grep 'attribute__((.*aligned (' | wc -l
>  63
>
>So, whatever, change the codegen.
>
>Note that checkpatch also thinks we should use __aligned(),
>but this is user space code.
>
>Link: https://lore.kernel.org/all/202310190900.9Dzgkbev-lkp@intel.com/
>Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Jiri Pirko <jiri@nvidia.com>

  parent reply	other threads:[~2023-10-21 11:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-20 22:18 [PATCH net-next] tools: ynl-gen: change spacing around __attribute__ Jakub Kicinski
2023-10-20 22:26 ` Stanislav Fomichev
2023-10-21  0:32 ` Nambiar, Amritha
2023-10-21 11:23 ` Jiri Pirko [this message]
2023-10-23 17:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZTO0qBkkSJGauYlU@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=amritha.nambiar@intel.com \
    --cc=chuck.lever@oracle.com \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.