Re: [PATCH v5 00/18] IOMMUFD Dirty Tracking

[Nicolin Chen <nicolinc@nvidia.com>]

On Sat, Oct 21, 2023 at 01:23:21PM -0300, Jason Gunthorpe wrote:
> On Fri, Oct 20, 2023 at 11:27:46PM +0100, Joao Martins wrote:
> > Changes since v4[8]:
> > * Rename HWPT_SET_DIRTY to HWPT_SET_DIRTY_TRACKING 
> > * Rename IOMMU_CAP_DIRTY to IOMMU_CAP_DIRTY_TRACKING
> > * Rename HWPT_GET_DIRTY_IOVA to HWPT_GET_DIRTY_BITMAP
> > * Rename IOMMU_HWPT_ALLOC_ENFORCE_DIRTY to IOMMU_HWPT_ALLOC_DIRTY_TRACKING
> >   including commit messages, code comments. Additionally change the
> >   variable in drivers from enforce_dirty to dirty_tracking.
> > * Reflect all the mass renaming in commit messages/structs/docs.
> > * Fix the enums prefix to be IOMMU_HWPT like everyone else
> > * UAPI docs fixes/spelling and minor consistency issues/adjustments
> > * Change function exit style in __iommu_read_and_clear_dirty to return
> >   right away instead of storing ret and returning at the end.
> > * Check 0 page_size and replace find-first-bit + left-shift with a
> >   simple divide in iommufd_check_iova_range()
> > * Handle empty iommu domains when setting dirty tracking in intel-iommu;
> >   Verified and amd-iommu was already the case.
> > * Remove unnecessary extra check for PGTT type
> > * Fix comment on function clearing the SLADE bit
> > * Fix wrong check that validates domain_alloc_user()
> >   accepted flags in amd-iommu driver
> > * Skip IOTLB domain flush if no devices exist on the iommu domain,
> > while setting dirty tracking in amd-iommu driver.
> > * Collect Reviewed-by tags by Jason, Lu Baolu, Brett, Kevin, Alex
> 
> I put this toward linux-next, let's see if we need a v6 next week with
> any remaining items.

The selftest seems to be broken with this series:

In file included from iommufd.c:10:0:
iommufd_utils.h:12:10: fatal error: linux/bitmap.h: No such file or directory
 #include <linux/bitmap.h>
          ^~~~~~~~~~~~~~~~
In file included from iommufd.c:10:0:
iommufd_utils.h:12:10: fatal error: linux/bitops.h: No such file or directory
 #include <linux/bitops.h>
          ^~~~~~~~~~~~~~~~
compilation terminated.

Some of the tests are using kernel functions from these two headers
so I am not sure how to do any quick fix...

Thanks
Nicolin