From: Sudeep Holla <sudeep.holla@arm.com>
To: sean yang <seanyang230@gmail.com>
Cc: cristian.marussi@arm.com, linux-arm-kernel@lists.infradead.org,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH] firmware: arm_scmi: Add lock for mailbox do_xfer
Date: Mon, 23 Oct 2023 09:58:19 +0100 [thread overview]
Message-ID: <ZTY1q-G9RDREgMD_@bogus> (raw)
In-Reply-To: <CADGqjFJsG4=ZXAOPh930pZ5KT7n3xSDOUs68ZQsEo4t2uP-FPg@mail.gmail.com>
Hi Xinglong,
Cristian has already given reason why this change is wrong.
I wanted to let you know that you need to still fix your email.
On Sun, Oct 22, 2023 at 08:15:17PM +0800, sean yang wrote:
> The function do_xfer may cause multithreading send message at almost the
> same time.
>
> send_message will write the message in the shared memory, This causes the
> second write
>
> to overwrite the first write, resulting in the loss of the first write.
>
> Add lock to avoid this situation. Release lock when the message has
> responded.
>
This looks like either copy-pasted or some wrong format(html?).
Use git send-email if you are not already to send any patch on the list.
This is definitely wrong format and no one can apply this patch.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-23 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CADGqjFJsG4=ZXAOPh930pZ5KT7n3xSDOUs68ZQsEo4t2uP-FPg@mail.gmail.com>
2023-10-23 8:13 ` [PATCH] firmware: arm_scmi: Add lock for mailbox do_xfer Cristian Marussi
2023-10-23 8:58 ` Sudeep Holla [this message]
[not found] <PUZPR06MB5498D2331BB04DAE393F9447F0D4A@PUZPR06MB5498.apcprd06.prod.outlook.com>
2023-10-19 9:14 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTY1q-G9RDREgMD_@bogus \
--to=sudeep.holla@arm.com \
--cc=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=seanyang230@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.