From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Julien Grall <julien@xen.org>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH for-4.19] xen/xmalloc: XMEM_POOL_POISON improvements
Date: Mon, 23 Oct 2023 10:28:13 +0200 [thread overview]
Message-ID: <ZTYunVMy-d0cxEa6@macbook> (raw)
In-Reply-To: <2902d6cc-169b-a70f-ce10-10925e837fb6@suse.com>
On Mon, Oct 23, 2023 at 10:04:21AM +0200, Jan Beulich wrote:
> On 20.10.2023 22:26, Andrew Cooper wrote:
> > However, upping to a BUG() can't provide any helpful message out to the user.
> >
> > I tried modifying BUG() to take an optional message, but xen/bug.h needs
> > untangling substantially before that will work, and I don't have time right now.
>
> I agree with Julien's suggestion of using panic() in the meantime, as a
> possible alternative.
We might care about the stack trace, so would be helpful to print it,
maybe WARN + panic?
> Question though is whether it's better to halt the
> system right away, as opposed to e.g. permitting orderly shutdown to cover
> the case where the corruption ends up not being "deadly".
Hm, won't this be risky, as we could then possibly corrupt data on disk
for example?
Thanks, Roger.
next prev parent reply other threads:[~2023-10-23 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 20:26 [PATCH for-4.19] xen/xmalloc: XMEM_POOL_POISON improvements Andrew Cooper
2023-10-22 16:52 ` Julien Grall
2023-10-23 9:51 ` Andrew Cooper
2023-10-23 8:04 ` Jan Beulich
2023-10-23 8:28 ` Roger Pau Monné [this message]
2023-10-23 8:41 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTYunVMy-d0cxEa6@macbook \
--to=roger.pau@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.