All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: Pawel Chmielewski <pawel.chmielewski@intel.com>
Cc: lukasz.czapnik@intel.com, intel-wired-lan@lists.osuosl.org,
	Liang-min Wang <liang-min.wang@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: Reset VF on Tx MDD event
Date: Tue, 24 Oct 2023 15:12:54 +0200	[thread overview]
Message-ID: <ZTfC1u4BxG55rZ6o@wasp> (raw)
In-Reply-To: <20231024112912.1811594-1-pawel.chmielewski@intel.com>

On Tue, Oct 24, 2023 at 01:29:12PM +0200, Pawel Chmielewski wrote:
> From: Liang-min Wang <liang-min.wang@intel.com>
> 
> In cases when VF sends malformed packets that are classified as malicious,
> sometimes it causes Tx queue to freeze. This frozen queue can be stuck
> for several minutes being unusable.
> 
> When MDD event occurs, perform graceful VF reset to quickly bring VF
> back to operational state.
> 
> Signed-off-by: Liang-min Wang <liang-min.wang@intel.com>
> Signed-off-by: Pawel Chmielewski <pawel.chmielewski@intel.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_main.c | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index 66095e9b094e..cf9fd1f168f7 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -1836,8 +1836,13 @@ static void ice_handle_mdd_event(struct ice_pf *pf)
>  			vf->mdd_tx_events.count++;
>  			set_bit(ICE_MDD_VF_PRINT_PENDING, pf->state);
>  			if (netif_msg_tx_err(pf))
> -				dev_info(dev, "Malicious Driver Detection event TX_TCLAN detected on VF %d\n",
> +				dev_info(dev,
> +					 "Malicious Driver Detection event TX_TCLAN detected on VF %d\n",
>  					 vf->vf_id);
> +			dev_info(dev,
> +				 "PF-to-VF reset on VF %d due to Tx MDD TX_TCLAN event\n",
> +				 vf->vf_id);
> +			ice_reset_vf(vf, ICE_VF_RESET_NOTIFY);
>  		}
>  
>  		reg = rd32(hw, VP_MDET_TX_TDPU(vf->vf_id));
> @@ -1846,8 +1851,13 @@ static void ice_handle_mdd_event(struct ice_pf *pf)
>  			vf->mdd_tx_events.count++;
>  			set_bit(ICE_MDD_VF_PRINT_PENDING, pf->state);
>  			if (netif_msg_tx_err(pf))
> -				dev_info(dev, "Malicious Driver Detection event TX_TDPU detected on VF %d\n",
> +				dev_info(dev,
> +					 "Malicious Driver Detection event TX_TDPU detected on VF %d\n",
>  					 vf->vf_id);
> +			dev_info(dev,
> +				 "PF-to-VF reset on VF %d due to Tx MDD TX_TCLAN event\n",
> +				 vf->vf_id);
You forgot to change TX_TCLAN to TX_TDPU.

> +			ice_reset_vf(vf, ICE_VF_RESET_NOTIFY);
>  		}
>  
>  		reg = rd32(hw, VP_MDET_RX(vf->vf_id));
> -- 
> 2.37.3
> 
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

  parent reply	other threads:[~2023-10-24 13:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-24 11:29 [Intel-wired-lan] [PATCH iwl-next] ice: Reset VF on Tx MDD event Pawel Chmielewski
2023-10-24 11:41 ` Paul Menzel
2023-10-24 12:18   ` Pawel Chmielewski
2023-10-24 13:12 ` Michal Swiatkowski [this message]
2023-10-24 16:21   ` Pawel Chmielewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZTfC1u4BxG55rZ6o@wasp \
    --to=michal.swiatkowski@linux.intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=liang-min.wang@intel.com \
    --cc=lukasz.czapnik@intel.com \
    --cc=pawel.chmielewski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.