From: Peter Xu <peterx@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, Fabiano Rosas <farosas@suse.de>,
Leonardo Bras <leobras@redhat.com>
Subject: Re: ram_save_complete() is fishy
Date: Tue, 24 Oct 2023 09:12:37 -0400 [thread overview]
Message-ID: <ZTfCxf5+fHafbDRe@x1n> (raw)
In-Reply-To: <d41c8909-25e7-40a6-8dcc-2c0094a56f13@redhat.com>
On Tue, Oct 24, 2023 at 11:05:12AM +0200, Thomas Huth wrote:
> Oh well, looking at the whole file, it seems like most spots that call a
> rdma_* function just do qemu_file_set_error() afterwards, but then continue
> with the normal workflow... that looks really confusing to me - if this
> needs fixing, it should be done by somebody who knows that code better than
> me, so I'll keep my hands of this and let somebody else fix it if necessary.
> I'll just respin my original patch to fix the -Wshadow issue.
Oh.. let me take a closer look today. Thanks for helping, Thomas!
--
Peter Xu
prev parent reply other threads:[~2023-10-24 13:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 14:50 [PATCH] migration/ram: Fix compilation with -Wshadow=local Thomas Huth
2023-10-23 15:27 ` Markus Armbruster
2023-10-24 4:55 ` Markus Armbruster
2023-10-23 15:57 ` Peter Xu
2023-10-23 17:11 ` Thomas Huth
2023-10-23 17:30 ` ram_save_complete() is fishy (was: Re: [PATCH] migration/ram: Fix compilation with -Wshadow=local) Thomas Huth
2023-10-23 18:55 ` Peter Xu
2023-10-24 9:05 ` ram_save_complete() is fishy Thomas Huth
2023-10-24 13:12 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTfCxf5+fHafbDRe@x1n \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=farosas@suse.de \
--cc=leobras@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.