From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-206.mta1.migadu.com (out-206.mta1.migadu.com [95.215.58.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 026E21D6B8 for ; Tue, 24 Oct 2023 23:04:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ja8jpqTB" Date: Tue, 24 Oct 2023 23:04:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1698188672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+i9nlbE8cuhzaIFBavKLVyMhmf7wc/8N7QLazfwuA5E=; b=ja8jpqTBFPm4QkYeWD+yG6eDinCH0szYgsImLTVghPo0lusSEbJrsVijn2vhsMhbt+LEPU XRkTTfYEPzcdjbqoKooBetpnsPxBFJ6nvuYt+ftX+i365En3CeIddLeruxcqgvB6hmRRwT PfGvKWD+cqptx9AToYaYIRd1A2wGJt4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Marc Zyngier Cc: Miguel Luis , "kvmarm@lists.linux.dev" , "kvm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Eric Auger , James Morse , Suzuki K Poulose , Zenghui Yu Subject: Re: [PATCH 5/5] KVM: arm64: Handle AArch32 SPSR_{irq,abt,und,fiq} as RAZ/WI Message-ID: References: <20231023095444.1587322-1-maz@kernel.org> <20231023095444.1587322-6-maz@kernel.org> <7DD05DC0-164E-440F-BEB1-E5040C512008@oracle.com> <86jzrc3pbm.wl-maz@kernel.org> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT On Tue, Oct 24, 2023 at 10:41:57PM +0000, Oliver Upton wrote: > On Tue, Oct 24, 2023 at 06:25:33PM +0100, Marc Zyngier wrote: > > On Mon, 23 Oct 2023 19:55:10 +0100, Miguel Luis wrote: > > > Also, could you please explain what is happening at PSTATE.EL == EL1 > > > and if EL2Enabled() && HCR_EL2.NV == ‘1’ ? > > > > We directly take the trap and not forward it. This isn't exactly the > > letter of the architecture, but at the same time, treating these > > registers as RAZ/WI is the only valid implementation. I don't > > immediately see a problem with taking this shortcut. > > Ugh, that's annoying. The other EL2 views of AArch32 state UNDEF if EL1 > doesn't implement AArch32. It'd be nice to get a relaxation in the > architecture to allow an UNDEF here. Correction (I wasn't thinking): RES0 behavior should be invariant, much like the UNDEF behavior of the other AA32-specific registers. -- Thanks, Oliver From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51407C07545 for ; Tue, 24 Oct 2023 23:05:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lrnKflxpxp6TmDCTEt2/GSSXijBTYocr8jysCkPdhHk=; b=zBnmHhInaC3YNL 0XLgjXJLm1fJvbYP3KTGpEZ+PchmVyfYUkCFId0qW0Sz+B5kVDxjH75+59HMhsFETklmhZlNxMMoj grlGTahWxKSD9gtfVBeQljoeJkIOZnspT/OZg016KZEBF4DZgfiZQ3x7jPdJCba2XKc5beCsOZjGq skLrQbtOwkWhG70t5BAg8OMIpvPJlrmNUX7ssKNwEIbOrIzpt8qMqQfz8woTEe6uFnJ+NLMAmPC+U R70m/BHg/STOV0yH4xVp4D6BqUtmhQsdOLIFGP70SzvPEuVwGFXhwQiM0AnbTejM+vTtyM5XWAraK qKNMF3s9KGKsniUmM5/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvQS0-00AzzV-1G; Tue, 24 Oct 2023 23:04:40 +0000 Received: from out-194.mta1.migadu.com ([2001:41d0:203:375::c2]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qvQRw-00Azyj-30 for linux-arm-kernel@lists.infradead.org; Tue, 24 Oct 2023 23:04:38 +0000 Date: Tue, 24 Oct 2023 23:04:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1698188672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+i9nlbE8cuhzaIFBavKLVyMhmf7wc/8N7QLazfwuA5E=; b=ja8jpqTBFPm4QkYeWD+yG6eDinCH0szYgsImLTVghPo0lusSEbJrsVijn2vhsMhbt+LEPU XRkTTfYEPzcdjbqoKooBetpnsPxBFJ6nvuYt+ftX+i365En3CeIddLeruxcqgvB6hmRRwT PfGvKWD+cqptx9AToYaYIRd1A2wGJt4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Marc Zyngier Cc: Miguel Luis , "kvmarm@lists.linux.dev" , "kvm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Eric Auger , James Morse , Suzuki K Poulose , Zenghui Yu Subject: Re: [PATCH 5/5] KVM: arm64: Handle AArch32 SPSR_{irq,abt,und,fiq} as RAZ/WI Message-ID: References: <20231023095444.1587322-1-maz@kernel.org> <20231023095444.1587322-6-maz@kernel.org> <7DD05DC0-164E-440F-BEB1-E5040C512008@oracle.com> <86jzrc3pbm.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231024_160437_388700_3A5118FE X-CRM114-Status: GOOD ( 14.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBPY3QgMjQsIDIwMjMgYXQgMTA6NDE6NTdQTSArMDAwMCwgT2xpdmVyIFVwdG9uIHdy b3RlOgo+IE9uIFR1ZSwgT2N0IDI0LCAyMDIzIGF0IDA2OjI1OjMzUE0gKzAxMDAsIE1hcmMgWnlu Z2llciB3cm90ZToKPiA+IE9uIE1vbiwgMjMgT2N0IDIwMjMgMTk6NTU6MTAgKzAxMDAsIE1pZ3Vl bCBMdWlzIDxtaWd1ZWwubHVpc0BvcmFjbGUuY29tPiB3cm90ZToKPiA+ID4gQWxzbywgY291bGQg eW91IHBsZWFzZSBleHBsYWluIHdoYXQgaXMgaGFwcGVuaW5nIGF0IFBTVEFURS5FTCA9PSBFTDEK PiA+ID4gYW5kIGlmIEVMMkVuYWJsZWQoKSAmJiBIQ1JfRUwyLk5WID09IOKAmDHigJkgID8KPiA+ IAo+ID4gV2UgZGlyZWN0bHkgdGFrZSB0aGUgdHJhcCBhbmQgbm90IGZvcndhcmQgaXQuIFRoaXMg aXNuJ3QgZXhhY3RseSB0aGUKPiA+IGxldHRlciBvZiB0aGUgYXJjaGl0ZWN0dXJlLCBidXQgYXQg dGhlIHNhbWUgdGltZSwgdHJlYXRpbmcgdGhlc2UKPiA+IHJlZ2lzdGVycyBhcyBSQVovV0kgaXMg dGhlIG9ubHkgdmFsaWQgaW1wbGVtZW50YXRpb24uIEkgZG9uJ3QKPiA+IGltbWVkaWF0ZWx5IHNl ZSBhIHByb2JsZW0gd2l0aCB0YWtpbmcgdGhpcyBzaG9ydGN1dC4KPiAKPiBVZ2gsIHRoYXQncyBh bm5veWluZy4gVGhlIG90aGVyIEVMMiB2aWV3cyBvZiBBQXJjaDMyIHN0YXRlIFVOREVGIGlmIEVM MQo+IGRvZXNuJ3QgaW1wbGVtZW50IEFBcmNoMzIuIEl0J2QgYmUgbmljZSB0byBnZXQgYSByZWxh eGF0aW9uIGluIHRoZQo+IGFyY2hpdGVjdHVyZSB0byBhbGxvdyBhbiBVTkRFRiBoZXJlLgoKQ29y cmVjdGlvbiAoSSB3YXNuJ3QgdGhpbmtpbmcpOiBSRVMwIGJlaGF2aW9yIHNob3VsZCBiZSBpbnZh cmlhbnQsIG11Y2gKbGlrZSB0aGUgVU5ERUYgYmVoYXZpb3Igb2YgdGhlIG90aGVyIEFBMzItc3Bl Y2lmaWMgcmVnaXN0ZXJzLgoKLS0gClRoYW5rcywKT2xpdmVyCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlz dApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==