From: Jim Harris <jim.harris@samsung.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
"dan.carpenter@linaro.org" <dan.carpenter@linaro.org>
Subject: Re: [PATCH v2] cxl/region: don't try to cleanup after cxl_region_setup_targets() fails
Date: Wed, 25 Oct 2023 01:37:22 +0000 [thread overview]
Message-ID: <ZThxTYon1WOI3iAd@ubuntu> (raw)
In-Reply-To: <65384cbf52621_1ce4592949@dwillia2-xfh.jf.intel.com.notmuch>
On Tue, Oct 24, 2023 at 04:01:19PM -0700, Dan Williams wrote:
>
> Patch looks good, but I did reflow the above paragraphs to have commit
> references per checkpatch expectations. I believe it did not flag them
> for you as it did not recognize "Patch <SHA>" as referring to a commit:
>
> Commit 5e42bcbc3fef ("cxl/region: decrement ->nr_targets on error in
> cxl_region_attach()") tried to avoid 'eiw' initialization errors when
> ->nr_targets exceeded 16, by just decrementing ->nr_targets when
> cxl_region_setup_targets() failed.
>
> Commit 86987c766276 ("cxl/region: Cleanup target list on attach error")
> extended that cleanup to also clear cxled->pos and p->targets[pos]. The
> initialization error was incidentally fixed separately by:
> Commit 8d4285425714 ("cxl/region: Fix port setup uninitialized variable
> warnings") which was merged a few days after 5e42bcbc3fef.
>
> I also went ahead and added:
>
> Fixes: 5e42bcbc3fef ("cxl/region: decrement ->nr_targets on error in cxl_region_attach()")
> Cc: <stable@vger.kernel.org>
>
Thanks Dan, I'll keep an eye out for these in the future.
prev parent reply other threads:[~2023-10-25 1:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20231010183840uscas1p294532ae60e6014508efd897fef14fffd@uscas1p2.samsung.com>
2023-10-10 18:38 ` [PATCH] cxl/region: don't try to cleanup after cxl_region_setup_targets() fails Jim Harris
2023-10-11 14:04 ` Dan Carpenter
2023-10-11 14:31 ` Jim Harris
2023-10-11 14:51 ` [PATCH v2] " Jim Harris
2023-10-11 14:57 ` Dan Carpenter
2023-10-11 20:41 ` Jonathan Cameron
2023-10-13 16:57 ` Dave Jiang
2023-10-24 23:01 ` Dan Williams
2023-10-25 1:37 ` Jim Harris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZThxTYon1WOI3iAd@ubuntu \
--to=jim.harris@samsung.com \
--cc=dan.carpenter@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.