From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FF1CC0032E for ; Wed, 25 Oct 2023 09:48:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229606AbjJYJsl (ORCPT ); Wed, 25 Oct 2023 05:48:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234154AbjJYJsk (ORCPT ); Wed, 25 Oct 2023 05:48:40 -0400 Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [IPv6:2001:780:45:1d:225:90ff:fe52:c662]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29DBFB4 for ; Wed, 25 Oct 2023 02:48:38 -0700 (PDT) Received: from [78.30.35.151] (port=50366 helo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qvaV8-00CiEq-K9 for netfilter-devel@vger.kernel.org; Wed, 25 Oct 2023 11:48:36 +0200 Date: Wed, 25 Oct 2023 11:48:33 +0200 From: Pablo Neira Ayuso To: netfilter-devel@vger.kernel.org Subject: Re: [PATCH nf-next 0/5] nf_tables set updates Message-ID: References: <20231024083359.24742-1-pablo@netfilter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231024083359.24742-1-pablo@netfilter.org> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, Oct 24, 2023 at 10:33:54AM +0200, Pablo Neira Ayuso wrote: > Hi, > > This is a first batch of nf_tables set updates: > > 1) Use nft_set_ext already accesible as parameter via .flush(), no > need for pipapo_deactivate() call. > > 2) Turn .flush into void, this never fails. > > 3) Add and use struct nft_elem_priv placeholder, suggested by Florian. > > 4) Shrink memory usage for set elements in transactions, as well as > stack usage. > > 5) Use struct nft_elem_priv in .insert, in preparation for set timeout > updates, this will come in a later patch. > > This batch has survived hours of 30s-stress runs and tests/shell, > I am still stress testing the set element updates, that will come in > a follow up batch. Series applied to nf-next