From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FCBEC0032E for ; Wed, 25 Oct 2023 13:32:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344716AbjJYNcA (ORCPT ); Wed, 25 Oct 2023 09:32:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235018AbjJYNbc (ORCPT ); Wed, 25 Oct 2023 09:31:32 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D56710D0 for ; Wed, 25 Oct 2023 06:31:13 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-4079ed65582so44321535e9.1 for ; Wed, 25 Oct 2023 06:31:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1698240672; x=1698845472; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=WJHhodEo9Mg5Sb1D06HbWzBXmtfErODVASwmg4rpCew=; b=ThrkpWW6DcHqv6j3ND/GS9JQtqTItxY8GLOtAVhCW9RrwDEN7Js7tUCgKZ60/D8E0Z oif5nfKlqZzTRFyBW3jQmUUdweDc1tFJzC5sRg3+YJTdvETa9i+HTvBPmkFZDxYFcN4Y Q5r0DHYmqac1erbgJCotv1qVgPRRdmxumH+3rE9Zd3ryZXv7Re+P4b3olYl5PsFN3g+A uheGwtaw4lLp5CSaLhkH32aV1ejEooptbR4iYH48Fk5aoLAqrSxpTvRN5GQ2jcdobu3M WMqEJ4AyEXwN4EQPDyjWj7j92fNNAjws+d1suqeEMx+N49Lg53B4YLWyeB3zNkUqAeyB wppA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698240672; x=1698845472; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WJHhodEo9Mg5Sb1D06HbWzBXmtfErODVASwmg4rpCew=; b=ul5d8qijJWCZaOKCXgdUf/dxQUktSthKCFoZOsCGZDUax1NIlPQWA1Yn413qaP3Pp8 4JfUALJ4BFVT8i8hDY/Ml5XA6QT4ZEWyUCflSOAJ1N1j12Q+yeP8SPeCtrwE5SyBFwxL qbCtAGb8YZBXr5QLxdMyJ8thQ6+kwzWQlCOVqpQpMYYvLuZCT7stuozHpNZjthQyQCXL apATDHPnaHhoxEPMGKXlfCV1P0Jfudavn3eHxq9uE9U9svORqOFszxiO47rjrKNPOMt3 jQhvYrrU1xkQLfoHSdhMpMB4vpLafgx7l5NpIV7r5AOO8+a45J/MnVnDkc2egETmgfe+ e9iQ== X-Gm-Message-State: AOJu0YxA4NvgUrt7F7YAOUP2CqnZwTJAQhw3lEeM5mx95GTwsL9GNusb akuQXIGJynJ25Y1kBQhjAAQYUQ== X-Google-Smtp-Source: AGHT+IG5TmoQSWagYVZDYEFtA3xQyjVPh4wRtdL4nDgviNvJdR54Bqa+t6mU4jxmEiLEOP/aqcQnpg== X-Received: by 2002:adf:e943:0:b0:329:6bdc:5a60 with SMTP id m3-20020adfe943000000b003296bdc5a60mr10530917wrn.12.1698240671827; Wed, 25 Oct 2023 06:31:11 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:4a02:2aff:fe07:1efc]) by smtp.googlemail.com with ESMTPSA id f4-20020a5d50c4000000b0032da319a27asm12213088wrt.9.2023.10.25.06.31.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 06:31:11 -0700 (PDT) Date: Wed, 25 Oct 2023 15:31:09 +0200 From: Corentin LABBE To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Herbert Xu , "David S. Miller" , Heiko Stuebner , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@pengutronix.de Subject: Re: [PATCH 34/42] crypto: rockchip/rk3288 - Convert to platform remove callback returning void Message-ID: References: <20231020075521.2121571-44-u.kleine-koenig@pengutronix.de> <20231020075521.2121571-78-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231020075521.2121571-78-u.kleine-koenig@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Le Fri, Oct 20, 2023 at 09:55:56AM +0200, Uwe Kleine-König a écrit : > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König > --- > drivers/crypto/rockchip/rk3288_crypto.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockchip/rk3288_crypto.c > index 77d5705a5d96..70edf40bc523 100644 > --- a/drivers/crypto/rockchip/rk3288_crypto.c > +++ b/drivers/crypto/rockchip/rk3288_crypto.c > @@ -405,7 +405,7 @@ static int rk_crypto_probe(struct platform_device *pdev) > return err; > } > > -static int rk_crypto_remove(struct platform_device *pdev) > +static void rk_crypto_remove(struct platform_device *pdev) > { > struct rk_crypto_info *crypto_tmp = platform_get_drvdata(pdev); > struct rk_crypto_info *first; > @@ -424,12 +424,11 @@ static int rk_crypto_remove(struct platform_device *pdev) > } > rk_crypto_pm_exit(crypto_tmp); > crypto_engine_exit(crypto_tmp->engine); > - return 0; > } > > static struct platform_driver crypto_driver = { > .probe = rk_crypto_probe, > - .remove = rk_crypto_remove, > + .remove_new = rk_crypto_remove, > .driver = { > .name = "rk3288-crypto", > .pm = &rk_crypto_pm_ops, > -- > 2.42.0 > Acked-by: Corentin Labbe Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A7A8C07545 for ; Wed, 25 Oct 2023 13:31:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bGf407cT/nOC98OEQKF8OprXG9rkyV2jGCoL1McAivQ=; b=vb0AKc9lEbQmys o9yt34J/4W4PGVJSxKf6OuVtlDRj+AybnooxsjSVqbZnL4G7eCurzJLhjOz7HhUu6YNx6CG1OIviH /L28boOe6rEtJwBx3DCm3y+hEtQ5frSIZMPgd3IViTCky1JkxD7V4x5GExQa3JR16GnnytRc86/ho +L6JA+ndZ4H3UWpl+AzkbLN/GzbBcp3QV0oOn3ULp7d4W05MKeX9WVu0pmgXWdA80dLbZGsx6h2Go 2F5uQbNG7EPgdwYxJ0wBls+ZaKlhXZcoXpxQvuPL8/BdfXGvvzQhPW8Xne57kg6FfyHcHuFaVaw3G gk9rD0I914PYaNEObizA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvdz7-00CPZd-1T; Wed, 25 Oct 2023 13:31:45 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qvdyc-00CPKe-04 for linux-rockchip@lists.infradead.org; Wed, 25 Oct 2023 13:31:15 +0000 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-3296b3f03e5so3857329f8f.2 for ; Wed, 25 Oct 2023 06:31:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1698240672; x=1698845472; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=WJHhodEo9Mg5Sb1D06HbWzBXmtfErODVASwmg4rpCew=; b=QFi00ybndCQ7ch7mKZmR0dv2ErkuHufOX6fO440+synytrND8vxBwbD7iUezv1ine/ IpHhEhKRBSDNSiD8gEN+iqVg7oRDDjMq8Z4bk/Llj/FOzkzCfJj1Ky+vif1CFbl1Prgy xk5CyrrEDS/wJWpFo1XVKAez5SjrT0Wh6WGGKSFz+4llEolS89yoiqeE0xGVLsq/KshZ Bob8Jaq2on4M6u9Pk6XCc5FRk1FFECclOpxxGtrJsK8KJloyjwx29PuqJOn75UWwMPYC RLEqe6M0sev9yvy3EtSmtdXYzZ/8eqTE8V4IbPzQSG1xkGO/PSTIKz/Y4u9uRPVcmWjJ yEgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698240672; x=1698845472; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WJHhodEo9Mg5Sb1D06HbWzBXmtfErODVASwmg4rpCew=; b=AsxqCD3kB8loYULNPbpApFP9mNKOAviZKUiFrZV3mvOPJV9CXZkCCOwTtb+2yTjLSH lkh8E5iDcxlDIJYRm+NVuD1/HcBuT/s2m1/RnfQKrWsGZcSpAWwBxrOhL4EuKd0buDA2 6qOvXRudk9YqYZQNQ47cR3rkKo4v+Rfw9dBSEd0W57llSmvnaCGaKpLhtiC/ZkQktg94 WqLH8HhzUNQnWWuJeLX8PcAKfCl056SXgWGD9HQvC6YtJiYqOp3oH/o4bp9SKOl8+jOS fQokm5sOe+COIkgWW7xXs5zvIGBm9mkItvq88NdjKatuP4hcIJWkWDu4RA/Fq372lt78 FMjA== X-Gm-Message-State: AOJu0YwL+rMca/RmuYeygcSoCtvH0G5YShgkYtiD2sEJe0YJiw6RvDDc ENAdVEJ8MJ6AXiJq9qxdlzPUg5WBOTMEEzuxTGk= X-Google-Smtp-Source: AGHT+IG5TmoQSWagYVZDYEFtA3xQyjVPh4wRtdL4nDgviNvJdR54Bqa+t6mU4jxmEiLEOP/aqcQnpg== X-Received: by 2002:adf:e943:0:b0:329:6bdc:5a60 with SMTP id m3-20020adfe943000000b003296bdc5a60mr10530917wrn.12.1698240671827; Wed, 25 Oct 2023 06:31:11 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:4a02:2aff:fe07:1efc]) by smtp.googlemail.com with ESMTPSA id f4-20020a5d50c4000000b0032da319a27asm12213088wrt.9.2023.10.25.06.31.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 06:31:11 -0700 (PDT) Date: Wed, 25 Oct 2023 15:31:09 +0200 From: Corentin LABBE To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Herbert Xu , "David S. Miller" , Heiko Stuebner , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@pengutronix.de Subject: Re: [PATCH 34/42] crypto: rockchip/rk3288 - Convert to platform remove callback returning void Message-ID: References: <20231020075521.2121571-44-u.kleine-koenig@pengutronix.de> <20231020075521.2121571-78-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231020075521.2121571-78-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231025_063114_061355_A24B4628 X-CRM114-Status: GOOD ( 24.55 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Le Fri, Oct 20, 2023 at 09:55:56AM +0200, Uwe Kleine-K=F6nig a =E9crit : > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > = > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig > --- > drivers/crypto/rockchip/rk3288_crypto.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > = > diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/roc= kchip/rk3288_crypto.c > index 77d5705a5d96..70edf40bc523 100644 > --- a/drivers/crypto/rockchip/rk3288_crypto.c > +++ b/drivers/crypto/rockchip/rk3288_crypto.c > @@ -405,7 +405,7 @@ static int rk_crypto_probe(struct platform_device *pd= ev) > return err; > } > = > -static int rk_crypto_remove(struct platform_device *pdev) > +static void rk_crypto_remove(struct platform_device *pdev) > { > struct rk_crypto_info *crypto_tmp =3D platform_get_drvdata(pdev); > struct rk_crypto_info *first; > @@ -424,12 +424,11 @@ static int rk_crypto_remove(struct platform_device = *pdev) > } > rk_crypto_pm_exit(crypto_tmp); > crypto_engine_exit(crypto_tmp->engine); > - return 0; > } > = > static struct platform_driver crypto_driver =3D { > .probe =3D rk_crypto_probe, > - .remove =3D rk_crypto_remove, > + .remove_new =3D rk_crypto_remove, > .driver =3D { > .name =3D "rk3288-crypto", > .pm =3D &rk_crypto_pm_ops, > -- = > 2.42.0 > = Acked-by: Corentin Labbe Thanks _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8279C07545 for ; Wed, 25 Oct 2023 13:32:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=30n1X5t1Q2gRMuwzFdPRXtpumht400Ha4BCdP/UutbU=; b=oEJtAeQ6RpwqwS EpWmi70e4W5F+oIxPc+8mLuaMUx46AbNmHZm6Dno2DOfi4tlzRcG+f5/0OVQG4F2jHg5uWmI/mTV3 fiF7DEoVnfvpkdP96xEsWd7S6vWzSoy0+uaCB9KZpg1RQGtv2hA+b0Ef29zEYbh6KOu5dSh2CWK+T ahuXiQcucEmYBF6MI+jahL+wRWmcnGRWhDDutrCSDIdZRCxFOhZFH32l73BRKnbjbyTTb7JiUxEyF ARPNW0ggnSbgM6rbQrqyhu58rKiJIgoc9iK/RdCYcyj7sqkZgatwHNeroK/POR1BF1y1vBsaRd49O Gq6AcQGhqZNf2KwhBaDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvdz6-00CPYY-2G; Wed, 25 Oct 2023 13:31:44 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qvdyb-00CPKd-2C for linux-arm-kernel@lists.infradead.org; Wed, 25 Oct 2023 13:31:15 +0000 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-32d9effe314so3859523f8f.3 for ; Wed, 25 Oct 2023 06:31:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1698240672; x=1698845472; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=WJHhodEo9Mg5Sb1D06HbWzBXmtfErODVASwmg4rpCew=; b=QFi00ybndCQ7ch7mKZmR0dv2ErkuHufOX6fO440+synytrND8vxBwbD7iUezv1ine/ IpHhEhKRBSDNSiD8gEN+iqVg7oRDDjMq8Z4bk/Llj/FOzkzCfJj1Ky+vif1CFbl1Prgy xk5CyrrEDS/wJWpFo1XVKAez5SjrT0Wh6WGGKSFz+4llEolS89yoiqeE0xGVLsq/KshZ Bob8Jaq2on4M6u9Pk6XCc5FRk1FFECclOpxxGtrJsK8KJloyjwx29PuqJOn75UWwMPYC RLEqe6M0sev9yvy3EtSmtdXYzZ/8eqTE8V4IbPzQSG1xkGO/PSTIKz/Y4u9uRPVcmWjJ yEgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698240672; x=1698845472; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WJHhodEo9Mg5Sb1D06HbWzBXmtfErODVASwmg4rpCew=; b=PpLYqv57MlbPqqk9qKOjIWcWDEF6KOCukS/79+eprTGqluhIHUCNrPZhKmLhcaXWvy uVrKvsU+eQEwG8FvbRegKXNybiXHiUcvceZ6ObBjrAbpPgeKM6+Vvj8fE6FdD8SoCaIy eYbdr43G6+c7PcnW8LVr1QWmGHpdEZvjgeb4wiSuO3HiU2aY7CET3BoKnF/G0UxMCapM ZpFY+xF2Mie2rmp8v6YuxH02UHV6zDUgcOA3qALCvcZHY/DPg1KehMsxdbOLsgzcCGNK sbx+7YlshZYZR8GHwKB4sDVCo1EvRkCx1+quUpgevOHB2qkg7EzSwHCXPh/I0T9W+NZH 48Rg== X-Gm-Message-State: AOJu0YxtCQrq96Qiq4xzNS6yOuKFzAIFCPG6FJH4jIVHmUpLF1WgWqc+ ULM22tg86ikDm0VDrTyKvSizUQ== X-Google-Smtp-Source: AGHT+IG5TmoQSWagYVZDYEFtA3xQyjVPh4wRtdL4nDgviNvJdR54Bqa+t6mU4jxmEiLEOP/aqcQnpg== X-Received: by 2002:adf:e943:0:b0:329:6bdc:5a60 with SMTP id m3-20020adfe943000000b003296bdc5a60mr10530917wrn.12.1698240671827; Wed, 25 Oct 2023 06:31:11 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:4a02:2aff:fe07:1efc]) by smtp.googlemail.com with ESMTPSA id f4-20020a5d50c4000000b0032da319a27asm12213088wrt.9.2023.10.25.06.31.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 06:31:11 -0700 (PDT) Date: Wed, 25 Oct 2023 15:31:09 +0200 From: Corentin LABBE To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Herbert Xu , "David S. Miller" , Heiko Stuebner , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@pengutronix.de Subject: Re: [PATCH 34/42] crypto: rockchip/rk3288 - Convert to platform remove callback returning void Message-ID: References: <20231020075521.2121571-44-u.kleine-koenig@pengutronix.de> <20231020075521.2121571-78-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231020075521.2121571-78-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231025_063113_752015_C72F8517 X-CRM114-Status: GOOD ( 25.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Le Fri, Oct 20, 2023 at 09:55:56AM +0200, Uwe Kleine-K=F6nig a =E9crit : > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > = > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig > --- > drivers/crypto/rockchip/rk3288_crypto.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > = > diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/roc= kchip/rk3288_crypto.c > index 77d5705a5d96..70edf40bc523 100644 > --- a/drivers/crypto/rockchip/rk3288_crypto.c > +++ b/drivers/crypto/rockchip/rk3288_crypto.c > @@ -405,7 +405,7 @@ static int rk_crypto_probe(struct platform_device *pd= ev) > return err; > } > = > -static int rk_crypto_remove(struct platform_device *pdev) > +static void rk_crypto_remove(struct platform_device *pdev) > { > struct rk_crypto_info *crypto_tmp =3D platform_get_drvdata(pdev); > struct rk_crypto_info *first; > @@ -424,12 +424,11 @@ static int rk_crypto_remove(struct platform_device = *pdev) > } > rk_crypto_pm_exit(crypto_tmp); > crypto_engine_exit(crypto_tmp->engine); > - return 0; > } > = > static struct platform_driver crypto_driver =3D { > .probe =3D rk_crypto_probe, > - .remove =3D rk_crypto_remove, > + .remove_new =3D rk_crypto_remove, > .driver =3D { > .name =3D "rk3288-crypto", > .pm =3D &rk_crypto_pm_ops, > -- = > 2.42.0 > = Acked-by: Corentin Labbe Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel