From: Luc Michel <luc.michel@amd.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: <qemu-devel@nongnu.org>, Thomas Huth <thuth@redhat.com>,
<qemu-trivial@nongnu.org>, <qemu-arm@nongnu.org>,
Markus Armbruster <armbru@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
"Beniamino Galvani" <b.galvani@gmail.com>,
Strahinja Jankovic <strahinja.p.jankovic@gmail.com>
Subject: Re: [PATCH 03/10] hw/arm/allwinner-r40: Remove 'hw/arm/boot.h' from header
Date: Wed, 25 Oct 2023 19:00:13 +0200 [thread overview]
Message-ID: <ZTlJnWLbreOf6UOU@luc-work-vm> (raw)
In-Reply-To: <20231025065316.56817-4-philmd@linaro.org>
On 08:53 Wed 25 Oct , Philippe Mathieu-Daudé wrote:
> "hw/arm/boot.h" is only required on the source file.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Luc Michel <luc.michel@amd.com>
> ---
> include/hw/arm/allwinner-r40.h | 1 -
> hw/arm/bananapi_m2u.c | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/arm/allwinner-r40.h b/include/hw/arm/allwinner-r40.h
> index 72710d3edc..6e1ac9d4c1 100644
> --- a/include/hw/arm/allwinner-r40.h
> +++ b/include/hw/arm/allwinner-r40.h
> @@ -21,7 +21,6 @@
> #define HW_ARM_ALLWINNER_R40_H
>
> #include "qom/object.h"
> -#include "hw/arm/boot.h"
> #include "hw/timer/allwinner-a10-pit.h"
> #include "hw/intc/arm_gic.h"
> #include "hw/sd/allwinner-sdhost.h"
> diff --git a/hw/arm/bananapi_m2u.c b/hw/arm/bananapi_m2u.c
> index 74121d8966..a7c7a9f96d 100644
> --- a/hw/arm/bananapi_m2u.c
> +++ b/hw/arm/bananapi_m2u.c
> @@ -26,6 +26,7 @@
> #include "hw/i2c/i2c.h"
> #include "hw/qdev-properties.h"
> #include "hw/arm/allwinner-r40.h"
> +#include "hw/arm/boot.h"
>
> static struct arm_boot_info bpim2u_binfo;
>
> --
> 2.41.0
>
>
--
next prev parent reply other threads:[~2023-10-25 20:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 6:53 [PATCH 00/10] hw/arm: Move 'hw/arm/boot.h' from header to source Philippe Mathieu-Daudé
2023-10-25 6:53 ` [PATCH 01/10] hw/arm/allwinner-a10: Remove 'hw/arm/boot.h' from header Philippe Mathieu-Daudé
2023-10-25 16:50 ` Luc Michel
2023-10-25 6:53 ` [PATCH 02/10] hw/arm/allwinner-h3: " Philippe Mathieu-Daudé
2023-10-25 16:59 ` Luc Michel
2023-10-25 6:53 ` [PATCH 03/10] hw/arm/allwinner-r40: " Philippe Mathieu-Daudé
2023-10-25 17:00 ` Luc Michel [this message]
2023-10-25 6:53 ` [PATCH 04/10] hw/arm/fsl-imx25: " Philippe Mathieu-Daudé
2023-10-25 17:00 ` Luc Michel
2023-10-25 6:53 ` [PATCH 05/10] hw/arm/fsl-imx31: " Philippe Mathieu-Daudé
2023-10-25 17:01 ` Luc Michel
2023-10-25 6:53 ` [PATCH 06/10] hw/arm/fsl-imx6: " Philippe Mathieu-Daudé
2023-10-25 17:01 ` Luc Michel
2023-10-25 6:53 ` [PATCH 07/10] hw/arm/fsl-imx6ul: " Philippe Mathieu-Daudé
2023-10-25 17:01 ` Luc Michel
2023-10-25 6:53 ` [PATCH 08/10] hw/arm/fsl-imx7: " Philippe Mathieu-Daudé
2023-10-25 17:02 ` Luc Michel
2023-10-25 6:53 ` [PATCH 09/10] hw/arm/xlnx-versal: " Philippe Mathieu-Daudé
2023-10-25 17:02 ` Luc Michel
2023-10-25 6:53 ` [PATCH 10/10] hw/arm/xlnx-zynqmp: " Philippe Mathieu-Daudé
2023-10-25 17:02 ` Luc Michel
2023-10-25 23:23 ` [PATCH 00/10] hw/arm: Move 'hw/arm/boot.h' from header to source Richard Henderson
2023-10-27 11:42 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTlJnWLbreOf6UOU@luc-work-vm \
--to=luc.michel@amd.com \
--cc=armbru@redhat.com \
--cc=b.galvani@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=strahinja.p.jankovic@gmail.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.