All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Sheik <sahibzone@gmail.com>, Git Mailing List <git@vger.kernel.org>
Cc: "Elijah Newren" <newren@gmail.com>,
	"Calvin Wan" <calvinwan@google.com>,
	"Junio C Hamano" <gitster@pobox.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Alex Henrie" <alexhenrie24@gmail.com>,
	"Derrick Stolee" <derrickstolee@github.com>,
	"Victoria Dye" <vdye@github.com>,
	"Kristoffer Haugsbakk" <code@khaugsbakk.name>
Subject: Re: git diagnose with invalid CLI argument does not report error
Date: Thu, 26 Oct 2023 18:10:13 +0700	[thread overview]
Message-ID: <ZTpJFUdE2U6pbV--@debian.me> (raw)
In-Reply-To: <849b6ee2-99f3-4aaa-835f-44d3e13befc3@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 772 bytes --]

On Thu, Oct 26, 2023 at 07:49:58AM +1100, Sheik wrote:
> Hi Maintainers,
> 
> 
> Running git diagnose with an invalid CLI argument in a valid Git directory
> does not report error. Expected behaviour would be that it reports an error.
> 
> #Example shell commands which should have reported an error but continues to
> succeed
> 
> cd $ToAGitDirectory
> 
> git diagnose mod
> 
> git diagnose mode
> 
> git diagnose mode=all
> 

I can reproduce this only when the invalid parameter is a normal word:

```
$ git diagnose huh
```

But the command errors out on invalid flag:

```
$ git diagnose -m
```

Cc:'ing people who recently worked on builtin/diagnose.c for help.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-10-26 11:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-25 20:49 git diagnose with invalid CLI argument does not report error Sheik
2023-10-26 11:10 ` Bagas Sanjaya [this message]
2023-10-26 22:11   ` Eric Sunshine
2023-10-26 22:41     ` Emily Shaffer
2023-10-26 22:43       ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZTpJFUdE2U6pbV--@debian.me \
    --to=bagasdotme@gmail.com \
    --cc=alexhenrie24@gmail.com \
    --cc=avarab@gmail.com \
    --cc=calvinwan@google.com \
    --cc=code@khaugsbakk.name \
    --cc=derrickstolee@github.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=newren@gmail.com \
    --cc=sahibzone@gmail.com \
    --cc=vdye@github.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.