From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 732B1C25B6B for ; Thu, 26 Oct 2023 11:26:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230143AbjJZL0j (ORCPT ); Thu, 26 Oct 2023 07:26:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229649AbjJZL0i (ORCPT ); Thu, 26 Oct 2023 07:26:38 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9DA811A6; Thu, 26 Oct 2023 04:26:35 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E84CA2F4; Thu, 26 Oct 2023 04:27:16 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.70.231]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BB90E3F738; Thu, 26 Oct 2023 04:26:32 -0700 (PDT) Date: Thu, 26 Oct 2023 12:26:20 +0100 From: Mark Rutland To: Zeng Heng Cc: broonie@kernel.org, joey.gouly@arm.com, will@kernel.org, amit.kachhap@arm.com, rafael@kernel.org, catalin.marinas@arm.com, james.morse@arm.com, maz@kernel.org, viresh.kumar@linaro.org, sumitg@nvidia.com, yang@os.amperecomputing.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wangxiongfeng2@huawei.com, xiexiuqi@huawei.com, Ionela Voinescu Subject: Re: [PATCH 3/3] cpufreq: CPPC: Eliminate the impact of cpc_read() latency error Message-ID: References: <20231025093847.3740104-1-zengheng4@huawei.com> <20231025093847.3740104-4-zengheng4@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, Oct 26, 2023 at 09:55:39AM +0800, Zeng Heng wrote: > > 在 2023/10/25 19:01, Mark Rutland 写道: > > On Wed, Oct 25, 2023 at 05:38:47PM +0800, Zeng Heng wrote: > > > > The previous patch added this function, and calls it with smp_call_on_cpu(), > > where it'll run in IRQ context with IRQs disabled... > > smp_call_on_cpu() puts the work to the bind-cpu worker. Ah, sorry -- I had confused this with the smp_call_function*() family, which do this in IRQ context. > And this function will be called in task context, and IRQs is certainly enabled. Understood; given that, please ignore my comments below. Mark. > > > Zeng Heng > > > > struct fb_ctr_pair *fb_ctrs = val; > > > int cpu = fb_ctrs->cpu; > > > int ret; > > > + unsigned long timeout; > > > ret = cppc_get_perf_ctrs(cpu, &fb_ctrs->fb_ctrs_t0); > > > if (ret) > > > return ret; > > > - udelay(2); /* 2usec delay between sampling */ > > > + if (likely(!irqs_disabled())) { > > > + /* > > > + * Set 1ms as sampling interval, but never schedule > > > + * to the idle task to prevent the AMU counters from > > > + * stopping working. > > > + */ > > > + timeout = jiffies + msecs_to_jiffies(1); > > > + while (!time_after(jiffies, timeout)) > > > + cond_resched(); > > > + > > > + } else { > > ... so we'll enter this branch of the if-else ... > > > > > + pr_warn_once("CPU%d: Get rate in atomic context", cpu); > > ... and pr_warn_once() for something that's apparently normal and outside of > > the user's control? > > > > That doesn't make much sense to me. > > > > Mark. > > > > > + udelay(2); /* 2usec delay between sampling */ > > > + } > > > return cppc_get_perf_ctrs(cpu, &fb_ctrs->fb_ctrs_t1); > > > } > > > -- > > > 2.25.1 > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0DD1EC25B48 for ; Thu, 26 Oct 2023 11:27:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YxoDOj61lL4YQefP6nKnm/OY/UIWzip4sRMiIR6lP3U=; b=z2vxx/R+W/9/Mg gucREAN/8DtR5iLdDACbyuoM6qMImKjy7sSCMLAv8vHL4PmPBZ3JDPAKK/iWR8NtMO3bYD2TUWZ4o GHHhLeb+8YKvS607YXeJuksO6nYzqiAQ/bFvhKaG1nawmkAwjM2kwpuin8iBEVaban4EP7LwJ161O taFkMEl/n4sAhtbM0ciJjkOPIbZ/ecSp4HzYgLoUzLYAx1+9gwxEmZi6iZgOt34I0qNzHUGxsI5Ih 05/maru7Dk5vMQ+hP00gLwqAHxv3WdY+9YtN2SUY62g+rfb7oJp6MHt1YXINsTnAnBgw42ekqcSxm 5zu+rLV/xYm2FRYZ0Rog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvyVg-00EMZA-14; Thu, 26 Oct 2023 11:26:44 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvyVd-00EMYK-0v for linux-arm-kernel@lists.infradead.org; Thu, 26 Oct 2023 11:26:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E84CA2F4; Thu, 26 Oct 2023 04:27:16 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.70.231]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BB90E3F738; Thu, 26 Oct 2023 04:26:32 -0700 (PDT) Date: Thu, 26 Oct 2023 12:26:20 +0100 From: Mark Rutland To: Zeng Heng Cc: broonie@kernel.org, joey.gouly@arm.com, will@kernel.org, amit.kachhap@arm.com, rafael@kernel.org, catalin.marinas@arm.com, james.morse@arm.com, maz@kernel.org, viresh.kumar@linaro.org, sumitg@nvidia.com, yang@os.amperecomputing.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wangxiongfeng2@huawei.com, xiexiuqi@huawei.com, Ionela Voinescu Subject: Re: [PATCH 3/3] cpufreq: CPPC: Eliminate the impact of cpc_read() latency error Message-ID: References: <20231025093847.3740104-1-zengheng4@huawei.com> <20231025093847.3740104-4-zengheng4@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231026_042641_391459_03353478 X-CRM114-Status: GOOD ( 19.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBPY3QgMjYsIDIwMjMgYXQgMDk6NTU6MzlBTSArMDgwMCwgWmVuZyBIZW5nIHdyb3Rl Ogo+IAo+IOWcqCAyMDIzLzEwLzI1IDE5OjAxLCBNYXJrIFJ1dGxhbmQg5YaZ6YGTOgo+ID4gT24g V2VkLCBPY3QgMjUsIDIwMjMgYXQgMDU6Mzg6NDdQTSArMDgwMCwgWmVuZyBIZW5nIHdyb3RlOgo+ ID4gCj4gPiBUaGUgcHJldmlvdXMgcGF0Y2ggYWRkZWQgdGhpcyBmdW5jdGlvbiwgYW5kIGNhbGxz IGl0IHdpdGggc21wX2NhbGxfb25fY3B1KCksCj4gPiB3aGVyZSBpdCdsbCBydW4gaW4gSVJRIGNv bnRleHQgd2l0aCBJUlFzIGRpc2FibGVkLi4uCj4gCj4gc21wX2NhbGxfb25fY3B1KCkgcHV0cyB0 aGUgd29yayB0byB0aGUgYmluZC1jcHUgd29ya2VyLgoKQWgsIHNvcnJ5IC0tIEkgaGFkIGNvbmZ1 c2VkIHRoaXMgd2l0aCB0aGUgc21wX2NhbGxfZnVuY3Rpb24qKCkgZmFtaWx5LCB3aGljaCBkbwp0 aGlzIGluIElSUSBjb250ZXh0LgoKPiBBbmQgdGhpcyBmdW5jdGlvbiB3aWxsIGJlIGNhbGxlZCBp biB0YXNrIGNvbnRleHQsIGFuZCBJUlFzIGlzIGNlcnRhaW5seSBlbmFibGVkLgoKVW5kZXJzdG9v ZDsgZ2l2ZW4gdGhhdCwgcGxlYXNlIGlnbm9yZSBteSBjb21tZW50cyBiZWxvdy4KCk1hcmsuCgo+ IAo+IAo+IFplbmcgSGVuZwo+IAo+ID4gPiAgIAlzdHJ1Y3QgZmJfY3RyX3BhaXIgKmZiX2N0cnMg PSB2YWw7Cj4gPiA+ICAgCWludCBjcHUgPSBmYl9jdHJzLT5jcHU7Cj4gPiA+ICAgCWludCByZXQ7 Cj4gPiA+ICsJdW5zaWduZWQgbG9uZyB0aW1lb3V0Owo+ID4gPiAgIAlyZXQgPSBjcHBjX2dldF9w ZXJmX2N0cnMoY3B1LCAmZmJfY3Rycy0+ZmJfY3Ryc190MCk7Cj4gPiA+ICAgCWlmIChyZXQpCj4g PiA+ICAgCQlyZXR1cm4gcmV0Owo+ID4gPiAtCXVkZWxheSgyKTsgLyogMnVzZWMgZGVsYXkgYmV0 d2VlbiBzYW1wbGluZyAqLwo+ID4gPiArCWlmIChsaWtlbHkoIWlycXNfZGlzYWJsZWQoKSkpIHsK PiA+ID4gKwkJLyoKPiA+ID4gKwkJICogU2V0IDFtcyBhcyBzYW1wbGluZyBpbnRlcnZhbCwgYnV0 IG5ldmVyIHNjaGVkdWxlCj4gPiA+ICsJCSAqIHRvIHRoZSBpZGxlIHRhc2sgdG8gcHJldmVudCB0 aGUgQU1VIGNvdW50ZXJzIGZyb20KPiA+ID4gKwkJICogc3RvcHBpbmcgd29ya2luZy4KPiA+ID4g KwkJICovCj4gPiA+ICsJCXRpbWVvdXQgPSBqaWZmaWVzICsgbXNlY3NfdG9famlmZmllcygxKTsK PiA+ID4gKwkJd2hpbGUgKCF0aW1lX2FmdGVyKGppZmZpZXMsIHRpbWVvdXQpKQo+ID4gPiArCQkJ Y29uZF9yZXNjaGVkKCk7Cj4gPiA+ICsKPiA+ID4gKwl9IGVsc2Ugewo+ID4gLi4uIHNvIHdlJ2xs IGVudGVyIHRoaXMgYnJhbmNoIG9mIHRoZSBpZi1lbHNlIC4uLgo+ID4gCj4gPiA+ICsJCXByX3dh cm5fb25jZSgiQ1BVJWQ6IEdldCByYXRlIGluIGF0b21pYyBjb250ZXh0IiwgY3B1KTsKPiA+IC4u LiBhbmQgcHJfd2Fybl9vbmNlKCkgZm9yIHNvbWV0aGluZyB0aGF0J3MgYXBwYXJlbnRseSBub3Jt YWwgYW5kIG91dHNpZGUgb2YKPiA+IHRoZSB1c2VyJ3MgY29udHJvbD8KPiA+IAo+ID4gVGhhdCBk b2Vzbid0IG1ha2UgbXVjaCBzZW5zZSB0byBtZS4KPiA+IAo+ID4gTWFyay4KPiA+IAo+ID4gPiAr CQl1ZGVsYXkoMik7IC8qIDJ1c2VjIGRlbGF5IGJldHdlZW4gc2FtcGxpbmcgKi8KPiA+ID4gKwl9 Cj4gPiA+ICAgCXJldHVybiBjcHBjX2dldF9wZXJmX2N0cnMoY3B1LCAmZmJfY3Rycy0+ZmJfY3Ry c190MSk7Cj4gPiA+ICAgfQo+ID4gPiAtLSAKPiA+ID4gMi4yNS4xCj4gPiA+IAoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=