* Linux kernel 6.1 - drivers/usb/storage/unusual_cypress.h "Super Top" minimum bcdDevice too high @ 2023-10-26 15:32 LihaSika 2023-10-26 19:14 ` Greg KH 0 siblings, 1 reply; 20+ messages in thread From: LihaSika @ 2023-10-26 15:32 UTC (permalink / raw) To: stable; +Cc: regressions Hi, in kernel 6.1 (maybe 5.x - 6.x) there's an ATACB setting for "Super Top USB 2.0 SATA Bridge" -devices, where the minimum bcdDevice version to match has been set to 1.60. It's in the file drivers/usb/storage/unusual_cypress.h: """ UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, "Super Top", "USB 2.0 SATA BRIDGE", USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), """ My old USB HDD with a "Super Top" bridge has bcdDevice version 1.50, thus the setting won't match and it will not mount. I'm not sure when this changed (after kernel 4.x?), but it used to work before. Reading some earlier bug reports, it seems that the max version used to be 0x9999, which then caused corruption in "Super Top" devices with version >=2.20. So that's a reason for lowering the maximum value, but I wonder why the minimum value has also been set to 0x0160. I created a patch, changing 0x0160 to 0x0150 (though I should've left the max version as it was...): """ UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0150, """ Built, installed and rebooted; now the USB HDD can be mounted and works perfectly again. I did some write & read tests, checked with diff, cmp and md5sum - no corruption, everything OK 👍 Best regards, LihaS ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: Linux kernel 6.1 - drivers/usb/storage/unusual_cypress.h "Super Top" minimum bcdDevice too high 2023-10-26 15:32 Linux kernel 6.1 - drivers/usb/storage/unusual_cypress.h "Super Top" minimum bcdDevice too high LihaSika @ 2023-10-26 19:14 ` Greg KH 2023-10-26 19:39 ` LihaSika 0 siblings, 1 reply; 20+ messages in thread From: Greg KH @ 2023-10-26 19:14 UTC (permalink / raw) To: LihaSika; +Cc: stable, regressions On Thu, Oct 26, 2023 at 06:32:02PM +0300, LihaSika wrote: > Hi, > > in kernel 6.1 (maybe 5.x - 6.x) there's an ATACB setting for "Super Top USB > 2.0 SATA Bridge" -devices, where the minimum bcdDevice version to match has > been set to 1.60. It's in the file drivers/usb/storage/unusual_cypress.h: > > """ > UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, > "Super Top", > "USB 2.0 SATA BRIDGE", > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > """ > > My old USB HDD with a "Super Top" bridge has bcdDevice version 1.50, thus > the setting won't match and it will not mount. > > I'm not sure when this changed (after kernel 4.x?), but it used to work > before. Reading some earlier bug reports, it seems that the max version used > to be 0x9999, which then caused corruption in "Super Top" devices with > version >=2.20. So that's a reason for lowering the maximum value, but I > wonder why the minimum value has also been set to 0x0160. > > > I created a patch, changing 0x0160 to 0x0150 (though I should've left the > max version as it was...): > > """ > UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0150, > """ > > Built, installed and rebooted; now the USB HDD can be mounted and works > perfectly again. I did some write & read tests, checked with diff, cmp and > md5sum - no corruption, everything OK 👍 Please submit a proper patch to the linux-usb@vger.kernel.org mailing list and we will be glad to take it from there. thanks, greg k-h ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: Linux kernel 6.1 - drivers/usb/storage/unusual_cypress.h "Super Top" minimum bcdDevice too high 2023-10-26 19:14 ` Greg KH @ 2023-10-26 19:39 ` LihaSika 2023-10-27 1:27 ` Bagas Sanjaya 0 siblings, 1 reply; 20+ messages in thread From: LihaSika @ 2023-10-26 19:39 UTC (permalink / raw) To: linux-usb; +Cc: Greg KH On 26.10.2023 22.14, Greg KH wrote: > On Thu, Oct 26, 2023 at 06:32:02PM +0300, LihaSika wrote: >> Hi, >> >> in kernel 6.1 (maybe 5.x - 6.x) there's an ATACB setting for "Super Top USB >> 2.0 SATA Bridge" -devices, where the minimum bcdDevice version to match has >> been set to 1.60. It's in the file drivers/usb/storage/unusual_cypress.h: >> >> """ >> UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, >> "Super Top", >> "USB 2.0 SATA BRIDGE", >> USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), >> """ >> >> My old USB HDD with a "Super Top" bridge has bcdDevice version 1.50, thus >> the setting won't match and it will not mount. >> >> I'm not sure when this changed (after kernel 4.x?), but it used to work >> before. Reading some earlier bug reports, it seems that the max version used >> to be 0x9999, which then caused corruption in "Super Top" devices with >> version >=2.20. So that's a reason for lowering the maximum value, but I >> wonder why the minimum value has also been set to 0x0160. >> >> >> I created a patch, changing 0x0160 to 0x0150 (though I should've left the >> max version as it was...): >> >> """ >> UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0150, >> """ >> >> Built, installed and rebooted; now the USB HDD can be mounted and works >> perfectly again. I did some write & read tests, checked with diff, cmp and >> md5sum - no corruption, everything OK 👍 > > Please submit a proper patch to the linux-usb@vger.kernel.org mailing > list and we will be glad to take it from there. > > thanks, > > greg k-h OK, here it is! Best regards, L. -- $ cat lihasika-unusual_cypress.patch diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/unusual_cypress.h index 0547daf..7b3d5f0 100644 --- a/drivers/usb/storage/unusual_cypress.h +++ b/drivers/usb/storage/unusual_cypress.h @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, "Cypress ISD-300LP", USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, "Super Top", "USB 2.0 SATA BRIDGE", USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: Linux kernel 6.1 - drivers/usb/storage/unusual_cypress.h "Super Top" minimum bcdDevice too high 2023-10-26 19:39 ` LihaSika @ 2023-10-27 1:27 ` Bagas Sanjaya 2023-10-27 12:15 ` [PATCH] set 1.50 as the lower bcdDevice value for "Super Top"-device in drivers/usb/storage/unusual_cypress.h LihaSika 0 siblings, 1 reply; 20+ messages in thread From: Bagas Sanjaya @ 2023-10-27 1:27 UTC (permalink / raw) To: LihaSika, Linux USB, Linux USB Storage; +Cc: Greg KH, Alan Stern [-- Attachment #1: Type: text/plain, Size: 1367 bytes --] On Thu, Oct 26, 2023 at 10:39:14PM +0300, LihaSika wrote: > On 26.10.2023 22.14, Greg KH wrote: > > Please submit a proper patch to the linux-usb@vger.kernel.org mailing > > list and we will be glad to take it from there. > > > > thanks, > > > > greg k-h > > OK, here it is! > > Best regards, > L. > -- > > $ cat lihasika-unusual_cypress.patch > diff --git a/drivers/usb/storage/unusual_cypress.h > b/drivers/usb/storage/unusual_cypress.h > index 0547daf..7b3d5f0 100644 > --- a/drivers/usb/storage/unusual_cypress.h > +++ b/drivers/usb/storage/unusual_cypress.h > @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, > "Cypress ISD-300LP", > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > > -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, > +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, > "Super Top", > "USB 2.0 SATA BRIDGE", > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > Hi LihaSika, Please follow proper patch submission process in order to get above patch accepted. See Documentation/process/submitting-patches.rst in the kernel sources for how to do that properly. You may also consider adding `Cc: stable@vger.kernel.org` trailer in your patch to mark it to be backported to stable kernels (including one you use). Thanks. -- An old man doll... just what I always wanted! - Clara [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH] set 1.50 as the lower bcdDevice value for "Super Top"-device in drivers/usb/storage/unusual_cypress.h 2023-10-27 1:27 ` Bagas Sanjaya @ 2023-10-27 12:15 ` LihaSika 2023-10-27 12:22 ` Greg KH 0 siblings, 1 reply; 20+ messages in thread From: LihaSika @ 2023-10-27 12:15 UTC (permalink / raw) To: Bagas Sanjaya, Linux USB, Linux USB Storage; +Cc: Greg KH, Alan Stern On 27.10.2023 4.27, Bagas Sanjaya wrote: > On Thu, Oct 26, 2023 at 10:39:14PM +0300, LihaSika wrote: >> On 26.10.2023 22.14, Greg KH wrote: >>> Please submit a proper patch to the linux-usb@vger.kernel.org mailing >>> list and we will be glad to take it from there. >>> >>> thanks, >>> >>> greg k-h >> >> OK, here it is! >> >> Best regards, >> L. >> -- >> >> $ cat lihasika-unusual_cypress.patch >> diff --git a/drivers/usb/storage/unusual_cypress.h >> b/drivers/usb/storage/unusual_cypress.h >> index 0547daf..7b3d5f0 100644 >> --- a/drivers/usb/storage/unusual_cypress.h >> +++ b/drivers/usb/storage/unusual_cypress.h >> @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, >> "Cypress ISD-300LP", >> USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), >> >> -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, >> +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, >> "Super Top", >> "USB 2.0 SATA BRIDGE", >> USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), >> > > Hi LihaSika, > > Please follow proper patch submission process in order to get above patch > accepted. See Documentation/process/submitting-patches.rst in the kernel > sources for how to do that properly. You may also consider adding > `Cc: stable@vger.kernel.org` trailer in your patch to mark it to be > backported to stable kernels (including one you use). > > Thanks. > All right, here's a new attempt. Is it OK now? Cc: stable@vger.kernel.org Signed-off-by: Liha Sikanen <lihasika@gmail.com> --- diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/unusual_cypress.h index 0547daf..7b3d5f0 100644 --- a/drivers/usb/storage/unusual_cypress.h +++ b/drivers/usb/storage/unusual_cypress.h @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, "Cypress ISD-300LP", USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, "Super Top", "USB 2.0 SATA BRIDGE", USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH] set 1.50 as the lower bcdDevice value for "Super Top"-device in drivers/usb/storage/unusual_cypress.h 2023-10-27 12:15 ` [PATCH] set 1.50 as the lower bcdDevice value for "Super Top"-device in drivers/usb/storage/unusual_cypress.h LihaSika @ 2023-10-27 12:22 ` Greg KH 2023-10-27 12:37 ` LihaSika 0 siblings, 1 reply; 20+ messages in thread From: Greg KH @ 2023-10-27 12:22 UTC (permalink / raw) To: LihaSika; +Cc: Bagas Sanjaya, Linux USB, Linux USB Storage, Alan Stern On Fri, Oct 27, 2023 at 03:15:46PM +0300, LihaSika wrote: > On 27.10.2023 4.27, Bagas Sanjaya wrote: > > On Thu, Oct 26, 2023 at 10:39:14PM +0300, LihaSika wrote: > > > On 26.10.2023 22.14, Greg KH wrote: > > > > Please submit a proper patch to the linux-usb@vger.kernel.org mailing > > > > list and we will be glad to take it from there. > > > > > > > > thanks, > > > > > > > > greg k-h > > > > > > OK, here it is! > > > > > > Best regards, > > > L. > > > -- > > > > > > $ cat lihasika-unusual_cypress.patch > > > diff --git a/drivers/usb/storage/unusual_cypress.h > > > b/drivers/usb/storage/unusual_cypress.h > > > index 0547daf..7b3d5f0 100644 > > > --- a/drivers/usb/storage/unusual_cypress.h > > > +++ b/drivers/usb/storage/unusual_cypress.h > > > @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, > > > "Cypress ISD-300LP", > > > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > > > > > > -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, > > > +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, > > > "Super Top", > > > "USB 2.0 SATA BRIDGE", > > > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > > > > > > > Hi LihaSika, > > > > Please follow proper patch submission process in order to get above patch > > accepted. See Documentation/process/submitting-patches.rst in the kernel > > sources for how to do that properly. You may also consider adding > > `Cc: stable@vger.kernel.org` trailer in your patch to mark it to be > > backported to stable kernels (including one you use). > > > > Thanks. > > > > All right, here's a new attempt. Is it OK now? > > Cc: stable@vger.kernel.org > Signed-off-by: Liha Sikanen <lihasika@gmail.com> > --- > > diff --git a/drivers/usb/storage/unusual_cypress.h > b/drivers/usb/storage/unusual_cypress.h > index 0547daf..7b3d5f0 100644 > --- a/drivers/usb/storage/unusual_cypress.h > +++ b/drivers/usb/storage/unusual_cypress.h > @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, > "Cypress ISD-300LP", > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > > -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, > +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, > "Super Top", > "USB 2.0 SATA BRIDGE", > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch contains warnings and/or errors noticed by the scripts/checkpatch.pl tool. - Your patch is malformed (tabs converted to spaces, linewrapped, etc.) and can not be applied. Please read the file, Documentation/process/email-clients.rst in order to fix this. - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] set 1.50 as the lower bcdDevice value for "Super Top"-device in drivers/usb/storage/unusual_cypress.h 2023-10-27 12:22 ` Greg KH @ 2023-10-27 12:37 ` LihaSika 2023-10-27 12:46 ` Greg KH 2023-10-27 12:56 ` [PATCH] set 1.50 as the lower bcdDevice value for "Super Top"-device in drivers/usb/storage/unusual_cypress.h Bagas Sanjaya 0 siblings, 2 replies; 20+ messages in thread From: LihaSika @ 2023-10-27 12:37 UTC (permalink / raw) To: Linux USB > - Your patch is malformed (tabs converted to spaces, linewrapped, etc.) > and can not be applied. Please read the file, > Documentation/process/email-clients.rst in order to fix this. > Oh right, Thunderbird wrapped the first line of the patch file -.- Disabled wrapping, another attempt: Cc: stable@vger.kernel.org Signed-off-by: Liha Sikanen <lihasika@gmail.com> --- diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/unusual_cypress.h index 0547daf..7b3d5f0 100644 --- a/drivers/usb/storage/unusual_cypress.h +++ b/drivers/usb/storage/unusual_cypress.h @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, "Cypress ISD-300LP", USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, "Super Top", "USB 2.0 SATA BRIDGE", USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH] set 1.50 as the lower bcdDevice value for "Super Top"-device in drivers/usb/storage/unusual_cypress.h 2023-10-27 12:37 ` LihaSika @ 2023-10-27 12:46 ` Greg KH 2023-10-27 13:06 ` [PATCH] usb: storage: set 1.50 as the lower bcdDevice compatibility for older "Super Top"-device to work LihaSika 2023-10-27 12:56 ` [PATCH] set 1.50 as the lower bcdDevice value for "Super Top"-device in drivers/usb/storage/unusual_cypress.h Bagas Sanjaya 1 sibling, 1 reply; 20+ messages in thread From: Greg KH @ 2023-10-27 12:46 UTC (permalink / raw) To: LihaSika; +Cc: Linux USB On Fri, Oct 27, 2023 at 03:37:51PM +0300, LihaSika wrote: > > - Your patch is malformed (tabs converted to spaces, linewrapped, etc.) > > and can not be applied. Please read the file, > > Documentation/process/email-clients.rst in order to fix this. > > > > Oh right, Thunderbird wrapped the first line of the patch file -.- > > Disabled wrapping, another attempt: > > Cc: stable@vger.kernel.org > Signed-off-by: Liha Sikanen <lihasika@gmail.com> > --- Sorry, still needs a valid changelog and subject line. read all the errors that my patch-bot sent you. thanks, greg k-h ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH] usb: storage: set 1.50 as the lower bcdDevice compatibility for older "Super Top"-device to work 2023-10-27 12:46 ` Greg KH @ 2023-10-27 13:06 ` LihaSika 2023-10-27 13:41 ` [PATCH] usb: storage: set 1.50 as the lower bcdDevice for older "Super Top" compatibility LihaSika 0 siblings, 1 reply; 20+ messages in thread From: LihaSika @ 2023-10-27 13:06 UTC (permalink / raw) To: Linux USB On 27.10.2023 15.46, Greg KH wrote: > Sorry, still needs a valid changelog and subject line. read all the > errors that my patch-bot sent you. > > thanks, > > greg k-h OK, how about this: changelog: Change lower bcdDevice value for "Super Top USB 2.0 SATA BRIDGE" to match 1.50. I have such an older device with bcdDevice=1.50 and it will not work otherwise. Cc: stable@vger.kernel.org Signed-off-by: Liha Sikanen <lihasika@gmail.com> --- diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/unusual_cypress.h index 0547daf..7b3d5f0 100644 --- a/drivers/usb/storage/unusual_cypress.h +++ b/drivers/usb/storage/unusual_cypress.h @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, "Cypress ISD-300LP", USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, "Super Top", "USB 2.0 SATA BRIDGE", USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH] usb: storage: set 1.50 as the lower bcdDevice for older "Super Top" compatibility 2023-10-27 13:06 ` [PATCH] usb: storage: set 1.50 as the lower bcdDevice compatibility for older "Super Top"-device to work LihaSika @ 2023-10-27 13:41 ` LihaSika 2023-10-27 13:53 ` Greg KH 0 siblings, 1 reply; 20+ messages in thread From: LihaSika @ 2023-10-27 13:41 UTC (permalink / raw) To: Linux USB Change lower bcdDevice value for "Super Top USB 2.0 SATA BRIDGE" to match 1.50. I have such an older device with bcdDevice=1.50 and it will not work otherwise. Cc: stable@vger.kernel.org Signed-off-by: Liha Sikanen <lihasika@gmail.com> --- diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/unusual_cypress.h index 0547daf..7b3d5f0 100644 --- a/drivers/usb/storage/unusual_cypress.h +++ b/drivers/usb/storage/unusual_cypress.h @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, "Cypress ISD-300LP", USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, "Super Top", "USB 2.0 SATA BRIDGE", USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH] usb: storage: set 1.50 as the lower bcdDevice for older "Super Top" compatibility 2023-10-27 13:41 ` [PATCH] usb: storage: set 1.50 as the lower bcdDevice for older "Super Top" compatibility LihaSika @ 2023-10-27 13:53 ` Greg KH 2023-10-27 17:26 ` LihaSika 2023-10-27 17:28 ` LihaSika 0 siblings, 2 replies; 20+ messages in thread From: Greg KH @ 2023-10-27 13:53 UTC (permalink / raw) To: LihaSika; +Cc: Linux USB On Fri, Oct 27, 2023 at 04:41:23PM +0300, LihaSika wrote: > Change lower bcdDevice value for "Super Top USB 2.0 SATA BRIDGE" to match > 1.50. I have such an older device with bcdDevice=1.50 and it will not work > otherwise. > > Cc: stable@vger.kernel.org > Signed-off-by: Liha Sikanen <lihasika@gmail.com> > --- > > diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/unusual_cypress.h > index 0547daf..7b3d5f0 100644 > --- a/drivers/usb/storage/unusual_cypress.h > +++ b/drivers/usb/storage/unusual_cypress.h > @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, > "Cypress ISD-300LP", > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > > -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, > +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, > "Super Top", > "USB 2.0 SATA BRIDGE", > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > Much better, thanks, the subject and changelog text are great! But the patch is still corrupted, with tabs turned into spaces, and we can't apply it at all :( Can you fix that up and resend? thanks, greg k-h ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] usb: storage: set 1.50 as the lower bcdDevice for older "Super Top" compatibility 2023-10-27 13:53 ` Greg KH @ 2023-10-27 17:26 ` LihaSika 2023-10-27 17:28 ` LihaSika 1 sibling, 0 replies; 20+ messages in thread From: LihaSika @ 2023-10-27 17:26 UTC (permalink / raw) To: Greg KH; +Cc: Linux USB On 27.10.2023 16.53, Greg KH wrote: > > Much better, thanks, the subject and changelog text are great! > > But the patch is still corrupted, with tabs turned into spaces, and we > can't apply it at all :( > > Can you fix that up and resend? > > thanks, > > greg k-h My apologies for the extra trouble and thank you for your patience 🙏 As a not-totally-noob I should've known better to be more thorough 😔 To be sure, I re-created, rebuilt and re-tested the patch. Thunderbird also had to be told "mailnews.send_plaintext_flowed=false". I'll send the fixed patch next in a separate mail, hope I got it right now! Thank you, Liha ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH] usb: storage: set 1.50 as the lower bcdDevice for older "Super Top" compatibility 2023-10-27 13:53 ` Greg KH 2023-10-27 17:26 ` LihaSika @ 2023-10-27 17:28 ` LihaSika 2023-10-28 7:02 ` Bagas Sanjaya 1 sibling, 1 reply; 20+ messages in thread From: LihaSika @ 2023-10-27 17:28 UTC (permalink / raw) To: Linux USB Change lower bcdDevice value for "Super Top USB 2.0 SATA BRIDGE" to match 1.50. I have such an older device with bcdDevice=1.50 and it will not work otherwise. Cc: stable@vger.kernel.org Signed-off-by: Liha Sikanen <lihasika@gmail.com> --- diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/unusual_cypress.h index 0547daf..5df4075 100644 --- a/drivers/usb/storage/unusual_cypress.h +++ b/drivers/usb/storage/unusual_cypress.h @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, "Cypress ISD-300LP", USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, "Super Top", "USB 2.0 SATA BRIDGE", USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH] usb: storage: set 1.50 as the lower bcdDevice for older "Super Top" compatibility 2023-10-27 17:28 ` LihaSika @ 2023-10-28 7:02 ` Bagas Sanjaya 2023-10-28 10:23 ` Greg Kroah-Hartman 0 siblings, 1 reply; 20+ messages in thread From: Bagas Sanjaya @ 2023-10-28 7:02 UTC (permalink / raw) To: LihaSika, Linux USB, Linux USB Storage, Linux Kernel Mailing List Cc: Alan Stern, Greg Kroah-Hartman, Milan Svoboda, Matthieu Castet [-- Attachment #1: Type: text/plain, Size: 1642 bytes --] On Fri, Oct 27, 2023 at 08:28:04PM +0300, LihaSika wrote: > Change lower bcdDevice value for "Super Top USB 2.0 SATA BRIDGE" to match > 1.50. I have such an older device with bcdDevice=1.50 and it will not work > otherwise. What about below description? ``` Some old USB hard drives using Super Top USB 2.0 SATA bridge have lower minimum bcdDevice value than currently allowed (1.60). Such devices cannot be used by ums-cypress driver since their bcdDevice is out of range. Lower minimum bcdDevice to fix that. ``` > > Cc: stable@vger.kernel.org > Signed-off-by: Liha Sikanen <lihasika@gmail.com> Is your intended author name in your From: header or Signed-off-by: trailer? Also, don't forget to add Fixes: tag; that is: Fixes: a9c143c82608 ("usb-storage: restrict bcdDevice range for Super Top in Cypress ATACB") When above reviews are addressed, resend as v2. Make sure that the patch subject begins with `[PATCH v2]`. > --- > > diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/unusual_cypress.h > index 0547daf..5df4075 100644 > --- a/drivers/usb/storage/unusual_cypress.h > +++ b/drivers/usb/storage/unusual_cypress.h > @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, > "Cypress ISD-300LP", > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > > -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, > +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, > "Super Top", > "USB 2.0 SATA BRIDGE", > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > The diff itself is LGTM. Thanks. -- An old man doll... just what I always wanted! - Clara [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] usb: storage: set 1.50 as the lower bcdDevice for older "Super Top" compatibility 2023-10-28 7:02 ` Bagas Sanjaya @ 2023-10-28 10:23 ` Greg Kroah-Hartman 2023-10-28 11:05 ` Bagas Sanjaya 0 siblings, 1 reply; 20+ messages in thread From: Greg Kroah-Hartman @ 2023-10-28 10:23 UTC (permalink / raw) To: Bagas Sanjaya Cc: LihaSika, Linux USB, Linux USB Storage, Linux Kernel Mailing List, Alan Stern, Milan Svoboda, Matthieu Castet On Sat, Oct 28, 2023 at 02:02:37PM +0700, Bagas Sanjaya wrote: > On Fri, Oct 27, 2023 at 08:28:04PM +0300, LihaSika wrote: > > Change lower bcdDevice value for "Super Top USB 2.0 SATA BRIDGE" to match > > 1.50. I have such an older device with bcdDevice=1.50 and it will not work > > otherwise. > > What about below description? > > ``` > Some old USB hard drives using Super Top USB 2.0 SATA bridge have lower > minimum bcdDevice value than currently allowed (1.60). Such devices > cannot be used by ums-cypress driver since their bcdDevice is out of range. > > Lower minimum bcdDevice to fix that. > ``` > > > > > Cc: stable@vger.kernel.org > > Signed-off-by: Liha Sikanen <lihasika@gmail.com> > > Is your intended author name in your From: header or Signed-off-by: trailer? > > Also, don't forget to add Fixes: tag; that is: > > Fixes: a9c143c82608 ("usb-storage: restrict bcdDevice range for Super Top in Cypress ATACB") > > When above reviews are addressed, resend as v2. Make sure that the patch > subject begins with `[PATCH v2]`. There's no need, I can take this as-is, thanks. greg k-h ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] usb: storage: set 1.50 as the lower bcdDevice for older "Super Top" compatibility 2023-10-28 10:23 ` Greg Kroah-Hartman @ 2023-10-28 11:05 ` Bagas Sanjaya 2023-10-28 11:20 ` LihaSika 0 siblings, 1 reply; 20+ messages in thread From: Bagas Sanjaya @ 2023-10-28 11:05 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: LihaSika, Linux USB, Linux USB Storage, Linux Kernel Mailing List, Alan Stern, Milan Svoboda, Matthieu Castet On 28/10/2023 17:23, Greg Kroah-Hartman wrote: > On Sat, Oct 28, 2023 at 02:02:37PM +0700, Bagas Sanjaya wrote: >> On Fri, Oct 27, 2023 at 08:28:04PM +0300, LihaSika wrote: >>> Change lower bcdDevice value for "Super Top USB 2.0 SATA BRIDGE" to match >>> 1.50. I have such an older device with bcdDevice=1.50 and it will not work >>> otherwise. >> >> What about below description? >> >> ``` >> Some old USB hard drives using Super Top USB 2.0 SATA bridge have lower >> minimum bcdDevice value than currently allowed (1.60). Such devices >> cannot be used by ums-cypress driver since their bcdDevice is out of range. >> >> Lower minimum bcdDevice to fix that. >> ``` >> >>> >>> Cc: stable@vger.kernel.org >>> Signed-off-by: Liha Sikanen <lihasika@gmail.com> >> >> Is your intended author name in your From: header or Signed-off-by: trailer? >> >> Also, don't forget to add Fixes: tag; that is: >> >> Fixes: a9c143c82608 ("usb-storage: restrict bcdDevice range for Super Top in Cypress ATACB") >> >> When above reviews are addressed, resend as v2. Make sure that the patch >> subject begins with `[PATCH v2]`. > > There's no need, I can take this as-is, thanks. > OK, thanks! -- An old man doll... just what I always wanted! - Clara ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] usb: storage: set 1.50 as the lower bcdDevice for older "Super Top" compatibility 2023-10-28 11:05 ` Bagas Sanjaya @ 2023-10-28 11:20 ` LihaSika 0 siblings, 0 replies; 20+ messages in thread From: LihaSika @ 2023-10-28 11:20 UTC (permalink / raw) To: Bagas Sanjaya, Greg Kroah-Hartman; +Cc: Linux USB On 28.10.2023 14.05, Bagas Sanjaya wrote: > On 28/10/2023 17:23, Greg Kroah-Hartman wrote: >> >> There's no need, I can take this as-is, thanks. >> > > OK, thanks! > Thank you all 🙏 I will use git mail if I ever have any more to contribute in the future, thanks for all the advice 👍 Have a nice weekend! BR, Liha ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] set 1.50 as the lower bcdDevice value for "Super Top"-device in drivers/usb/storage/unusual_cypress.h 2023-10-27 12:37 ` LihaSika 2023-10-27 12:46 ` Greg KH @ 2023-10-27 12:56 ` Bagas Sanjaya 2023-10-27 13:05 ` Greg KH 1 sibling, 1 reply; 20+ messages in thread From: Bagas Sanjaya @ 2023-10-27 12:56 UTC (permalink / raw) To: LihaSika, Linux USB [-- Attachment #1: Type: text/plain, Size: 1399 bytes --] On Fri, Oct 27, 2023 at 03:37:51PM +0300, LihaSika wrote: > > - Your patch is malformed (tabs converted to spaces, linewrapped, etc.) > > and can not be applied. Please read the file, > > Documentation/process/email-clients.rst in order to fix this. > > > > Oh right, Thunderbird wrapped the first line of the patch file -.- > > Disabled wrapping, another attempt: > > Cc: stable@vger.kernel.org > Signed-off-by: Liha Sikanen <lihasika@gmail.com> > --- > > diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/unusual_cypress.h > index 0547daf..7b3d5f0 100644 > --- a/drivers/usb/storage/unusual_cypress.h > +++ b/drivers/usb/storage/unusual_cypress.h > @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, > "Cypress ISD-300LP", > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > > -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, > +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, > "Super Top", > "USB 2.0 SATA BRIDGE", > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > > > Hi, You have to use git-send-email(1) for the purpose of sending patches instead. Please see Documentation/process/email-clients.rst in the kernel sources for more information. And don't forget to address reviews from Greg's bot. Thanks. -- An old man doll... just what I always wanted! - Clara [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] set 1.50 as the lower bcdDevice value for "Super Top"-device in drivers/usb/storage/unusual_cypress.h 2023-10-27 12:56 ` [PATCH] set 1.50 as the lower bcdDevice value for "Super Top"-device in drivers/usb/storage/unusual_cypress.h Bagas Sanjaya @ 2023-10-27 13:05 ` Greg KH 2023-10-27 13:09 ` Bagas Sanjaya 0 siblings, 1 reply; 20+ messages in thread From: Greg KH @ 2023-10-27 13:05 UTC (permalink / raw) To: Bagas Sanjaya; +Cc: LihaSika, Linux USB On Fri, Oct 27, 2023 at 07:56:53PM +0700, Bagas Sanjaya wrote: > On Fri, Oct 27, 2023 at 03:37:51PM +0300, LihaSika wrote: > > > - Your patch is malformed (tabs converted to spaces, linewrapped, etc.) > > > and can not be applied. Please read the file, > > > Documentation/process/email-clients.rst in order to fix this. > > > > > > > Oh right, Thunderbird wrapped the first line of the patch file -.- > > > > Disabled wrapping, another attempt: > > > > Cc: stable@vger.kernel.org > > Signed-off-by: Liha Sikanen <lihasika@gmail.com> > > --- > > > > diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/unusual_cypress.h > > index 0547daf..7b3d5f0 100644 > > --- a/drivers/usb/storage/unusual_cypress.h > > +++ b/drivers/usb/storage/unusual_cypress.h > > @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, > > "Cypress ISD-300LP", > > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > > > > -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, > > +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, > > "Super Top", > > "USB 2.0 SATA BRIDGE", > > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > > > > > > > > Hi, > > You have to use git-send-email(1) for the purpose of sending patches > instead. Please see Documentation/process/email-clients.rst in the kernel > sources for more information. And don't forget to address reviews from > Greg's bot. You don't have to use git send-email, that's not required at all, it's just there to make things easier for some people. thanks, greg k-h ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] set 1.50 as the lower bcdDevice value for "Super Top"-device in drivers/usb/storage/unusual_cypress.h 2023-10-27 13:05 ` Greg KH @ 2023-10-27 13:09 ` Bagas Sanjaya 0 siblings, 0 replies; 20+ messages in thread From: Bagas Sanjaya @ 2023-10-27 13:09 UTC (permalink / raw) To: Greg KH; +Cc: LihaSika, Linux USB On 27/10/2023 20:05, Greg KH wrote: > On Fri, Oct 27, 2023 at 07:56:53PM +0700, Bagas Sanjaya wrote: >> On Fri, Oct 27, 2023 at 03:37:51PM +0300, LihaSika wrote: >>>> - Your patch is malformed (tabs converted to spaces, linewrapped, etc.) >>>> and can not be applied. Please read the file, >>>> Documentation/process/email-clients.rst in order to fix this. >>>> >>> >>> Oh right, Thunderbird wrapped the first line of the patch file -.- >>> >>> Disabled wrapping, another attempt: >>> >>> Cc: stable@vger.kernel.org >>> Signed-off-by: Liha Sikanen <lihasika@gmail.com> >>> --- >>> >>> diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/unusual_cypress.h >>> index 0547daf..7b3d5f0 100644 >>> --- a/drivers/usb/storage/unusual_cypress.h >>> +++ b/drivers/usb/storage/unusual_cypress.h >>> @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, >>> "Cypress ISD-300LP", >>> USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), >>> >>> -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, >>> +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, >>> "Super Top", >>> "USB 2.0 SATA BRIDGE", >>> USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), >>> >>> >>> >> >> Hi, >> >> You have to use git-send-email(1) for the purpose of sending patches >> instead. Please see Documentation/process/email-clients.rst in the kernel >> sources for more information. And don't forget to address reviews from >> Greg's bot. > > You don't have to use git send-email, that's not required at all, it's > just there to make things easier for some people. > Thanks for the tip. IMO, this is the submitter's first patch submission where he had to set up appropriate tooling. -- An old man doll... just what I always wanted! - Clara ^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2023-10-28 11:20 UTC | newest] Thread overview: 20+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-10-26 15:32 Linux kernel 6.1 - drivers/usb/storage/unusual_cypress.h "Super Top" minimum bcdDevice too high LihaSika 2023-10-26 19:14 ` Greg KH 2023-10-26 19:39 ` LihaSika 2023-10-27 1:27 ` Bagas Sanjaya 2023-10-27 12:15 ` [PATCH] set 1.50 as the lower bcdDevice value for "Super Top"-device in drivers/usb/storage/unusual_cypress.h LihaSika 2023-10-27 12:22 ` Greg KH 2023-10-27 12:37 ` LihaSika 2023-10-27 12:46 ` Greg KH 2023-10-27 13:06 ` [PATCH] usb: storage: set 1.50 as the lower bcdDevice compatibility for older "Super Top"-device to work LihaSika 2023-10-27 13:41 ` [PATCH] usb: storage: set 1.50 as the lower bcdDevice for older "Super Top" compatibility LihaSika 2023-10-27 13:53 ` Greg KH 2023-10-27 17:26 ` LihaSika 2023-10-27 17:28 ` LihaSika 2023-10-28 7:02 ` Bagas Sanjaya 2023-10-28 10:23 ` Greg Kroah-Hartman 2023-10-28 11:05 ` Bagas Sanjaya 2023-10-28 11:20 ` LihaSika 2023-10-27 12:56 ` [PATCH] set 1.50 as the lower bcdDevice value for "Super Top"-device in drivers/usb/storage/unusual_cypress.h Bagas Sanjaya 2023-10-27 13:05 ` Greg KH 2023-10-27 13:09 ` Bagas Sanjaya
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.